Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Menu component should take id prop #165

Closed
suzubara opened this issue May 18, 2020 · 0 comments · Fixed by #188
Closed

Menu component should take id prop #165

suzubara opened this issue May 18, 2020 · 0 comments · Fixed by #188
Assignees
@duncan-truss
Labels
good first issue Good for newcomers type: bug Something isn't working like it's supposed to

Comments

@suzubara
Copy link
Contributor

suzubara commented May 18, 2020 •
edited
Loading

Right now, the NavDropDownButton component implements a prop called menuId which is meant to be the id attribute of the corresponding Menu. However the Menu component doesn't accept an id prop. It should be modified to accept all ul props (ie., using React.HTMLAttributes<HTMLUListElement>) and pass them into the rendered NavList.

The same change should also be made to the MegaMenu component.
@suzubara suzubara added type: bug Something isn't working like it's supposed to good first issue Good for newcomers labels May 18, 2020
@duncan-truss duncan-truss self-assigned this May 20, 2020
duncan-truss added a commit that referenced this issue May 20, 2020
@duncan-truss
fix: extends header menu to accept list props for corresponding id
0a9ed33 
fix #165
@duncan-truss duncan-truss mentioned this issue May 20, 2020
Merged
duncan-truss added a commit that referenced this issue May 21, 2020
@duncan-truss
fix: extends header menu to accept list props for corresponding id (#188
85a1780 
)

fix #165
@suzubara suzubara mentioned this issue May 28, 2020
Merged
suzubara pushed a commit that referenced this issue May 28, 2020
@dependabot-preview @duncan-truss
@eamahanna @haworku
chore(release): Release 1.4.0 (#211)
7b324ce 
* Bump standard-version from 7.1.0 to 8.0.0

Bumps [standard-version](https://github.com/conventional-changelog/standard-version) from 7.1.0 to 8.0.0.
- [Release notes](https://github.com/conventional-changelog/standard-version/releases)
- [Changelog](https://github.com/conventional-changelog/standard-version/blob/master/CHANGELOG.md)
- [Commits](conventional-changelog/standard-version@v7.1.0...v8.0.0)

Signed-off-by: dependabot-preview[bot] <[email protected]>

* Created issue templates

Created issue templates for feature request & bug report, with default labels.

* fix: removes the usa-search class name from the form component (#184)

fix #163

* fix: accept id and name props for Search component input field (#183)

* fix: accept id and name props for Search component input field
* fix: qualify id and name props for input field to not clash with form
fix #162

* feat: add dateInput component for forms (#144)

* Added dateInput component and dateInputGroup component for forms

* fix: extends header menu to accept list props for corresponding id (#188)

fix #165

* fix: update gov banner to uswds version 2.7.0

* chore: upgrade uswds to 2.7.0

* docs: add documentation for Trussels (#190)

* docs: add documentation for Trussels

* docs: clean up readme to meet project standards

* docs: add to active maintainers

* docs: add first pass of security policy

Co-authored-by: HANA <[email protected]>

* feat: add Footer component #142 (#146)

- adds slim, medium, and big footers with mobile styles
- adds new components, specifically Address, Footer,  FooterNav, FooterExtendedNavList, Logo, SocialLinks

* build(deps-dev): bump @testing-library/jest-dom from 5.7.0 to 5.8.0 (#197)

* build(deps-dev): bump typescript from 3.9.2 to 3.9.3 (#196)

* build(deps-dev): bump @storybook/react from 5.3.18 to 5.3.19 (#198)

* build(deps-dev): bump stylelint from 13.4.1 to 13.5.0 (#199)

* build(deps-dev): bump lint-staged from 10.2.4 to 10.2.6 (#200)

* build(deps-dev): bump @storybook/addon-info from 5.3.18 to 5.3.19 (#201)

* feat(rangeinput): creates form RangeInput component, test, and stories (#194)

* feat(rangeinput): creates form RangeInput component, test, and stories

* feat: add RangeInput component to index.ts for entrypoint export

* feat: remove overalpping interface props with HTMLInputAttributes type

* feat: require id and name props, remove label, remove redundant unpack

* feat: remove unused label import in component, show label usage in story

fixes #81

* docs: add landing page and documentation page template stories (#195)

* docs: add landing page and documentation page template stories

* docs(storybook): add current class to header navigation

* ci: lint PR titles instead of commits #159 (#210)

* chore: add semantic pr workflow

* chore: update workflow

* Remove commitlint hook

* Clarify PR linting requirement

Co-authored-by: HANA <[email protected]>

* chore(release): 1.4.0

* Remove duplicate entry from changelog

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Co-authored-by: Duncan <[email protected]>
Co-authored-by: Emily Mahanna <[email protected]>
Co-authored-by: HANA <[email protected]>
@haworku haworku mentioned this issue Jun 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@duncan-truss duncan-truss

Labels
good first issue Good for newcomers type: bug Something isn't working like it's supposed to
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: extends header menu to accept list props for corresponding id trussworks/react-uswds
2 participants
@suzubara @duncan-truss