Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: lint PR titles instead of commits #159 #210

Merged
merged 4 commits into from
May 28, 2020
Merged

Conversation

suzubara
Copy link
Contributor

@suzubara suzubara commented May 28, 2020

Fixes #159

Instead of linting every single commit message, only lint PR titles (when the base branch is develop or master) so that when PRs are squash merged, their titles will represent a single entry in the generated changelog.

➜ yarn audit
yarn audit v1.13.0
┌───────────────┬──────────────────────────────────────────────────────────────┐
│ low           │ Prototype Pollution                                          │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Package       │ yargs-parser                                                 │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Patched in    │ >=13.1.2 <14.0.0 || >=15.0.1 <16.0.0 || >=18.1.2             │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Dependency of │ standard-version                                             │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Path          │ standard-version > conventional-recommended-bump >           │
│               │ conventional-commits-parser > meow > yargs-parser            │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ More info     │ https://nodesecurity.io/advisories/1500                      │
└───────────────┴──────────────────────────────────────────────────────────────┘
┌───────────────┬──────────────────────────────────────────────────────────────┐
│ moderate      │ Regular Expression Denial of Service                         │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Package       │ marked                                                       │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Patched in    │ >=0.6.2                                                      │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Dependency of │ @storybook/addon-info                                        │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Path          │ @storybook/addon-info > marksy > marked                      │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ More info     │ https://nodesecurity.io/advisories/812                       │
└───────────────┴──────────────────────────────────────────────────────────────┘
┌───────────────┬──────────────────────────────────────────────────────────────┐
│ low           │ Prototype Pollution                                          │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Package       │ yargs-parser                                                 │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Patched in    │ >=13.1.2 <14.0.0 || >=15.0.1 <16.0.0 || >=18.1.2             │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Dependency of │ standard-version                                             │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Path          │ standard-version > conventional-recommended-bump >           │
│               │ git-semver-tags > meow > yargs-parser                        │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ More info     │ https://nodesecurity.io/advisories/1500                      │
└───────────────┴──────────────────────────────────────────────────────────────┘
┌───────────────┬──────────────────────────────────────────────────────────────┐
│ low           │ Prototype Pollution                                          │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Package       │ yargs-parser                                                 │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Patched in    │ >=13.1.2 <14.0.0 || >=15.0.1 <16.0.0 || >=18.1.2             │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Dependency of │ standard-version                                             │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Path          │ standard-version > git-semver-tags > meow > yargs-parser     │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ More info     │ https://nodesecurity.io/advisories/1500                      │
└───────────────┴──────────────────────────────────────────────────────────────┘
┌───────────────┬──────────────────────────────────────────────────────────────┐
│ low           │ Prototype Pollution                                          │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Package       │ yargs-parser                                                 │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Patched in    │ >=13.1.2 <14.0.0 || >=15.0.1 <16.0.0 || >=18.1.2             │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Dependency of │ standard-version                                             │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Path          │ standard-version > conventional-recommended-bump > meow >    │
│               │ yargs-parser                                                 │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ More info     │ https://nodesecurity.io/advisories/1500                      │
└───────────────┴──────────────────────────────────────────────────────────────┘
5 vulnerabilities found - Packages audited: 2170
Severity: 4 Low | 1 Moderate
✨  Done in 1.84s.

@suzubara suzubara changed the title Sr lint pr titles 159 test: Sr lint pr titles 159 May 28, 2020
@suzubara suzubara changed the base branch from sr-example-app-77 to develop May 28, 2020 15:05
@suzubara suzubara changed the title test: Sr lint pr titles 159 testlskfja: Sr lint pr titles 159 May 28, 2020
@suzubara suzubara changed the title testlskfja: Sr lint pr titles 159 ci: lint PR titles instead of commits #159 May 28, 2020
docs/contributing.md Outdated Show resolved Hide resolved
@suzubara suzubara merged commit 858ce5f into develop May 28, 2020
@suzubara suzubara deleted the sr-lint-pr-titles-159 branch May 28, 2020 17:29
suzubara pushed a commit that referenced this pull request May 28, 2020
* Bump standard-version from 7.1.0 to 8.0.0

Bumps [standard-version](https://github.com/conventional-changelog/standard-version) from 7.1.0 to 8.0.0.
- [Release notes](https://github.com/conventional-changelog/standard-version/releases)
- [Changelog](https://github.com/conventional-changelog/standard-version/blob/master/CHANGELOG.md)
- [Commits](conventional-changelog/standard-version@v7.1.0...v8.0.0)

Signed-off-by: dependabot-preview[bot] <[email protected]>

* Created issue templates

Created issue templates for feature request & bug report, with default labels.

* fix: removes the usa-search class name from the form component (#184)

fix #163

* fix: accept id and name props for Search component input field (#183)

* fix: accept id and name props for Search component input field
* fix: qualify id and name props for input field to not clash with form
fix #162

* feat: add dateInput component for forms (#144)

* Added dateInput component and dateInputGroup component for forms

* fix: extends header menu to accept list props for corresponding id (#188)

fix #165

* fix: update gov banner to uswds version 2.7.0

* chore: upgrade uswds to 2.7.0

* docs: add documentation for Trussels (#190)

* docs: add documentation for Trussels

* docs: clean up readme to meet project standards

* docs: add to active maintainers

* docs: add first pass of security policy

Co-authored-by: HANA <[email protected]>

* feat: add Footer component #142 (#146)

- adds slim, medium, and big footers with mobile styles
- adds new components, specifically Address, Footer,  FooterNav, FooterExtendedNavList, Logo, SocialLinks

* build(deps-dev): bump @testing-library/jest-dom from 5.7.0 to 5.8.0 (#197)

* build(deps-dev): bump typescript from 3.9.2 to 3.9.3 (#196)

* build(deps-dev): bump @storybook/react from 5.3.18 to 5.3.19 (#198)

* build(deps-dev): bump stylelint from 13.4.1 to 13.5.0 (#199)

* build(deps-dev): bump lint-staged from 10.2.4 to 10.2.6 (#200)

* build(deps-dev): bump @storybook/addon-info from 5.3.18 to 5.3.19 (#201)

* feat(rangeinput): creates form RangeInput component, test, and stories (#194)

* feat(rangeinput): creates form RangeInput component, test, and stories

* feat: add RangeInput component to index.ts for entrypoint export

* feat: remove overalpping interface props with HTMLInputAttributes type

* feat: require id and name props, remove label, remove redundant unpack

* feat: remove unused label import in component, show label usage in story

fixes #81

* docs: add landing page and documentation page template stories (#195)

* docs: add landing page and documentation page template stories

* docs(storybook): add current class to header navigation

* ci: lint PR titles instead of commits #159 (#210)

* chore: add semantic pr workflow

* chore: update workflow

* Remove commitlint hook

* Clarify PR linting requirement

Co-authored-by: HANA <[email protected]>

* chore(release): 1.4.0

* Remove duplicate entry from changelog

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Co-authored-by: Duncan <[email protected]>
Co-authored-by: Emily Mahanna <[email protected]>
Co-authored-by: HANA <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Only lint merge commits / squash & merge PRs
2 participants