Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

USWDS Component: Range slider #81

Closed
suzubara opened this issue Apr 15, 2020 · 1 comment · Fixed by #194
Closed

USWDS Component: Range slider #81

suzubara opened this issue Apr 15, 2020 · 1 comment · Fixed by #194
Assignees
@duncan-truss
Labels
type: feature New feature or request

Comments

@suzubara
Copy link
Contributor

Add Range slider component: https://designsystem.digital.gov/components/form-controls/#range
@haworku
Copy link
Contributor

haworku commented May 20, 2020 •
edited by suzubara
Loading

Suggested scope:

  • New component should be added to the existing Form folder
  • Props must handle HTML range input behaviors. This include min, max, stepand the input value. Will also need to be able to call an event handler on change to update parent.
  • Both keyboard interaction or click to drag should move the slider
  • As per uswds docs, "set the step attribute so it’s not too granular"
  • As per uswds docs, provide a way for optional labels to be added to the beginning and end of slider to describe the min and max values.

@suzubara suzubara added type: feature New feature or request and removed new component labels May 20, 2020
@duncan-truss duncan-truss self-assigned this May 20, 2020
duncan-truss added a commit that referenced this issue May 21, 2020
@duncan-truss
feat(rangeinput): creates form RangeInput component, test, and stories
1a37d1a 
#81
@duncan-truss duncan-truss mentioned this issue May 21, 2020
Merged
@duncan-truss duncan-truss linked a pull request May 21, 2020 that will close this issue
feat(rangeinput): creates form RangeInput component, test, and stories #194
Merged
duncan-truss added a commit that referenced this issue May 26, 2020
@duncan-truss
feat(rangeinput): creates form RangeInput component, test, and stories (
8e0179f 
#194)

* feat(rangeinput): creates form RangeInput component, test, and stories

* feat: add RangeInput component to index.ts for entrypoint export

* feat: remove overalpping interface props with HTMLInputAttributes type

* feat: require id and name props, remove label, remove redundant unpack

* feat: remove unused label import in component, show label usage in story

fixes #81
@suzubara suzubara mentioned this issue May 28, 2020
Merged
suzubara pushed a commit that referenced this issue May 28, 2020
@dependabot-preview @duncan-truss
@eamahanna @haworku
chore(release): Release 1.4.0 (#211)
7b324ce 
* Bump standard-version from 7.1.0 to 8.0.0

Bumps [standard-version](https://github.com/conventional-changelog/standard-version) from 7.1.0 to 8.0.0.
- [Release notes](https://github.com/conventional-changelog/standard-version/releases)
- [Changelog](https://github.com/conventional-changelog/standard-version/blob/master/CHANGELOG.md)
- [Commits](conventional-changelog/standard-version@v7.1.0...v8.0.0)

Signed-off-by: dependabot-preview[bot] <[email protected]>

* Created issue templates

Created issue templates for feature request & bug report, with default labels.

* fix: removes the usa-search class name from the form component (#184)

fix #163

* fix: accept id and name props for Search component input field (#183)

* fix: accept id and name props for Search component input field
* fix: qualify id and name props for input field to not clash with form
fix #162

* feat: add dateInput component for forms (#144)

* Added dateInput component and dateInputGroup component for forms

* fix: extends header menu to accept list props for corresponding id (#188)

fix #165

* fix: update gov banner to uswds version 2.7.0

* chore: upgrade uswds to 2.7.0

* docs: add documentation for Trussels (#190)

* docs: add documentation for Trussels

* docs: clean up readme to meet project standards

* docs: add to active maintainers

* docs: add first pass of security policy

Co-authored-by: HANA <[email protected]>

* feat: add Footer component #142 (#146)

- adds slim, medium, and big footers with mobile styles
- adds new components, specifically Address, Footer,  FooterNav, FooterExtendedNavList, Logo, SocialLinks

* build(deps-dev): bump @testing-library/jest-dom from 5.7.0 to 5.8.0 (#197)

* build(deps-dev): bump typescript from 3.9.2 to 3.9.3 (#196)

* build(deps-dev): bump @storybook/react from 5.3.18 to 5.3.19 (#198)

* build(deps-dev): bump stylelint from 13.4.1 to 13.5.0 (#199)

* build(deps-dev): bump lint-staged from 10.2.4 to 10.2.6 (#200)

* build(deps-dev): bump @storybook/addon-info from 5.3.18 to 5.3.19 (#201)

* feat(rangeinput): creates form RangeInput component, test, and stories (#194)

* feat(rangeinput): creates form RangeInput component, test, and stories

* feat: add RangeInput component to index.ts for entrypoint export

* feat: remove overalpping interface props with HTMLInputAttributes type

* feat: require id and name props, remove label, remove redundant unpack

* feat: remove unused label import in component, show label usage in story

fixes #81

* docs: add landing page and documentation page template stories (#195)

* docs: add landing page and documentation page template stories

* docs(storybook): add current class to header navigation

* ci: lint PR titles instead of commits #159 (#210)

* chore: add semantic pr workflow

* chore: update workflow

* Remove commitlint hook

* Clarify PR linting requirement

Co-authored-by: HANA <[email protected]>

* chore(release): 1.4.0

* Remove duplicate entry from changelog

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Co-authored-by: Duncan <[email protected]>
Co-authored-by: Emily Mahanna <[email protected]>
Co-authored-by: HANA <[email protected]>
@haworku haworku mentioned this issue Jun 29, 2020
Merged
@eeeady eeeady mentioned this issue Dec 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@duncan-truss duncan-truss

Labels
type: feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(rangeinput): creates form RangeInput component, test, and stories trussworks/react-uswds
3 participants
@suzubara @haworku @duncan-truss