jarek/5780: reduce duplication in evaluators #5788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # kernel/base/src/main/java/com/twosigma/beakerx/evaluator/BaseEvaluator.java # kernel/clojure/src/main/java/com/twosigma/beakerx/clojure/kernel/ClojureEvaluator.java # kernel/cpp/src/main/java/com/twosigma/beakerx/cpp/kernel/CppEvaluator.java # kernel/groovy/src/main/java/com/twosigma/beakerx/groovy/evaluator/GroovyEvaluator.java # kernel/java/src/main/java/com/twosigma/beakerx/javash/evaluator/JavaEvaluator.java # kernel/kotlin/src/main/java/com/twosigma/beakerx/kotlin/evaluator/KotlinEvaluator.java # kernel/scala/src/main/java/com/twosigma/beakerx/scala/evaluator/ScalaEvaluator.java # kernel/sql/src/main/java/com/twosigma/beakerx/sql/evaluator/SQLEvaluator.java
# Conflicts: # kernel/base/src/main/java/com/twosigma/beakerx/evaluator/BaseEvaluator.java # kernel/clojure/src/main/java/com/twosigma/beakerx/clojure/kernel/ClojureEvaluator.java # kernel/cpp/src/main/java/com/twosigma/beakerx/cpp/kernel/CppEvaluator.java # kernel/groovy/src/main/java/com/twosigma/beakerx/groovy/evaluator/GroovyEvaluator.java # kernel/java/src/main/java/com/twosigma/beakerx/javash/evaluator/JavaEvaluator.java # kernel/kotlin/src/main/java/com/twosigma/beakerx/kotlin/evaluator/KotlinEvaluator.java # kernel/scala/src/main/java/com/twosigma/beakerx/scala/evaluator/ScalaEvaluator.java # kernel/sql/src/main/java/com/twosigma/beakerx/sql/evaluator/SQLEvaluator.java
michalgce
added a commit
that referenced
this pull request
Aug 21, 2017
* origin/master: (21 commits) better source linking, fix missing rel instruction bump version to 0.2.4 bump version to 0.2.3 workaround #5864 fix error setupbase.py on windows (#5863) bump version to 0.2.2, fix #5861 also install our config for the kernelspec manager install our custom css, update author email and website url, add keywords install nbextension, rename entry point for installer, document in readme Leif/fix packaging (#5857) Fix "kernels" cmd (#5849) update version, correct location of version file #5726: use pypi instead of github (#5797) #5810 Fixed lsmagic output. (#5839) #5782 allow setting dpi for png export (#5841) #5909 Fixed Magic import with no arg. (#5840) jarek/5780: reduce duplication in evaluators (#5788) #5767 add links to jvm-repr doc, improve tablesaw doc (#5835) remove "Table Saw" #5597 make widgets publishable (#5830) ... # Conflicts: # beakerx/js/webpack.config.js # beakerx/setup.py
jaroslawmalekcodete
deleted the
jarek/5780_evaluators_reduce_duplication
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.