Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#5726: use pypi instead of github #5797

Merged
merged 11 commits into from
Aug 15, 2017
Merged

#5726: use pypi instead of github #5797

merged 11 commits into from
Aug 15, 2017

Conversation

gnestor
Copy link
Contributor

@gnestor gnestor commented Aug 4, 2017

This separate our wrappers (wraps default setuptools commands/tasks with custom commands) into develop (for developers) and install (for users) so that js and java builds are only run for develop and the kernel, kernelspec, and custom_css commands are run for all. With this, we can remove the post-link scripts from the conda recipe (as this serves the same function). This will allow users to install beakerx as follows:

pip install beakerx
jupyter nbextension install beakerx --py --sys-prefix
jupyter nbextension enable beakerx --py --sys-prefix

@scottdraves
Copy link
Contributor

scottdraves commented Aug 7, 2017

Thanks Grant this looks like it solves the basic problem.
I was able to get it to build the kernels using the dev instructions, and the jars were used in their locations as placed by gradle. Cool.

However I had to make the following changes to the readme:

-conda create -y -n beakerx python=3.5 jupyter openjdk yarn
+conda create -y -n beakerx python=3.5 jupyter openjdk pandas nodejs

-(cd beakerx; pip install -e beakerx --verbose)
+pip install -e beakerx --verbose

and even then I was getting this error:

    running custom_css
    /Users/spot/anaconda/envs/testx/lib/python3.5/site-packages/setuptools-27.2.0-py3.5.egg/setuptools/dist.py:331: UserWarning: Normalizing '0.1.1.dev' to '0.1.1.dev0'
    error: [Errno 2] No such file or directory: '/Users/spot/src/beakerx/beakerx/beakerx/static/custom'

let's talk about it. thx.

@gnestor
Copy link
Contributor Author

gnestor commented Aug 10, 2017

I have tested many times and have not been able to reproduce that error with the custom_css command.

I have updated the README according to your comment and cleaned things up a bit.

I am now unable to get conda install -c beakerx beakerx to work, I get an error on the post-link script:

ERROR conda.core.link:_execute_actions(337): An error occurred while installing package 'beakerx::beakerx-0.1.0.dev0-py35h5a3ff1a_0'.
LinkError: post-link script failed for package beakerx::beakerx-0.1.0.dev0-py35h5a3ff1a_0
running your command again with `-v` will provide additional information
location of failed script: /Users/grant/anaconda/envs/beakerx2/bin/.beakerx-post-link.sh
==> script messages <==
<None>

The post-link just runs jupyter install beakerx --py --sys-prefix and jupyter enable beakerx --py --sys-prefix.

It's odd because nothing has changed except that I created a new conda environment based on the current README.

So, I think we should merge this soon and maybe update the README to favor the pip method vs. conda method.

@scottdraves
Copy link
Contributor

i tried again and now i get this error:


        ERROR in ./~/css-loader!./~/sass-loader/lib/loader.js!./src/easyForm/css/jupyter-easyform.scss
        Module build failed: Error: Missing binding /Users/scottdraves/src/beakerx/beakerx/js/node_modules/node-sa\
ss/vendor/darwin-x64-48/binding.node
        Node Sass could not find a binding for your current environment: OS X 64-bit with Node.js 6.x

        Found bindings for the following environments:
          - OS X 64-bit with Node.js 8.x

@gnestor
Copy link
Contributor Author

gnestor commented Aug 15, 2017

Ah, I've seen this! This is usually caused by upgrading to a newer major version of Node. Try rebuilding node-sass (npm rebuild node-sass) or just removing the node_modules directory and reinstalling (rm -rf node_modules && npm install).

@scottdraves scottdraves merged commit afe8330 into master Aug 15, 2017
@scottdraves
Copy link
Contributor

sorry, my mistake! i forgot to clean out my repo.

🐬

@gnestor gnestor deleted the gnestor/5726 branch August 15, 2017 03:28
michalgce added a commit that referenced this pull request Aug 21, 2017
* origin/master: (21 commits)
  better source linking, fix missing rel instruction
  bump version to 0.2.4
  bump version to 0.2.3
  workaround #5864
  fix error setupbase.py on windows (#5863)
  bump version to 0.2.2, fix #5861
  also install our config for the kernelspec manager
  install our custom css, update author email and website url, add keywords
  install nbextension, rename entry point for installer, document in readme
  Leif/fix packaging (#5857)
  Fix "kernels" cmd (#5849)
  update version, correct location of version file
  #5726: use pypi instead of github (#5797)
  #5810 Fixed lsmagic output. (#5839)
  #5782 allow setting dpi for png export (#5841)
  #5909 Fixed Magic import with no arg. (#5840)
  jarek/5780: reduce duplication in evaluators  (#5788)
  #5767 add links to jvm-repr doc, improve tablesaw doc (#5835)
  remove "Table Saw"
  #5597 make widgets publishable (#5830)
  ...

# Conflicts:
#	beakerx/js/webpack.config.js
#	beakerx/setup.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants