docs: vTPM spec #6802
Closed
docs: vTPM spec #6802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Darkbeldin
approved these changes
Apr 28, 2023
stormi
reviewed
Apr 28, 2023
julien-f
reviewed
May 10, 2023
docs/vtpm.md
Outdated
| - `is_protected`: The TPM is encrypted whenever it's transferred or at stored to disk (and exported) | ||
| - `is_unique`: The TPM contents are exclusive to that VM, that means it has never been cloned (and maybe never exported nor imported) | ||
|
|
||
| vTPM features are only enabled if XAPI is recent enough (check for version >= 8.3). |
There was a problem hiding this comment.
Alternative checks:
pool.restrictions.restrict_vtpm === 'false'
julien-f
reviewed
May 10, 2023
docs/vtpm.md
Outdated
| - The default value is `false`, except if `template.platform.vtpm` is `"true"`. | ||
| - A message will be displayed below the toggle if: | ||
| - The value is `true`: _Please note that once the vTPM is used, its deletion is strongly discouraged as it will lead to data loss._ | ||
| - The value is `false` and the `template.platform.vtpm` is `"true"`: _The VM cannot be created without vTPM_ |
There was a problem hiding this comment.
Suggested change
| - The value is `false` and the `template.platform.vtpm` is `"true"`: _The VM cannot be created without vTPM_ | |
| - The value is `false` and the `template.platform.vtpm` is `"true"`: _This template requires a vTPM, if you proceed, the VM will likely not be able to boot_ |
julien-f
reviewed
May 10, 2023
docs/vtpm.md
Outdated
| - A toggle will be displayed in advanced settings under `boot firmware`. | ||
| - The default value is `false`, except if `template.platform.vtpm` is `"true"`. | ||
| - A message will be displayed below the toggle if: | ||
| - The value is `true`: _Please note that once the vTPM is used, its deletion is strongly discouraged as it will lead to data loss._ |
There was a problem hiding this comment.
Not necessary, a warning confirmation modal at vTPM creation will be enough.
julien-f
reviewed
May 10, 2023
docs/vtpm.md
Outdated
| ```ts | ||
| vTPM Object | ||
| { | ||
| id: string, |
julien-f
reviewed
May 10, 2023
docs/vtpm.md
Outdated
Comment on lines
5
to
6
| is_protected: boolean, // Currently unused by the XAPI, may be used in future. | ||
| is_unique: boolean // Currently unused by the XAPI, may be used in future. |
This was referenced Oct 6, 2023
pdonias
pushed a commit
that referenced
this pull request
Oct 19, 2023
pdonias
pushed a commit
that referenced
this pull request
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Short explanation of this PR (feel free to re-use commit message)
Checklist
Fixes #007,See xoa-support#42,See https://...)Introduced byCHANGELOG.unreleased.md