Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(xo-server/xo-web/VM/new): VTPM creation #7077

Merged
merged 11 commits into from
Oct 19, 2023
Merged

feat(xo-server/xo-web/VM/new): VTPM creation #7077

merged 11 commits into from
Oct 19, 2023

Conversation

MathieuRA
Copy link
Member

@MathieuRA MathieuRA commented Oct 6, 2023 •
edited
Loading

Screenshot

Capture d’écran de 2023-10-06 15-31-33

Description

Can be tested on: 172.16.211.212

See #7066
Spec

Depend of this PR

This PR

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

@MathieuRA MathieuRA self-assigned this Oct 6, 2023
@MathieuRA MathieuRA marked this pull request as draft October 6, 2023 14:18
@MathieuRA MathieuRA force-pushed the xo5/vtpm-vm-creation branch from 69e667e to be255f1 Compare October 9, 2023 14:26
@MathieuRA MathieuRA requested a review from pdonias October 9, 2023 14:31
pdonias
pdonias requested changes Oct 9, 2023
View reviewed changes
CHANGELOG.unreleased.md Outdated Show resolved Hide resolved
packages/xo-web/src/common/intl/messages.js Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/new-vm/index.js Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/new-vm/index.js Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/new-vm/index.js Outdated Show resolved Hide resolved
@MathieuRA MathieuRA requested a review from pdonias October 11, 2023 08:06
Base automatically changed from xo5/vtmp to master October 12, 2023 07:19
@MathieuRA MathieuRA force-pushed the xo5/vtpm-vm-creation branch from 5d51966 to 5199b99 Compare October 12, 2023 07:24
@MathieuRA MathieuRA marked this pull request as ready for review October 12, 2023 07:46
julien-f
julien-f requested changes Oct 12, 2023
View reviewed changes
packages/xo-server/src/api/vm.mjs Outdated Show resolved Hide resolved
packages/xo-server/src/api/vm.mjs Outdated Show resolved Hide resolved
@MathieuRA MathieuRA requested review from MelissaFrncJrg and removed request for MelissaFrncJrg October 16, 2023 14:33
@MathieuRA MathieuRA requested a review from pdonias October 17, 2023 14:29
@pdonias pdonias requested a review from julien-f October 19, 2023 13:44
@julien-f
Copy link
Member

@pdonias Please resolve your comments.

@pdonias
Copy link
Member

pdonias commented Oct 19, 2023

Done.
@MathieuRA Please rebase :)

@MathieuRA MathieuRA force-pushed the xo5/vtpm-vm-creation branch from 8f05424 to a3b9a9a Compare October 19, 2023 14:38
@MathieuRA
Copy link
Member Author

@pdonias Done

@pdonias pdonias merged commit 8834af6 into master Oct 19, 2023
@pdonias pdonias deleted the xo5/vtpm-vm-creation branch October 19, 2023 14:48
@pdonias pdonias mentioned this pull request Oct 19, 2023
Closed
@MathieuRA MathieuRA mentioned this pull request Oct 31, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MelissaFrncJrg MelissaFrncJrg MelissaFrncJrg approved these changes

@pdonias pdonias pdonias approved these changes

@julien-f julien-f julien-f approved these changes

Assignees

@MathieuRA MathieuRA

Labels
Highlight
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MathieuRA @julien-f @pdonias @MelissaFrncJrg