Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(xapi/VTPM): ability to create, destroy VTPM #7074

Merged
merged 6 commits into from
Oct 12, 2023
Merged

feat(xapi/VTPM): ability to create, destroy VTPM #7074

merged 6 commits into from
Oct 12, 2023

Conversation

MathieuRA
Copy link
Member

Description

Can be tested on the pool: 172.16.211.212.

Short explanation of this PR (feel free to re-use commit message)

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

@MathieuRA MathieuRA requested a review from fbeauchamp October 4, 2023 15:35
@MathieuRA MathieuRA mentioned this pull request Oct 6, 2023
Merged
fbeauchamp
fbeauchamp reviewed Oct 9, 2023
View reviewed changes
packages/xo-server/src/api/vtpm.mjs Outdated Show resolved Hide resolved
@xen-orchestra/xapi/vtpm.mjs Outdated Show resolved Hide resolved
@MathieuRA MathieuRA self-assigned this Oct 9, 2023
@MathieuRA MathieuRA requested a review from fbeauchamp October 9, 2023 14:21
@MathieuRA MathieuRA requested review from julien-f and removed request for julien-f October 9, 2023 15:24
@MathieuRA MathieuRA mentioned this pull request Oct 10, 2023
Merged
@MathieuRA MathieuRA requested a review from julien-f October 11, 2023 12:58
julien-f
julien-f approved these changes Oct 11, 2023
View reviewed changes
Copy link
Member

@julien-f julien-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, you can rebase and merge.

@MathieuRA MathieuRA merged commit 2e634a9 into master Oct 12, 2023
@MathieuRA MathieuRA deleted the xo5/vtmp branch October 12, 2023 07:19
pdonias pushed a commit that referenced this pull request Oct 19, 2023
@MathieuRA
feat(xo-web/VM/advanced): VTPM management (#7085)
1a1dd05 
See #7066
See #6802
See #7074
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olivierlambert olivierlambert olivierlambert left review comments

@julien-f julien-f julien-f approved these changes

@fbeauchamp fbeauchamp fbeauchamp approved these changes

Assignees

@MathieuRA MathieuRA

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MathieuRA @fbeauchamp @julien-f @olivierlambert