Merge branch Feature/auto-vic-ui-plugin #1947
Conversation
Updates the vendored vmware/vic repo to version v1.4.0. Also adjusts dep configuration to prune unused packages. Progress to vmware#1433.
…mware#1799) Introduces caching of the vic-ui plugin artifacts as a component of the ova. Updates the fileserver provisioner to package vic-ui with the correct version numbers. Creates the Fileserver Thumbprint API to return the thumbprint of a given target ip address or fqdn. Also refactors the fileserver main process into main.go, and creates the routes/ and tasks/ sub-packages. Moves vic-ui plugin dependencies to fileserver. This includes: - vic/lib/install/ova - vic/lib/install/plugin - vic/tagvm/ Additionally, refactors ovatools/vic-ui/ui/ui.go to plugin.go that doesn't include any CLI flags. Automates the plugin install process and improves logging in the fileserver: - Add trace.Op logging to fileserver tasks - Require vcenter thumprint on psc registration - Install VIC UI plugins in the initialization process - Attaches a managed tag to the Appliance VM - Performs a plugin install during the appliance upgrade process using the /plugin API. Fixes vmware#1433, vmware#637, vmware#1720, vmware#1702 and vmware#1789.
Adds a new modal for thumbprint validation to the Getting Started Page in the Fileserver. Fixes vmware/vic-ui#465
* Refactor register tests to use thumbprint tmp * [BROKEN] Robot testing * Refacotr UI plugin registration test cases * Revert "Refacotr UI plugin registration test cases" This reverts commit c17d914. * Revert "Revert "Refacotr UI plugin registration test cases"" This reverts commit f63b61d. * fixup! Refacotr UI plugin registration test cases * fixup! Refacotr UI plugin registration test cases
|
In the vic-ui repo, we made some bug fixes to avoid issues with passwords that contained special characters (vmware/vic-ui#558). It looks like some of the affected files were removed from that repo and added to this one as a part of this automation work. We should see if any of the changes made to the old files in vic-ui are applicable to this PR. |
|
Same question as in the vic repo: why is this being merged from a fork branch? |
|
@zjs since ui/install.sh|upgrade.sh|uninstall.sh will be removed after ui registration automation, vmware/vic-ui#558 will not exist anymore. |
|
Move to the feature branch directly at #1979 |
We switch ui plugin registration from running manual commands of install.sh or upgrade.sh to automation. A set of rest apis are hosted on the VIC appliance fileserver. During the appliance initialization, index.html page will send a post request to the plugin install api, which will prepare the plugin and register the plugin to vCenter.
A thumbprint verification page is shown to enhance security, e.g. a wrong vCenter or a man-in-the-middle attack.
In case there is an old ui plugin in vCenter already, the new VIC appliance will overwrite the old ui plugin and register a new one.
UI plugin registration is also integrated into upgrade.sh, so the UI plugin can be upgraded as well when running upgrade.sh for VIC appliance upgrade.
With UI plugin auto registration, we do not need the manual ui install/upgrade.sh scripts and vic-ui-* commands anymore, which are removed by PR vmware/vic#8219
Towards: vmware/vic-product#1432