-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add did:itn method #556
Add did:itn method #556
Conversation
New DID Method review volunteers, please review this DID Method. /cc @apuchitnis @stenreijers @gatemezing @esaung @michallis @richardwinputra @adam-burns @Steffytan @MizukiSonoko @rajivrajani @genaris @harleyjackthomas @ajile-in @KDean-Dolphin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DID Method meets minimum requirements for registration.
Non-blocking feedback:
- The CRUD operations in the specification should detail exactly how each operation works.
@msporny I have updated the ITN DID Method Specification with the details of how each CRUD operation works. Any estimate of when the second reviewer will get assigned and review the PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DID Method meets minimum requirements for registration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok
Non-blocking feedback:
In DID-Method Format section, I think it would be easier to understand if there was Backus–Naur form or example
@MizukiSonoko thank you for reviewing and feedback. Added the Backus-Naur form of ITN DID. |
@MizukiSonoko @gatemezing @msporny thank you all for reviewing the PR. I appreciate your time and efforts. I want to know what else is pending on my end - I noticed 1 workflow awaiting approval from the maintainer. |
@msporny thank you. |
DID Method Registration
As a DID method registrant, I have ensured that my DID method registration complies with the following statements:
contactEmail
address [OPTIONAL].verifiableDataRegistry
entry [OPTIONAL].