Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test same-value-setting not changing selection for input/textarea #5147

Merged
merged 3 commits into from
Apr 17, 2017
Merged

Test same-value-setting not changing selection for input/textarea #5147

merged 3 commits into from
Apr 17, 2017

Conversation

domenic
Copy link
Member

@domenic domenic commented Mar 14, 2017 •
edited by gsnedders
Loading

Follows whatwg/html#2437.

This change is Reviewable

@wpt-pr-bot
Copy link
Collaborator

Notifying @ayg, @jdm, @jgraham, @zcorpan, and @zqzhang. (Learn how reviewing works.)

@ghost
Copy link

ghost commented Mar 14, 2017 •
edited by ghost
Loading

These tests are now available on w3c-test.org

@domenic domenic mentioned this pull request Mar 14, 2017
Merged
@ghost
Copy link

ghost commented Mar 14, 2017 •
edited by ghost
Loading

View the complete job log.

Firefox (nightly channel)

Testing web-platform-tests at revision 6b2d0a5
Using browser at version BuildID 20170314110401; SourceStamp 6d38ad302429c98115c354d643e81987ecec5d3c
Starting 10 test iterations
All results were stable

All results

1 test ran
/html/semantics/forms/textfieldselection/selection-after-content-change.html
Subtest Results Messages
OK
input out of document: selection must not change when setting the same value FAIL assert_equals: selectionStart must not change expected 1 but got 5
input out of document: selection must change when setting a different value FAIL assert_true: selectionDirection must be set to either none or forward expected true got false
input in document: selection must not change when setting the same value FAIL assert_equals: selectionStart must not change expected 1 but got 5
input in document: selection must change when setting a different value FAIL assert_true: selectionDirection must be set to either none or forward expected true got false
input in document, with focus: selection must not change when setting the same value PASS
input in document, with focus: selection must change when setting a different value PASS
textarea out of document: selection must not change when setting the same value FAIL assert_equals: selectionStart must not change expected 1 but got 5
textarea out of document: selection must change when setting a different value FAIL assert_true: selectionDirection must be set to either none or forward expected true got false
textarea in document: selection must not change when setting the same value PASS
textarea in document: selection must change when setting a different value PASS
textarea in document, with focus: selection must not change when setting the same value PASS
textarea in document, with focus: selection must change when setting a different value PASS
textarea in document: selection must not change when setting the same normalized value FAIL assert_equals: selectionStart must not change when setting to CRLF expected 1 but got 6

@ghost
Copy link

ghost commented Mar 14, 2017 •
edited by ghost
Loading

View the complete job log.

Chrome (unstable channel)

Testing web-platform-tests at revision 6b2d0a5
Using browser at version 58.0.3029.19 dev
Starting 10 test iterations
All results were stable

All results

1 test ran
/html/semantics/forms/textfieldselection/selection-after-content-change.html
Subtest Results Messages
OK
input out of document: selection must not change when setting the same value FAIL assert_equals: selectionStart must not change expected 1 but got 5
input out of document: selection must change when setting a different value PASS
input in document: selection must not change when setting the same value FAIL assert_equals: selectionStart must not change expected 1 but got 5
input in document: selection must change when setting a different value PASS
input in document, with focus: selection must not change when setting the same value FAIL assert_equals: selectionStart must not change expected 1 but got 5
input in document, with focus: selection must change when setting a different value PASS
textarea out of document: selection must not change when setting the same value PASS
textarea out of document: selection must change when setting a different value PASS
textarea in document: selection must not change when setting the same value PASS
textarea in document: selection must change when setting a different value PASS
textarea in document, with focus: selection must not change when setting the same value PASS
textarea in document, with focus: selection must change when setting a different value PASS
textarea in document: selection must not change when setting the same normalized value PASS

@domenic domenic mentioned this pull request Mar 14, 2017
Closed
domenic added 2 commits March 15, 2017 19:12
@domenic
A few fixes:
cc38208 
- Expand coverage to include .focus()
- Allow either "none" or "forward" selection direction
- Test normalization a bit more
@domenic
Ensure consistent reset direction
9ceefc9
@ghost
Copy link

ghost commented Mar 23, 2017

*This report has been truncated because the total content is 1612497 characters in length, which is in excess of GitHub.com's limit for comments (65536 characters).

View the complete job log.

Firefox (nightly channel)

Testing web-platform-tests at revision 79e4b2e
Using browser at version BuildID 20170322110306; SourceStamp 201231223cd4354a450c3e5d80959f35b8e4cf0c
Starting 10 test iterations
All results were stable

All results

112 tests ran
/2dcontext/pixel-manipulation/2d.imageData.create2.double.html
Subtest Results Messages
OK
createImageData(w, h) double is converted to long PASS
/2dcontext/pixel-manipulation/2d.imageData.create2.zero.html
Subtest Results Messages
OK
createImageData(sw, sh) throws INDEX_SIZE_ERR if size is zero FAIL assert_throws: function "function() { ctx.createImageData(0.99, 10); }" did not throw
/2dcontext/pixel-manipulation/2d.imageData.get.double.html
Subtest Results Messages
OK
createImageData(w, h) double is converted to long PASS
/2dcontext/pixel-manipulation/2d.imageData.get.zero.html
Subtest Results Messages
OK
getImageData() throws INDEX_SIZE_ERR if size is zero FAIL assert_throws: function "function() { ctx.getImageData(1, 1, 0.1, 10); }" did not throw
/FileAPI/historical.https.html
Subtest Results Messages
OK
"toNativeLineEndings" should not be supported PASS
"FileError" should not be supported PASS
"FileException" should not be supported PASS
Blob should not support slice prefixed PASS
BlobBuilder should not be supported. PASS
createFor method should not be supported PASS
Blob.close() should not be supported PASS
Service worker test setup PASS
"FileReaderSync" should not be supported in service workers FAIL assert_false: expected false got true
/IndexedDB/idbobjectstore_createIndex15-autoincrement.htm
Subtest Results Messages
OK
Explicit Primary Key FAIL event is not defined
Auto-Increment Primary Key FAIL event is not defined
/XMLHttpRequest/send-conditional-cors.htm
Subtest Results Messages
OK
304 without appropriate CORS header PASS
304 with appropriate CORS header PASS
/XMLHttpRequest/send-conditional.htm
Subtest Results Messages
OK
XMLHttpRequest: send() - conditional requests (tag) PASS
XMLHttpRequest: send() - conditional requests (date) PASS
/content-security-policy/connect-src/connect-src-beacon-blocked.sub.html
Subtest Results Messages
OK
sendBeacon should not throw. FAIL assert_true: expected true got false
/content-security-policy/connect-src/connect-src-eventsource-blocked.sub.html
Subtest Results Messages
TIMEOUT
/content-security-policy/connect-src/connect-src-websocket-blocked.sub.html
Subtest Results Messages
OK
WebSocket should fire error event. FAIL
/content-security-policy/connect-src/connect-src-xmlhttprequest-blocked.sub.html
Subtest Results Messages
TIMEOUT
XHR should fire onerror. TIMEOUT Test timed out
XHR should fire onerror after a redirect. TIMEOUT Test timed out
/content-security-policy/inside-worker/dedicated-inheritance.html
Subtest Results Messages
ERROR
Filesystem and blob. PASS
Same-origin 'fetch()' in blob: PASS {}
`Same-origin 'fetch()' in http:?pipe=sub header(Content-Security-Policy,default-src%20*)` PASS
`Same-origin 'fetch()' in http:?pipe=sub header(Content-Security-Policy,connect-src%20*)` PASS
Same-origin XHR in blob: PASS {}
`Same-origin XHR in http:?pipe=sub header(Content-Security-Policy,default-src%20*)` PASS
Cross-origin 'fetch()' in blob: PASS {}
`Same-origin XHR in http:?pipe=sub header(Content-Security-Policy,connect-src%20*)` PASS
`Same-origin 'fetch()' in http:?pipe=sub header(Content-Security-Policy,connect-src%20%27none%27)` TIMEOUT
`Cross-origin 'fetch()' in http:?pipe=sub header(Content-Security-Policy,default-src%20*)` PASS
`Cross-origin 'fetch()' in http:?pipe=sub header(Content-Security-Policy,connect-src%20*)` PASS
Cross-origin XHR in blob: PASS {}
`Same-origin XHR in http:?pipe=sub header(Content-Security-Policy,connect-src%20%27none%27)` FAIL
Same-origin 'fetch()' in http: PASS {}
`Cross-origin XHR in http:?pipe=sub header(Content-Security-Policy,default-src%20*)` PASS
`Cross-origin XHR in http:?pipe=sub header(Content-Security-Policy,connect-src%20*)` PASS
Same-origin => cross-origin 'fetch()' in blob: PASS {}
`Cross-origin 'fetch()' in http:?pipe=sub header(Content-Security-Policy,connect-src%20%27none%27)` PASS
`Same-origin => cross-origin 'fetch()' in http:?pipe=sub header(Content-Security-Policy,default-src%20*)` PASS
`Same-origin => cross-origin 'fetch()' in http:?pipe=sub header(Content-Security-Policy,connect-src%20*)` PASS
Same-origin XHR in http: PASS {}
`Cross-origin XHR in http:?pipe=sub header(Content-Security-Policy,connect-src%20%27none%27)` PASS
Cross-origin 'fetch()' in http: PASS {}
`Same-origin => cross-origin 'fetch()' in http:?pipe=sub header(Content-Security-Policy,connect-src%20%27none%27)` PASS
Cross-origin XHR in http: PASS {}
Same-origin => cross-origin 'fetch()' in http: PASS {}
/content-security-policy/inside-worker/dedicated-script.html
Subtest Results Messages
ERROR
Filesystem and blob. PASS
Cross-origin importScripts() blocked in http: FAIL assert_throws: importScripts should throw NetworkError function "_ => importScripts("http://www.web-platform.test:8001/content-security-policy/support/var-a.js")" did not throw
`Cross-origin importScripts() blocked in http:?pipe=sub header(Content-Security-Policy,default-src%20*)` FAIL
Cross-origin importScripts() blocked in blob: PASS {}
`Cross-origin importScripts() blocked in http:?pipe=sub header(Content-Security-Policy,script-src%20*)` FAIL
eval() blocked in http: FAIL assert_throws: eval() should throw 'EvalError'. function "_ => eval("1 + 1")" did not throw
eval() blocked in blob: FAIL assert_throws: eval() should throw 'EvalError'. function "_ => eval("1 + 1")" threw object "Error: call to eval() blocked by CSP" ("Error") expected object "EvalError" ("EvalError")
setTimeout([string]) blocked in http: FAIL assert_equals: expected 0 but got 1
setTimeout([string]) blocked in blob: FAIL assert_equals: expected 0 but got 1
`eval() blocked in http:?pipe=sub header(Content-Security-Policy,default-src%20*)` FAIL
`eval() blocked in http:?pipe=sub header(Content-Security-Policy,script-src%20*)` FAIL
`setTimeout([string]) blocked in http:?pipe=sub header(Content-Security-Policy,default-src%20*)` FAIL
`setTimeout([string]) blocked in http:?pipe=sub header(Content-Security-Policy,script-src%20*)` FAIL
/content-security-policy/inside-worker/shared-inheritance.html
Subtest Results Messages
OK
`Same-origin 'fetch()' in http:?pipe=sub header(Content-Security-Policy,default-src%20%27self%27)` PASS
`Same-origin XHR in http:?pipe=sub header(Content-Security-Policy,default-src%20%27self%27)` PASS
`Cross-origin 'fetch()' in http:?pipe=sub header(Content-Security-Policy,default-src%20%27self%27)` PASS
`Cross-origin XHR in http:?pipe=sub header(Content-Security-Policy,default-src%20%27self%27)` PASS
`Same-origin => cross-origin 'fetch()' in http:?pipe=sub header(Content-Security-Policy,default-src%20%27self%27)` PASS
`Same-origin 'fetch()' in http:?pipe=sub header(Content-Security-Policy,connect-src%20%27self%27)` PASS
`Same-origin XHR in http:?pipe=sub header(Content-Security-Policy,connect-src%20%27self%27)` PASS
`Cross-origin 'fetch()' in http:?pipe=sub header(Content-Security-Policy,connect-src%20%27self%27)` PASS
`Cross-origin XHR in http:?pipe=sub header(Content-Security-Policy,connect-src%20%27self%27)` PASS
`Same-origin => cross-origin 'fetch()' in http:?pipe=sub header(Content-Security-Policy,connect-src%20%27self%27)` PASS
Same-origin 'fetch()' in http: PASS {}
Same-origin XHR in http: PASS {}
Cross-origin 'fetch()' in http: PASS {}
Cross-origin XHR in http: PASS {}
Same-origin => cross-origin 'fetch()' in http: PASS {}
/content-security-policy/inside-worker/shared-script.html
Subtest Results Messages
OK
`Cross-origin importScripts() blocked in http:?pipe=sub header(Content-Security-Policy,script-src%20%27self%27` PASS
`eval() blocked in http:?pipe=sub header(Content-Security-Policy,script-src%20%27self%27` FAIL
`setTimeout([string]) blocked in http:?pipe=sub header(Content-Security-Policy,script-src%20%27self%27` FAIL
`Cross-origin importScripts() blocked in http:?pipe=sub header(Content-Security-Policy,default-src%20%27self%27` PASS
`eval() blocked in http:?pipe=sub header(Content-Security-Policy,default-src%20%27self%27` FAIL
`setTimeout([string]) blocked in http:?pipe=sub header(Content-Security-Policy,default-src%20%27self%27` FAIL
Cross-origin importScripts() not blocked in http: PASS {}
eval() not blocked in http: PASS {}
setTimeout([string]) not blocked in http: PASS {}
/content-security-policy/securitypolicyviolation/securitypolicyviolation-block-cross-origin-image-from-script.sub.html
Subtest Results Messages
TIMEOUT
Non-redirected cross-origin URLs are not stripped. TIMEOUT Test timed out
/content-security-policy/securitypolicyviolation/securitypolicyviolation-block-cross-origin-image.sub.html
Subtest Results Messages
TIMEOUT
Non-redirected cross-origin URLs are not stripped. TIMEOUT Test timed out
/content-security-policy/securitypolicyviolation/securitypolicyviolation-block-image-from-script.sub.html
Subtest Results Messages
TIMEOUT
Non-redirected cross-origin URLs are not stripped. TIMEOUT Test timed out
/content-security-policy/securitypolicyviolation/securitypolicyviolation-block-image.sub.html
Subtest Results Messages
TIMEOUT
Non-redirected same-origin URLs are not stripped. TIMEOUT Test timed out
/content-security-policy/worker-src/dedicated-child.sub.html
Subtest Results Messages
OK
Same-origin dedicated worker allowed by host-source expression. PASS
blob: dedicated worker allowed by 'blob:'. PASS
/content-security-policy/worker-src/dedicated-fallback.sub.html
Subtest Results Messages
OK
Same-origin dedicated worker allowed by host-source expression. FAIL assert_unreached: The 'error' event should not have fired. Reached unreachable code
blob: dedicated worker allowed by 'blob:'. FAIL assert_unreached: The 'error' event should not have fired. Reached unreachable code
/content-security-policy/worker-src/dedicated-list.sub.html
Subtest Results Messages
OK
Same-origin dedicated worker allowed by host-source expression. PASS
blob: dedicated worker allowed by 'blob:'. PASS
/content-security-policy/worker-src/dedicated-none.sub.html
Subtest Results Messages
OK
Same-origin dedicated worker blocked by host-source expression. FAIL assert_throws: function "function () {\n var w = new Worker(url);\n }" did not throw
blob: dedicated worker blocked by 'blob:'. FAIL assert_throws: function "function () {\n var w = new Worker(url);\n }" did not throw
/content-security-policy/worker-src/dedicated-self.sub.html
Subtest Results Messages
OK
Same-origin dedicated worker allowed by 'self'. PASS
/content-security-policy/worker-src/service-child.https.sub.html
Subtest Results Messages
OK
Same-origin service worker allowed by host-source expression. PASS
/content-security-policy/worker-src/service-fallback.https.sub.html
Subtest Results Messages
OK
Same-origin service worker allowed by host-source expression. FAIL promise_test: Unhandled rejection with value: object "[Exception... "<no message>" nsresult: "0x805e0006 (<unknown>)" location: "JS frame :: https://web-platform.test:8443/content-security-policy/support/testharness-helper.js :: assert_service_worker_is_loaded/< :: line 73" data: no]"
/content-security-policy/worker-src/service-list.https.sub.html
Subtest Results Messages
OK
Same-origin service worker allowed by host-source expression. PASS
/content-security-policy/worker-src/service-none.https.sub.html
Subtest Results Messages
OK
Same-origin service worker blocked by 'none'. FAIL assert_unreached: Should have rejected: undefined Reached unreachable code
/content-security-policy/worker-src/service-self.https.sub.html
Subtest Results Messages
OK
Same-origin service worker allowed by 'self'. PASS
/content-security-policy/worker-src/shared-child.sub.html
Subtest Results Messages
OK
Same-origin dedicated worker allowed by 'self'. PASS
blob: dedicated worker allowed by 'blob:'. PASS
/content-security-policy/worker-src/shared-fallback.sub.html
Subtest Results Messages
OK
Same-origin dedicated worker allowed by 'self'. FAIL assert_unreached: The 'error' event should not have fired. Reached unreachable code
blob: dedicated worker allowed by 'blob:'. FAIL assert_unreached: The 'error' event should not have fired. Reached unreachable code
/content-security-policy/worker-src/shared-list.sub.html
Subtest Results Messages
OK
Same-origin dedicated worker allowed by 'self'. PASS
blob: dedicated worker allowed by 'blob:'. PASS
/content-security-policy/worker-src/shared-none.sub.html
Subtest Results Messages
OK
Same-origin shared worker blocked by 'none'. FAIL assert_throws: function "function () {\n var w = new SharedWorker(url);\n }" did not throw
blob: shared worker blocked by 'none'. FAIL assert_throws: function "function () {\n var w = new SharedWorker(url);\n }" did not throw
/content-security-policy/worker-src/shared-self.sub.html
Subtest Results Messages
OK
Same-origin dedicated worker allowed by 'self'. PASS
/cors/preflight-failure.htm
Subtest Results Messages
TIMEOUT
Should throw error if preflight respond with 100 TIMEOUT Test timed out
Should throw error if preflight respond with 101 PASS
Should throw error if preflight respond with 200 PASS
Should throw error if preflight respond with 300 PASS
Should throw error if preflight respond with 301 PASS
Should throw error if preflight respond with 302 PASS
Should throw error if preflight respond with 303 PASS
Should throw error if preflight respond with 304 PASS
Should throw error if preflight respond with 305 PASS
Should throw error if preflight respond with 306 PASS
Should throw error if preflight respond with 307 PASS
Should throw error if preflight respond with 308 PASS
Should throw error if preflight respond with 400 PASS
Should throw error if preflight respond with 401 PASS
Should throw error if preflight respond with 402 PASS
Should throw error if preflight respond with 403 PASS
Should throw error if preflight respond with 404 PASS
Should throw error if preflight respond with 405 PASS
Should throw error if preflight respond with 406 PASS
Should throw error if preflight respond with 407 PASS
Should throw error if preflight respond with 408 PASS
Should throw error if preflight respond with 409 PASS
Should throw error if preflight respond with 410 PASS
Should throw error if preflight respond with 411 PASS
Should throw error if preflight respond with 412 PASS
Should throw error if preflight respond with 413 PASS
Should throw error if preflight respond with 414 PASS
Should throw error if preflight respond with 415 PASS
Should throw error if preflight respond with 416 PASS
Should throw error if preflight respond with 417 PASS
Should throw error if preflight respond with 500 PASS
Should throw error if preflight respond with 501 PASS
Should throw error if preflight respond with 502 PASS
Should throw error if preflight respond with 503 PASS
Should throw error if preflight respond with 504 PASS
Should throw error if preflight respond with 505 PASS
/dom/events/EventTarget-dispatchEvent.html
Subtest Results Messages
OK
Calling dispatchEvent(null). PASS
If the event's initialized flag is not set, an InvalidStateError must be thrown (AnimationEvent). FAIL Operation is not supported
If the event's initialized flag is not set, an InvalidStateError must be thrown (BeforeUnloadEvent). PASS
If the event's initialized flag is not set, an InvalidStateError must be thrown (CloseEvent). FAIL Operation is not supported
If the event's initialized flag is not set, an InvalidStateError must be thrown (CompositionEvent). PASS
If the event's initialized flag is not set, an InvalidStateError must be thrown (CustomEvent). PASS
If the event's initialized flag is not set, an InvalidStateError must be thrown (DeviceMotionEvent). PASS
If the event's initialized flag is not set, an InvalidStateError must be thrown (DeviceOrientationEvent). PASS
If the event's initialized flag is not set, an InvalidStateError must be thrown (DragEvent). PASS
If the event's initialized flag is not set, an InvalidStateError must be thrown (ErrorEvent). PASS
If the event's initialized flag is not set, an InvalidStateError must be thrown (Event). PASS
If the event's initialized flag is not set, an InvalidStateError must be thrown (Events). PASS
If the event's initialized flag is not set, an InvalidStateError must be thrown (FocusEvent). FAIL Operation is not supported
If the event's initialized flag is not set, an InvalidStateError must be thrown (HashChangeEvent). PASS
If the event's initialized flag is not set, an InvalidStateError must be thrown (HTMLEvents). PASS
If the event's initialized flag is not set, an InvalidStateError must be thrown (IDBVersionChangeEvent). FAIL Operation is not supported
If the event's initialized flag is not set, an InvalidStateError must be thrown (KeyboardEvent). PASS
If the event's initialized flag is not set, an InvalidStateError must be thrown (MessageEvent). PASS
If the event's initialized flag is not set, an InvalidStateError must be thrown (MouseEvent). PASS
If the event's initialized flag is not set, an InvalidStateError must be thrown (MouseEvents). PASS
If the event's initialized flag is not set, an InvalidStateError must be thrown (PageTransitionEvent). FAIL Operation is not supported
If the event's initialized flag is not set, an InvalidStateError must be thrown (PopStateEvent). PASS
If the event's initialized flag is not set, an InvalidStateError must be thrown (StorageEvent). PASS
If the event's initialized flag is not set, an InvalidStateError must be thrown (SVGEvents). PASS
If the event's initialized flag is not set, an InvalidStateError must be thrown (TextEvent). PASS
If the event's initialized flag is not set, an InvalidStateError must be thrown (TouchEvent). PASS
If the event's initialized flag is not set, an InvalidStateError must be thrown (TrackEvent). FAIL Operation is not supported
If the event's initialized flag is not set, an InvalidStateError must be thrown (TransitionEvent). FAIL Operation is not supported
If the event's initialized flag is not set, an InvalidStateError must be thrown (UIEvent). PASS
If the event's initialized flag is not set, an InvalidStateError must be thrown (UIEvents). PASS
If the event's initialized flag is not set, an InvalidStateError must be thrown (WebGLContextEvent). FAIL Operation is not supported
If the event's initialized flag is not set, an InvalidStateError must be thrown (WheelEvent). FAIL Operation is not supported
If the event's dispatch flag is set, an InvalidStateError must be thrown. PASS
Exceptions from event listeners must not be propagated. PASS
Event listeners added during dispatch should be called PASS
Event listeners should be called in order of addition PASS
/dom/nodes/Document-createEvent.html
Subtest Results Messages
OK
AnimationEvent should be an alias for AnimationEvent. FAIL Operation is not supported
createEvent('AnimationEvent') should be initialized correctly. FAIL ev is undefined
animationevent should be an alias for AnimationEvent. FAIL Operation is not supported
createEvent('animationevent') should be initialized correctly. FAIL ev is undefined
ANIMATIONEVENT should be an alias for AnimationEvent. FAIL Operation is not supported
createEvent('ANIMATIONEVENT') should be initialized correctly. FAIL ev is undefined
Should throw NOT_SUPPORTED_ERR for pluralized legacy event interface "AnimationEvents" PASS
BeforeUnloadEvent should be an alias for BeforeUnloadEvent. PASS
createEvent('BeforeUnloadEvent') should be initialized correctly. PASS
beforeunloadevent should be an alias for BeforeUnloadEvent. PASS
createEvent('beforeunloadevent') should be initialized correctly. PASS
BEFOREUNLOADEVENT should be an alias for BeforeUnloadEvent. PASS
createEvent('BEFOREUNLOADEVENT') should be initialized correctly. PASS
Should throw NOT_SUPPORTED_ERR for pluralized legacy event interface "BeforeUnloadEvents" PASS
CloseEvent should be an alias for CloseEvent. FAIL Operation is not supported
createEvent('CloseEvent') should be initialized correctly. FAIL ev is undefined
closeevent should be an alias for CloseEvent. FAIL Operation is not supported
createEvent('closeevent') should be initialized correctly. FAIL ev is undefined
CLOSEEVENT should be an alias for CloseEvent. FAIL Operation is not supported
createEvent('CLOSEEVENT') should be initialized correctly. FAIL ev is undefined
Should throw NOT_SUPPORTED_ERR for pluralized legacy event interface "CloseEvents" PASS
CompositionEvent should be an alias for CompositionEvent. PASS
createEvent('CompositionEvent') should be initialized correctly. PASS
compositionevent should be an alias for CompositionEvent. PASS
createEvent('compositionevent') should be initialized correctly. PASS
COMPOSITIONEVENT should be an alias for CompositionEvent. PASS
createEvent('COMPOSITIONEVENT') should be initialized correctly. PASS
Should throw NOT_SUPPORTED_ERR for pluralized legacy event interface "CompositionEvents" PASS
CustomEvent should be an alias for CustomEvent. PASS
createEvent('CustomEvent') should be initialized correctly. PASS
customevent should be an alias for CustomEvent. PASS
createEvent('customevent') should be initialized correctly. PASS
CUSTOMEVENT should be an alias for CustomEvent. PASS
createEvent('CUSTOMEVENT') should be initialized correctly. PASS
Should throw NOT_SUPPORTED_ERR for pluralized legacy event interface "CustomEvents" PASS
DeviceMotionEvent should be an alias for DeviceMotionEvent. PASS
createEvent('DeviceMotionEvent') should be initialized correctly. PASS
devicemotionevent should be an alias for DeviceMotionEvent. PASS
createEvent('devicemotionevent') should be initialized correctly. PASS
DEVICEMOTIONEVENT should be an alias for DeviceMotionEvent. PASS
createEvent('DEVICEMOTIONEVENT') should be initialized correctly. PASS
Should throw NOT_SUPPORTED_ERR for pluralized legacy event interface "DeviceMotionEvents" PASS
DeviceOrientationEvent should be an alias for DeviceOrientationEvent. PASS
createEvent('DeviceOrientationEvent') should be initialized correctly. PASS
deviceorientationevent should be an alias for DeviceOrientationEvent. PASS
createEvent('deviceorientationevent') should be initialized correctly. PASS
DEVICEORIENTATIONEVENT should be an alias for DeviceOrientationEvent. PASS
createEvent('DEVICEORIENTATIONEVENT') should be initialized correctly. PASS
Should throw NOT_SUPPORTED_ERR for pluralized legacy event interface "DeviceOrientationEvents" PASS
DragEvent should be an alias for DragEvent. PASS
createEvent('DragEvent') should be initialized correctly. PASS
dragevent should be an alias for DragEvent. PASS
createEvent('dragevent') should be initialized correctly. PASS
DRAGEVENT should be an alias for DragEvent. PASS
createEvent('DRAGEVENT') should be initialized correctly. PASS
Should throw NOT_SUPPORTED_ERR for pluralized legacy event interface "DragEvents" FAIL assert_throws: function "function () {\n var evt = document.createEvent(plural);\n }" did not throw
ErrorEvent should be an alias for ErrorEvent. PASS
createEvent('ErrorEvent') should be initialized correctly.

@ghost
Copy link

ghost commented Mar 23, 2017

View the complete job log.

Chrome (unstable channel)

Testing web-platform-tests at revision 79e4b2e
Using browser at version 59.0.3047.0 dev
Starting 10 test iterations

@tkent-google
Copy link
Contributor

lgtm

@domenic domenic merged commit 9c585b4 into master Apr 17, 2017
@domenic domenic deleted the text-selection-same-value branch April 17, 2017 21:43
@bzbarsky
Copy link
Contributor

bzbarsky commented Apr 18, 2017 •
edited
Loading

@domenic it doesn't look like there are any tests here exercising the situation when https://html.spec.whatwg.org/multipage/forms.html#value-sanitization-algorithm modifies the value, right? It's not quite obvious to me whether "new value" as used in the setter of the "value" mode at https://html.spec.whatwg.org/multipage/forms.html#dom-input-value in step 5 means the string that was passed to the setter or the string after application of the value sanitization algorithm, and the lack of tests makes it likely UAs would end up with differing interpretations there. Ideally we would both test the behavior and define it more clearly in the spec.

domenic added a commit to whatwg/html that referenced this pull request Apr 19, 2017
@domenic
Clarify the value comparison in input.value's setter
fdcb786 
This is a follow-up to #2437, which introduced the value comparison and
its impact on selection. See
web-platform-tests/wpt#5147 (comment).
@domenic domenic mentioned this pull request Apr 19, 2017
Merged
domenic added a commit that referenced this pull request Apr 19, 2017
@domenic
Expand coverage on value-changing/selection-changing tests
ad72aa0 
This is a follow-up to #5147. It tests the clarification at whatwg/html#2560. While there, it also adds additional textarea test cases for line-ending normalization; previously the test only tested an in-document textarea.
@domenic domenic mentioned this pull request Apr 19, 2017
Merged
domenic added a commit to whatwg/html that referenced this pull request Apr 20, 2017
@domenic
Clarify the value comparison in input.value's setter
8ee1ea4 
This is a follow-up to #2437, which introduced the value comparison and
its impact on selection. See
web-platform-tests/wpt#5147 (comment).
domenic added a commit that referenced this pull request Apr 25, 2017
@domenic
Expand coverage on value-changing/selection-changing tests
91bdf59 
This is a follow-up to #5147. It tests the clarification at whatwg/html#2560. While there, it also adds additional textarea test cases for line-ending normalization; previously the test only tested an in-document textarea.
inikulin pushed a commit to HTMLParseErrorWG/html that referenced this pull request May 9, 2017
@domenic @inikulin
Clarify the value comparison in input.value's setter
e761179 
This is a follow-up to whatwg#2437, which introduced the value comparison and
its impact on selection. See
web-platform-tests/wpt#5147 (comment).
inikulin pushed a commit to HTMLParseErrorWG/html that referenced this pull request May 9, 2017
@domenic @inikulin
Clarify the value comparison in input.value's setter
e3fb955 
This is a follow-up to whatwg#2437, which introduced the value comparison and
its impact on selection. See
web-platform-tests/wpt#5147 (comment).
alice pushed a commit to alice/html that referenced this pull request Jan 8, 2019
@domenic
Clarify the value comparison in input.value's setter
d704c52 
This is a follow-up to whatwg#2437, which introduced the value comparison and
its impact on selection. See
web-platform-tests/wpt#5147 (comment).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Foxyroxy1 Foxyroxy1 Foxyroxy1 approved these changes

Assignees
No one assigned
Labels
html
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@domenic @wpt-pr-bot @tkent-google @bzbarsky @Foxyroxy1