Expand coverage on value-changing/selection-changing tests #5610

domenic · 2017-04-19T22:12:57Z

This is a follow-up to #5147. It tests the clarification at whatwg/html#2560. While there, it also adds additional textarea test cases for line-ending normalization; previously the test only tested an in-document textarea.

@bzbarsky to review

This change is

This is a follow-up to #5147. It tests the clarification at whatwg/html#2560. While there, it also adds additional textarea test cases for line-ending normalization; previously the test only tested an in-document textarea.

wpt-pr-bot · 2017-04-19T22:13:17Z

Notifying @ayg. (Learn how reviewing works.)

ghost · 2017-04-19T22:29:00Z

View the complete job log.

Lint

Passed

ghost · 2017-04-19T22:29:01Z

View the complete job log.

Firefox (nightly channel)

Testing web-platform-tests at revision f1edca9
Using browser at version BuildID 20170420100256; SourceStamp 27311156637f9b5d4504373967e01c4241902ae7
Starting 10 test iterations
All results were stable

All results

1 test ran

/html/semantics/forms/textfieldselection/selection-after-content-change.html

Subtest	Results	Messages
	OK
`input out of document: selection must not change when setting the same value`	FAIL	`assert_equals: selectionStart must not change expected 1 but got 5`
`input out of document: selection must change when setting a different value`	FAIL	`assert_true: selectionDirection must be set to either none or forward expected true got false`
`input out of document: selection must not change when setting a value that becomes the same after the value sanitization algorithm`	FAIL	`assert_equals: selectionStart must not change expected 1 but got 5`
`input in document: selection must not change when setting the same value`	FAIL	`assert_equals: selectionStart must not change expected 1 but got 5`
`input in document: selection must change when setting a different value`	FAIL	`assert_true: selectionDirection must be set to either none or forward expected true got false`
`input in document: selection must not change when setting a value that becomes the same after the value sanitization algorithm`	FAIL	`assert_equals: selectionStart must not change expected 1 but got 5`
`input in document, with focus: selection must not change when setting the same value`	PASS
`input in document, with focus: selection must change when setting a different value`	PASS
`input in document, with focus: selection must not change when setting a value that becomes the same after the value sanitization algorithm`	PASS
`textarea out of document: selection must not change when setting the same value`	FAIL	`assert_equals: selectionStart must not change expected 1 but got 5`
`textarea out of document: selection must change when setting a different value`	FAIL	`assert_equals: selectionDirection must be reset to forward (which was previously observed to be the value after resetting the selection direction) expected "forward" but got "backward"`
`textarea out of document: selection must not change when setting the same normalized value`	FAIL	`assert_equals: selectionStart must not change when setting to CRLF expected 1 but got 6`
`textarea in document: selection must not change when setting the same value`	PASS
`textarea in document: selection must change when setting a different value`	PASS
`textarea in document: selection must not change when setting the same normalized value`	FAIL	`assert_equals: selectionStart must not change when setting to CRLF expected 1 but got 6`
`textarea in document, with focus: selection must not change when setting the same value`	PASS
`textarea in document, with focus: selection must change when setting a different value`	PASS
`textarea in document, with focus: selection must not change when setting the same normalized value`	FAIL	`assert_equals: selectionStart must not change when setting to CRLF expected 1 but got 6`

ghost · 2017-04-19T22:29:01Z

View the complete job log.

Chrome (unstable channel)

Testing web-platform-tests at revision f1edca9
Using browser at version 59.0.3071.9 dev
Starting 10 test iterations
All results were stable

All results

1 test ran

/html/semantics/forms/textfieldselection/selection-after-content-change.html

Subtest	Results	Messages
	OK
`input out of document: selection must not change when setting the same value`	FAIL	`assert_equals: selectionStart must not change expected 1 but got 5`
`input out of document: selection must change when setting a different value`	PASS
`input out of document: selection must not change when setting a value that becomes the same after the value sanitization algorithm`	FAIL	`assert_equals: selectionStart must not change expected 1 but got 5`
`input in document: selection must not change when setting the same value`	FAIL	`assert_equals: selectionStart must not change expected 1 but got 5`
`input in document: selection must change when setting a different value`	PASS
`input in document: selection must not change when setting a value that becomes the same after the value sanitization algorithm`	FAIL	`assert_equals: selectionStart must not change expected 1 but got 5`
`input in document, with focus: selection must not change when setting the same value`	FAIL	`assert_equals: selectionStart must not change expected 1 but got 5`
`input in document, with focus: selection must change when setting a different value`	PASS
`input in document, with focus: selection must not change when setting a value that becomes the same after the value sanitization algorithm`	FAIL	`assert_equals: selectionStart must not change expected 1 but got 5`
`textarea out of document: selection must not change when setting the same value`	PASS
`textarea out of document: selection must change when setting a different value`	PASS
`textarea out of document: selection must not change when setting the same normalized value`	PASS
`textarea in document: selection must not change when setting the same value`	PASS
`textarea in document: selection must change when setting a different value`	PASS
`textarea in document: selection must not change when setting the same normalized value`	PASS
`textarea in document, with focus: selection must not change when setting the same value`	PASS
`textarea in document, with focus: selection must change when setting a different value`	PASS
`textarea in document, with focus: selection must not change when setting the same normalized value`	PASS

codecov-io · 2017-04-19T22:29:23Z

Codecov Report

Merging #5610 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #5610   +/-   ##
=======================================
  Coverage   87.22%   87.22%           
=======================================
  Files          24       24           
  Lines        2418     2418           
  Branches      406      406           
=======================================
  Hits         2109     2109           
  Misses        239      239           
  Partials       70       70

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9894f6d...5567ae7. Read the comment docs.

bzbarsky · 2017-04-20T05:27:28Z

html/semantics/forms/textfieldselection/selection-after-content-change.html

+function runInputTest(descriptor, elementFactory) {
+  runTest(descriptor, elementFactory);
+
+  test(() => {


This test fails, because in the "input in document" case elementFactory just keeps returning the same node without doing anything to its value. runTest will set the value to "hello", then to "hello2". Then this test will run and set it to a value that sanitizes to "hello", which is not the same as "hello2", so the cursor will get moved.

Presumably the "input in document" case needs to reset value just like the "input in document, with focus" case does.

Thanks, fixed!

domenic · 2017-04-24T20:52:06Z

@bzbarsky ping

bzbarsky · 2017-04-25T14:47:56Z

Sorry, didn't realize you were waiting on me. Looks good to me.

Expand coverage on value-changing/selection-changing tests

ad72aa0

This is a follow-up to #5147. It tests the clarification at whatwg/html#2560. While there, it also adds additional textarea test cases for line-ending normalization; previously the test only tested an in-document textarea.

domenic mentioned this pull request Apr 19, 2017

Clarify the value comparison in input.value's setter whatwg/html#2560

Merged

wpt-pr-bot added the html label Apr 19, 2017

bzbarsky reviewed Apr 20, 2017

View reviewed changes

annevk mentioned this pull request Apr 20, 2017

"Reviewable" is annoying and prevents seeing if something is successful or not #5590

Closed

Fix per review

5567ae7

domenic merged commit 91bdf59 into master Apr 25, 2017

domenic deleted the value-sanitization-selection branch April 25, 2017 15:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Expand coverage on value-changing/selection-changing tests #5610

Expand coverage on value-changing/selection-changing tests #5610

domenic commented Apr 19, 2017 •

edited by wpt-reviewable-bot

Loading

wpt-pr-bot commented Apr 19, 2017

ghost commented Apr 19, 2017 •

edited by ghost

Loading

ghost commented Apr 19, 2017 •

edited by ghost

Loading

ghost commented Apr 19, 2017 •

edited by ghost

Loading

codecov-io commented Apr 19, 2017 •

edited

Loading

bzbarsky Apr 20, 2017 •

edited

Loading

domenic Apr 20, 2017

domenic commented Apr 24, 2017

bzbarsky commented Apr 25, 2017

Expand coverage on value-changing/selection-changing tests #5610

Expand coverage on value-changing/selection-changing tests #5610

Conversation

domenic commented Apr 19, 2017 • edited by wpt-reviewable-bot Loading

wpt-pr-bot commented Apr 19, 2017

ghost commented Apr 19, 2017 • edited by ghost Loading

Lint

ghost commented Apr 19, 2017 • edited by ghost Loading

Firefox (nightly channel)

All results

ghost commented Apr 19, 2017 • edited by ghost Loading

Chrome (unstable channel)

All results

codecov-io commented Apr 19, 2017 • edited Loading

Codecov Report

bzbarsky Apr 20, 2017 • edited Loading

Choose a reason for hiding this comment

domenic Apr 20, 2017

Choose a reason for hiding this comment

domenic commented Apr 24, 2017

bzbarsky commented Apr 25, 2017

domenic commented Apr 19, 2017 •

edited by wpt-reviewable-bot

Loading

ghost commented Apr 19, 2017 •

edited by ghost

Loading

ghost commented Apr 19, 2017 •

edited by ghost

Loading

ghost commented Apr 19, 2017 •

edited by ghost

Loading

codecov-io commented Apr 19, 2017 •

edited

Loading

bzbarsky Apr 20, 2017 •

edited

Loading