Clarify the value comparison in input.value's setter #2560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a follow-up to #2437, which introduced the value comparison and its impact on selection. See web-platform-tests/wpt#5147 (comment).
domenic
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Apr 19, 2017
This is a follow-up to #5147. It tests the clarification at whatwg/html#2560. While there, it also adds additional textarea test cases for line-ending normalization; previously the test only tested an in-document textarea.
|
Looks good to me, thank you! |
domenic
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Apr 25, 2017
This is a follow-up to #5147. It tests the clarification at whatwg/html#2560. While there, it also adds additional textarea test cases for line-ending normalization; previously the test only tested an in-document textarea.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #2437, which introduced the value comparison and
its impact on selection. See
web-platform-tests/wpt#5147 (comment).
@bzbarsky to review.
Tests: web-platform-tests/wpt#5610