feat(federation): offline backends handling (epic) #1524

yamilmedina · 2023-03-02T12:22:02Z

AR-3122 [Android] Implement UI for sending messages when a remote backend is offline

REOPENING FOR TRACK -ALREADY APPROVED PR- WILL MERGE LATER. #1501

PR Submission Checklist for internal contributors

The PR Title
- conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
- contains a reference JIRA issue number like SQPIT-764
- answers the question: If merged, this PR will: ... ³
The PR Description
- is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

This PR covers the cases of displaying partial delivery errors (offline backends) to the user.
The core of this kalium related was merged by PR wireapp/kalium#1548

Smaller PR's merged here (breadcrumbs)

Testing

Test Coverage (Optional)

I have added automated test to this contribution

Attachments (Optional)

Screen.Recording.2023-02-26.at.13.46.23.mov

PR Post Submission Checklist for internal contributors (Optional)

Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References

https://sparkbox.com/foundry/semantic_commit_messages
https://github.com/wireapp/.github#usage
E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

…1501)" This reverts commit 92be253.

…R-3122) (#1501)"" This reverts commit e5d2050.

github-actions · 2023-03-02T12:31:57Z

Unit Test Results

  70 files ±0   70 suites ±0 41s ⏱️ +2s
442 tests ±0 441 ✔️ ±0 1 💤 ±0 0 ❌ ±0

Results for commit 71ca7f7. ± Comparison against base commit aded576.

♻️ This comment has been updated with latest results.

github-actions · 2023-03-02T12:38:58Z

Build available here. Scroll down to Artifacts!

github-actions · 2023-06-22T16:20:43Z

Build (dev-debug) available here. Scroll down to Artifacts!

github-actions · 2023-06-22T16:29:21Z

Build (beta-debug) available here. Scroll down to Artifacts!

AndroidBob · 2023-06-22T16:29:44Z

Build 1 succeeded.

The build produced the following APK's:

com.wire.android-vv4.3.0(6848313)(6848313)-staging-compat.apk

github-actions · 2023-06-23T09:30:15Z

Build (dev-debug) available here. Scroll down to Artifacts!

github-actions · 2023-06-23T09:30:52Z

Build (beta-debug) available here. Scroll down to Artifacts!

AndroidBob · 2023-06-23T09:44:08Z

Build 87 succeeded.

The build produced the following APK's:

com.wire.android-vv4.3.0(6854505)(6854505)-staging-compat.apk

github-actions · 2023-06-23T15:53:29Z

Build (dev-debug) available here. Scroll down to Artifacts!

github-actions · 2023-06-23T15:53:45Z

Build (beta-debug) available here. Scroll down to Artifacts!

AndroidBob · 2023-06-23T16:02:53Z

Build 97 succeeded.

The build produced the following APK's:

com.wire.android-vv4.3.0(6856797)(6856797)-staging-compat.apk

github-actions · 2023-06-26T08:39:13Z

Build (beta-debug) available here. Scroll down to Artifacts!

github-actions · 2023-06-26T08:43:00Z

Build (dev-debug) available here. Scroll down to Artifacts!

AndroidBob · 2023-06-26T08:49:19Z

Build 100 succeeded.

The build produced the following APK's:

com.wire.android-vv4.3.0(6880113)(6880113)-staging-compat.apk

Garzas

Awesome job 🚀 Just one small question 😄

Garzas · 2023-06-26T08:44:04Z

app/src/main/kotlin/com/wire/android/ui/home/conversations/MessageItemComponents.kt

+                        id = R.string.label_message_partial_delivery_participants_deliver_later,
+                        partialDeliveryFailureContent.filteredRecipientsFailure
+                            .filter {
+                                !it.asString(resources).contentEquals(resources.getString(R.string.username_unavailable_label))


Do you need to pass resources when you are in composable function?

Thanks! :D I'm taking note of this, and I will open a small pr with these improvements to avoid blocking builds on develop

saleniuk

Great! I added two suggestions 😉

saleniuk · 2023-06-26T09:28:51Z

app/src/main/kotlin/com/wire/android/mapper/RegularMessageContentMapper.kt

+    return when (deliveryStatus) {
+        is DeliveryStatus.PartialDelivery -> DeliveryStatusContent.PartialDelivery(
+            failedRecipients = deliveryStatus.recipientsFailedDelivery
+                .map { userId -> UIText.DynamicString(userList.findUser(userId = userId)?.name.orEmpty()) }


We could use:

userList.findUser(userId = userId)?.name.orUnknownName()

This way we get UIText.StringResource when we put the generic name instead of real one and we could filter out it later more easily, I know it's an extreme case but what if someone chose to name his account "Name not available" - it would be filtered out 😅 Instead, when filtering this way:

filter { it is UIText.StringResource && it.resId == R.string.username_unavailable_label }

it would be more safe 😄

Thanks! :D I'm taking note of this, and I will open a small pr with these improvements to avoid blocking builds on develop

saleniuk · 2023-06-26T09:40:34Z

app/src/main/res/values/strings.xml

    <string name="label_message_receive_failure">Download Error</string>
    <string name="label_message_decryption_failure_message">Message could not be decrypted.</string>
    <string name="label_message_decryption_failure_informative_message">Try resetting the session to generate new encryption keys.</string>
    <string name="label_message_knock">%s pinged</string>
+    <string name="label_message_partial_delivery_participants_count">%1$d participants didn\'t get your message.</string>


maybe this should also be a plural string?
for 1 person it should be "1 participant didn't get your message" 😄

Makes sense actually, the only thing, is that designs for this, we are not showing counter total if it's only one participant 😓

github-actions · 2023-06-26T14:02:10Z

Build (dev-debug) available here. Scroll down to Artifacts!

github-actions · 2023-06-26T14:02:12Z

Build (beta-debug) available here. Scroll down to Artifacts!

AndroidBob · 2023-06-26T14:13:06Z

Build 101 succeeded.

The build produced the following APK's:

com.wire.android-vv4.3.0(6882051)(6882051)-staging-compat.apk

yamilmedina added 23 commits February 23, 2023 15:57

feat: implementation of component for displaying partial success

b1792b4

feat: implementation of component for displaying partial success

ba10eaf

feat: implementation of component for displaying partial success

226b1d4

Merge branch 'develop' into feat/fed-msg-failed-to-send-handling

74e5dba

feat: mapping failures

0c96264

feat: extract resources

505dbae

Merge branch 'develop' into feat/fed-msg-failed-to-send-handling

b551855

feat: kalium ref

fe72cc0

feat: partial delivery failures ui

fca2be6

feat: kalium ref

bdb39e2

feat: cleanup

353c110

feat: add todo and feature flag

c466704

feat: add todo and feature flag

b5cc7f4

Merge branch 'develop' into feat/fed-msg-failed-to-send-handling

e5bbbfe

feat: kalium ref

813ac24

feat: kalium ref

91f841f

feat: detekt

b2b06b3

feat: tests

46772a2

Merge branch 'develop' into feat/fed-msg-failed-to-send-handling

92b9228

Revert "feat: federation, offline backends message sending (AR-3122) (#…

e5d2050

…1501)" This reverts commit 92be253.

chore: kalium ref

d27f336

Revert "Revert "feat: federation, offline backends message sending (A…

b664681

…R-3122) (#1501)"" This reverts commit e5d2050.

chore: remove flags

eac1948

yamilmedina added DO NOT MERGE epic labels Mar 2, 2023

yamilmedina self-assigned this Mar 2, 2023

pull-request-size bot added the size/L label Mar 2, 2023

yamilmedina added the long-lived-feature-branch label Mar 2, 2023

yamilmedina requested a review from MohamadJaara June 22, 2023 16:01

yamilmedina changed the title ~~feat: federation, offline backends message sending (AR-3122)~~ feat(federation): offline backends handling (epic) Jun 23, 2023

Merge branch 'develop' into feat/epic-federation-offline-messages

f9f2b32

yamilmedina removed the DO NOT MERGE label Jun 23, 2023

yamilmedina added 2 commits June 23, 2023 17:34

fix: kalium ref

2b76c32

Merge branch 'develop' into feat/epic-federation-offline-messages

ee2c96e

Merge branch 'develop' into feat/epic-federation-offline-messages

e0fa6d4

Garzas approved these changes Jun 26, 2023

View reviewed changes

saleniuk approved these changes Jun 26, 2023

View reviewed changes

fix: kalium ref

71ca7f7

yamilmedina enabled auto-merge June 26, 2023 13:45

yamilmedina added this pull request to the merge queue Jun 26, 2023

Merged via the queue into develop with commit 70f17ec Jun 26, 2023

yamilmedina deleted the feat/epic-federation-offline-messages branch June 26, 2023 14:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(federation): offline backends handling (epic) #1524

feat(federation): offline backends handling (epic) #1524

yamilmedina commented Mar 2, 2023 •

edited by github-actions bot

Loading

github-actions bot commented Mar 2, 2023 •

edited

Loading

github-actions bot commented Mar 2, 2023

github-actions bot commented Jun 22, 2023

github-actions bot commented Jun 22, 2023

AndroidBob commented Jun 22, 2023

github-actions bot commented Jun 23, 2023

github-actions bot commented Jun 23, 2023

AndroidBob commented Jun 23, 2023

github-actions bot commented Jun 23, 2023

github-actions bot commented Jun 23, 2023

AndroidBob commented Jun 23, 2023

github-actions bot commented Jun 26, 2023

github-actions bot commented Jun 26, 2023

AndroidBob commented Jun 26, 2023

Garzas left a comment

Garzas Jun 26, 2023

yamilmedina Jun 26, 2023

saleniuk left a comment

saleniuk Jun 26, 2023

yamilmedina Jun 26, 2023

saleniuk Jun 26, 2023

yamilmedina Jun 26, 2023

github-actions bot commented Jun 26, 2023

github-actions bot commented Jun 26, 2023

AndroidBob commented Jun 26, 2023

feat(federation): offline backends handling (epic) #1524

feat(federation): offline backends handling (epic) #1524

Conversation

yamilmedina commented Mar 2, 2023 • edited by github-actions bot Loading

PR Submission Checklist for internal contributors

What's new in this PR?

Issues

Testing

Test Coverage (Optional)

Attachments (Optional)

PR Post Submission Checklist for internal contributors (Optional)

PR Post Merge Checklist for internal contributors

References

github-actions bot commented Mar 2, 2023 • edited Loading

Unit Test Results

github-actions bot commented Mar 2, 2023

github-actions bot commented Jun 22, 2023

github-actions bot commented Jun 22, 2023

AndroidBob commented Jun 22, 2023

github-actions bot commented Jun 23, 2023

github-actions bot commented Jun 23, 2023

AndroidBob commented Jun 23, 2023

github-actions bot commented Jun 23, 2023

github-actions bot commented Jun 23, 2023

AndroidBob commented Jun 23, 2023

github-actions bot commented Jun 26, 2023

github-actions bot commented Jun 26, 2023

AndroidBob commented Jun 26, 2023

Garzas left a comment

Choose a reason for hiding this comment

Garzas Jun 26, 2023

Choose a reason for hiding this comment

yamilmedina Jun 26, 2023

Choose a reason for hiding this comment

saleniuk left a comment

Choose a reason for hiding this comment

saleniuk Jun 26, 2023

Choose a reason for hiding this comment

yamilmedina Jun 26, 2023

Choose a reason for hiding this comment

saleniuk Jun 26, 2023

Choose a reason for hiding this comment

yamilmedina Jun 26, 2023

Choose a reason for hiding this comment

github-actions bot commented Jun 26, 2023

github-actions bot commented Jun 26, 2023

AndroidBob commented Jun 26, 2023

yamilmedina commented Mar 2, 2023 •

edited by github-actions bot

Loading

github-actions bot commented Mar 2, 2023 •

edited

Loading