feat: offline backends - users metadata (AR-3124) #1758

yamilmedina · 2023-05-05T09:50:31Z

AR-3124 [Android] Implement UX for missing conversation and user metadata

PR Submission Checklist for internal contributors

The PR Title
- conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
- contains a reference JIRA issue number like SQPIT-764
- answers the question: If merged, this PR will: ... ³
The PR Description
- is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

We need to support displaying/ hiding and restrict options for users that we don't have metadata for.
This is done in, other user profile, participants lists and conversations list.

Solution

If a backend is down, and we only have ids of these remote users we present a better user experience.

Dependencies (Optional)

wireapp/kalium#1698

Needs releases with:

GitHub link to other pull request

Testing

Test Coverage (Optional)

I have added automated test to this contribution

Attachments (Optional)

PR Post Submission Checklist for internal contributors (Optional)

Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References

https://sparkbox.com/foundry/semantic_commit_messages
https://github.com/wireapp/.github#usage
E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

AndroidBob · 2023-05-05T10:01:58Z

Build 1 failed.

github-actions · 2023-05-05T10:28:03Z

Unit Test Results

  64 files ±0   64 suites ±0 41s ⏱️ -3s
449 tests ±0 448 ✔️ ±0 1 💤 ±0 0 ❌ ±0

Results for commit 6298d7f. ± Comparison against base commit 4da0d29.

♻️ This comment has been updated with latest results.

github-actions · 2023-05-05T10:34:33Z

Build (dev-debug) available here. Scroll down to Artifacts!

github-actions · 2023-05-05T10:35:25Z

Build (beta-debug) available here. Scroll down to Artifacts!

AndroidBob · 2023-05-05T10:44:19Z

Build 2 succeeded.

The build produced the following APK's:

com.wire.android-vv4.2.0(6431527)(6431527)-staging-compat.apk

alexandreferris

Great work! Just have a tiny comment

app/src/main/kotlin/com/wire/android/ui/userprofile/other/OtherUserDevicesScreen.kt

…ederation-usersmetadata

codecov · 2023-05-09T14:31:37Z

Codecov Report

Merging #1758 (6298d7f) into feat/epic-federation-offline-messages (4da0d29) will decrease coverage by 0.01%.
The diff coverage is 33.33%.

@@                             Coverage Diff                             @@
##             feat/epic-federation-offline-messages    #1758      +/-   ##
===========================================================================
- Coverage                                    36.97%   36.97%   -0.01%     
  Complexity                                     765      765              
===========================================================================
  Files                                          259      259              
  Lines                                         9768     9770       +2     
  Branches                                      1285     1285              
===========================================================================
  Hits                                          3612     3612              
- Misses                                        5805     5807       +2     
  Partials                                       351      351

Impacted Files	Coverage Δ
...roid/ui/userprofile/other/OtherUserProfileState.kt	`86.84% <0.00%> (-2.35%)`	⬇️
...e/android/ui/home/newconversation/model/Contact.kt	`90.00% <50.00%> (-10.00%)`	⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4da0d29...6298d7f. Read the comment docs.

github-actions · 2023-05-09T14:36:34Z

Build (dev-debug) available here. Scroll down to Artifacts!

github-actions · 2023-05-09T14:37:52Z

Build (beta-debug) available here. Scroll down to Artifacts!

AndroidBob · 2023-05-09T14:43:14Z

Build 3 succeeded.

The build produced the following APK's:

com.wire.android-vv4.2.0(6467514)(6467514)-staging-compat.apk

CLAassistant · 2023-05-10T08:01:27Z

All committers have signed the CLA.

github-actions · 2023-05-10T09:56:25Z

Build (beta-debug) available here. Scroll down to Artifacts!

github-actions · 2023-05-10T09:56:40Z

Build (dev-debug) available here. Scroll down to Artifacts!

AndroidBob · 2023-05-10T10:07:18Z

Build 4 succeeded.

The build produced the following APK's:

com.wire.android-vv4.2.0(6474508)(6474508)-staging-compat.apk

* feat: implementation of component for displaying partial success * feat: implementation of component for displaying partial success * feat: implementation of component for displaying partial success * feat: mapping failures * feat: extract resources * feat: kalium ref * feat: partial delivery failures ui * feat: kalium ref * feat: cleanup * feat: add todo and feature flag * feat: add todo and feature flag * feat: kalium ref * feat: kalium ref * feat: detekt * feat: tests * Revert "feat: federation, offline backends message sending (AR-3122) (#1501)" This reverts commit 92be253. * chore: kalium ref * Revert "Revert "feat: federation, offline backends message sending (AR-3122) (#1501)"" This reverts commit e5d2050. * chore: remove flags * chore(migration): out of conflict kalium ref * chore: fix tests * fix: refactor assig and naming * fix: remove unused code * chore: kalium ref * feat: handle asset failure * feat: handle asset partial delivery * feat: offline backends - handling list-prekeys failed to list messages (AR-3122) (#1745) * feat: handling edge cases messages ui on failure * feat: comments for next * fix: handle case when 1 user with failures * feat: wip handlingmessages * feat: wip handlingmessages * feat: wip handlingmessages * feat: fixing messages * feat: small refactor stable list * feat: kalium ref * feat: pr comments * feat: kalium ref * feat: offline backends - users metadata (AR-3124) (#1758) * feat: strings and kalium ref * feat: adjustment for not available users, other user profile screen * feat: adjustment for not available users, other user profile screen * feat: adjustment for not available users, other user profile screen * feat: adjustment for not available users, other user profile screen * feat: adjustment for not available users, other user profile screen * feat: adjustment query to consider deleted users logic as it is now * feat: adjustment styles for unknown * feat: adjustment styles for unknown * feat: kalium ref * feat(offline-backends): users and conversations without metadata refetch (AR-3123) (#1789) * feat: strings and kalium ref * feat: adjustment for not available users, other user profile screen * feat: adjustment for not available users, other user profile screen * feat: adjustment for not available users, other user profile screen * feat: adjustment for not available users, other user profile screen * feat: adjustment for not available users, other user profile screen * feat: adjustment query to consider deleted users logic as it is now * feat: adjustment styles for unknown * feat: adjustment styles for unknown * feat: persistence for getting users out of sync * feat: invok operator * feat: kalium ref * feat: fix f** merge error automatically bad rebased * feat: refresh users in search action * feat: kalium ref * feat: detekt * feat: fix tests * feat: fix tests * chore: update kalium ref with updates * chore: update kalium ref * chore: kalium ref with sync mechanism wired * chore: logging ref * fix: db ops, user persistence fixed * chore: kalium ref with sync mechanism wired * feat: refactor, comments * chore: wip for merge * fix: adjust text copy and minor visual fixes * fix: adjust text copy and minor visual fixes * fix: texts and cases * fix: texts and cases * fix: clickable extracted and new kalium ref * fix: clickable extracted and new kalium ref * feat: detekt * feat: conversation creation with offline backends (WPB-263) (#1842) * chore: kalium ref * feat: mapping new type for failed to add * feat: kalium ref * feat: adding base for message details failed to add * feat: renaming composable * feat: ui for failed to add * feat: detekt * feat: stringds * chore: kalium ref * fix: conversation failed to add error grouped by domain annotated string (WPB-263) (#1848) * chore: refator group by domain * chore: wip refactor to group by domain * chore: wip refactor to group by domain * chore: refactor messaging failed to add by domain * chore: refactor messaging failed to add by domain * chore: refactor messaging failed to add by domain * chore: refactor messaging failed to add by domain * chore: preparing merge * fix: kalium ref * fix: kalium ref

yamilmedina added 8 commits May 2, 2023 23:17

feat: strings and kalium ref

9774c3c

feat: adjustment for not available users, other user profile screen

bcb8a8b

feat: adjustment for not available users, other user profile screen

43fad4f

feat: adjustment for not available users, other user profile screen

29d69e3

feat: adjustment for not available users, other user profile screen

70df93f

feat: adjustment for not available users, other user profile screen

0b9fb0d

feat: adjustment query to consider deleted users logic as it is now

167a9b3

feat: adjustment styles for unknown

a651735

pull-request-size bot added the size/L label May 5, 2023

github-actions bot assigned yamilmedina May 5, 2023

yamilmedina changed the title ~~feat: offline backends - users metadata (AR-3123)~~ feat: offline backends - users metadata (AR-3124) May 5, 2023

feat: adjustment styles for unknown

f396689

yamilmedina requested review from borichellow, alexandreferris and MohamadJaara May 9, 2023 07:19

alexandreferris approved these changes May 9, 2023

View reviewed changes

app/src/main/kotlin/com/wire/android/ui/userprofile/other/OtherUserDevicesScreen.kt Outdated Show resolved Hide resolved

Merge branch 'feat/epic-federation-offline-messages' into feat/epic-f…

b2c1bfc

…ederation-usersmetadata

feat: kalium ref

6298d7f

yamilmedina merged commit ba55270 into feat/epic-federation-offline-messages May 10, 2023

yamilmedina deleted the feat/epic-federation-usersmetadata branch May 10, 2023 09:51

yamilmedina mentioned this pull request May 10, 2023

feat(federation): offline backends handling (epic) #1524

Merged

7 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: offline backends - users metadata (AR-3124) #1758

feat: offline backends - users metadata (AR-3124) #1758

yamilmedina commented May 5, 2023 •

edited by github-actions bot

Loading

AndroidBob commented May 5, 2023

github-actions bot commented May 5, 2023 •

edited

Loading

github-actions bot commented May 5, 2023

github-actions bot commented May 5, 2023

AndroidBob commented May 5, 2023

alexandreferris left a comment

codecov bot commented May 9, 2023 •

edited

Loading

github-actions bot commented May 9, 2023

github-actions bot commented May 9, 2023

AndroidBob commented May 9, 2023

CLAassistant commented May 10, 2023 •

edited

Loading

github-actions bot commented May 10, 2023

github-actions bot commented May 10, 2023

AndroidBob commented May 10, 2023

feat: offline backends - users metadata (AR-3124) #1758

feat: offline backends - users metadata (AR-3124) #1758

Conversation

yamilmedina commented May 5, 2023 • edited by github-actions bot Loading

PR Submission Checklist for internal contributors

What's new in this PR?

Issues

Solution

Dependencies (Optional)

Testing

Test Coverage (Optional)

Attachments (Optional)

PR Post Submission Checklist for internal contributors (Optional)

PR Post Merge Checklist for internal contributors

References

AndroidBob commented May 5, 2023

github-actions bot commented May 5, 2023 • edited Loading

Unit Test Results

github-actions bot commented May 5, 2023

github-actions bot commented May 5, 2023

AndroidBob commented May 5, 2023

alexandreferris left a comment

Choose a reason for hiding this comment

codecov bot commented May 9, 2023 • edited Loading

Codecov Report

github-actions bot commented May 9, 2023

github-actions bot commented May 9, 2023

AndroidBob commented May 9, 2023

CLAassistant commented May 10, 2023 • edited Loading

github-actions bot commented May 10, 2023

github-actions bot commented May 10, 2023

AndroidBob commented May 10, 2023

yamilmedina commented May 5, 2023 •

edited by github-actions bot

Loading

github-actions bot commented May 5, 2023 •

edited

Loading

codecov bot commented May 9, 2023 •

edited

Loading

CLAassistant commented May 10, 2023 •

edited

Loading