Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: conversation creation with offline backends (WPB-263) #1842

Merged
merged 14 commits into from
Jun 7, 2023
Merged

feat: conversation creation with offline backends (WPB-263) #1842

merged 14 commits into from
Jun 7, 2023

Conversation

yamilmedina
Copy link
Contributor

@yamilmedina yamilmedina commented Jun 6, 2023 •
edited by github-actions bot
Loading

TaskWPB-263 [Android] Implement UX on clients for conversation creation

PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³

  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Supports the creation of conversations and members from remote backends, as of now, we don't display information to the users about participants that couldn't be added.

Solutions

Gives the feedback to the user about participants that couldn't be added while creating a conversation, because the users might be down.

Dependencies (Optional)

Needs to be merged after:

Testing

WIP

Test Coverage (Optional)

  • I have added automated test to this contribution

Attachments (Optional)

Screen.Recording.2023-06-05.at.16.27.49.mov

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.
References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@yamilmedina yamilmedina marked this pull request as ready for review June 6, 2023 13:07
@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2023 •
edited
Loading

Unit Test Results

  71 files    71 suites   55s ⏱️
476 tests 475 ✔️ 1 💤 0 ❌

Results for commit 9b571e8.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2023

Build (beta-debug) available here. Scroll down to Artifacts!

@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2023

Build (dev-debug) available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 2 succeeded.

The build produced the following APK's:

@yamilmedina yamilmedina requested review from a team, alexandreferris, borichellow, vitorhugods, mchenani and trOnk12 and removed request for a team June 6, 2023 15:44
@AndroidBob
Copy link
Collaborator

Build 3 failed.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2023

Build (beta-debug) available here. Scroll down to Artifacts!

@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2023

Build (dev-debug) available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 4 succeeded.

The build produced the following APK's:

@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2023

Build (beta-debug) available here. Scroll down to Artifacts!

@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2023

Build (dev-debug) available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 5 succeeded.

The build produced the following APK's:

@yamilmedina yamilmedina merged commit a1fcd8b into feat/epic-federation-offline-messages Jun 7, 2023
@yamilmedina yamilmedina deleted the feat/offline-convo-creation branch June 7, 2023 15:25
@yamilmedina yamilmedina mentioned this pull request Jun 22, 2023
Merged
7 tasks
github-merge-queue bot pushed a commit that referenced this pull request Jun 26, 2023
@yamilmedina
feat(federation): offline backends handling (epic) (#1524)
70f17ec 
* feat: implementation of component for displaying partial success

* feat: implementation of component for displaying partial success

* feat: implementation of component for displaying partial success

* feat: mapping failures

* feat: extract resources

* feat: kalium ref

* feat: partial delivery failures ui

* feat: kalium ref

* feat: cleanup

* feat: add todo and feature flag

* feat: add todo and feature flag

* feat: kalium ref

* feat: kalium ref

* feat: detekt

* feat: tests

* Revert "feat: federation, offline backends message sending (AR-3122) (#1501)"

This reverts commit 92be253.

* chore: kalium ref

* Revert "Revert "feat: federation, offline backends message sending (AR-3122) (#1501)""

This reverts commit e5d2050.

* chore: remove flags

* chore(migration): out of conflict kalium ref

* chore: fix tests

* fix: refactor assig and naming

* fix: remove unused code

* chore: kalium ref

* feat: handle asset failure

* feat: handle asset partial delivery

* feat: offline backends - handling list-prekeys failed to list messages (AR-3122) (#1745)

* feat: handling edge cases messages ui on failure

* feat: comments for next

* fix: handle case when 1 user with failures

* feat: wip handlingmessages

* feat: wip handlingmessages

* feat: wip handlingmessages

* feat: fixing messages

* feat: small refactor stable list

* feat: kalium ref

* feat: pr comments

* feat: kalium ref

* feat: offline backends - users metadata (AR-3124) (#1758)

* feat: strings and kalium ref

* feat: adjustment for not available users, other user profile screen

* feat: adjustment for not available users, other user profile screen

* feat: adjustment for not available users, other user profile screen

* feat: adjustment for not available users, other user profile screen

* feat: adjustment for not available users, other user profile screen

* feat: adjustment query to consider deleted users logic as it is now

* feat: adjustment styles for unknown

* feat: adjustment styles for unknown

* feat: kalium ref

* feat(offline-backends): users and conversations without metadata refetch (AR-3123)  (#1789)

* feat: strings and kalium ref

* feat: adjustment for not available users, other user profile screen

* feat: adjustment for not available users, other user profile screen

* feat: adjustment for not available users, other user profile screen

* feat: adjustment for not available users, other user profile screen

* feat: adjustment for not available users, other user profile screen

* feat: adjustment query to consider deleted users logic as it is now

* feat: adjustment styles for unknown

* feat: adjustment styles for unknown

* feat: persistence for getting users out of sync

* feat: invok operator

* feat: kalium ref

* feat: fix f** merge error automatically bad rebased

* feat: refresh users in search action

* feat: kalium ref

* feat: detekt

* feat: fix tests

* feat: fix tests

* chore: update kalium ref with updates

* chore: update kalium ref

* chore: kalium ref with sync mechanism wired

* chore: logging ref

* fix: db ops, user persistence fixed

* chore: kalium ref with sync mechanism wired

* feat: refactor, comments

* chore: wip for merge

* fix: adjust text copy and minor visual fixes

* fix: adjust text copy and minor visual fixes

* fix: texts and cases

* fix: texts and cases

* fix: clickable extracted and new kalium ref

* fix: clickable extracted and new kalium ref

* feat: detekt

* feat: conversation creation with offline backends (WPB-263) (#1842)

* chore: kalium ref

* feat: mapping new type for  failed to add

* feat: kalium ref

* feat: adding base for message details failed to add

* feat: renaming composable

* feat: ui for failed to add

* feat: detekt

* feat: stringds

* chore: kalium ref

* fix: conversation failed to add error grouped by domain annotated string (WPB-263) (#1848)

* chore: refator group by domain

* chore: wip refactor to group by domain

* chore: wip refactor to group by domain

* chore: refactor messaging failed to add by domain

* chore: refactor messaging failed to add by domain

* chore: refactor messaging failed to add by domain

* chore: refactor messaging failed to add by domain

* chore: preparing merge

* fix: kalium ref

* fix: kalium ref
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexandreferris alexandreferris alexandreferris approved these changes

@borichellow borichellow Awaiting requested review from borichellow borichellow was automatically assigned from wireapp/android

@vitorhugods vitorhugods Awaiting requested review from vitorhugods vitorhugods was automatically assigned from wireapp/android

@mchenani mchenani Awaiting requested review from mchenani mchenani was automatically assigned from wireapp/android

@trOnk12 trOnk12 Awaiting requested review from trOnk12 trOnk12 was automatically assigned from wireapp/android

Assignees

@yamilmedina yamilmedina

Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yamilmedina @AndroidBob @alexandreferris