More overflow safe swiss table (#21) #22

zanmato1984 · 2025-01-13T15:07:00Z

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

zanmato1984 · 2025-01-13T18:11:23Z

cpp/src/arrow/acero/swiss_join.cc

@@ -1183,7 +1181,7 @@ Status SwissTableForJoinBuild::PushNextBatch(int64_t thread_id,
          // We want each partition to correspond to a range of block indices,
          // so we also partition on the highest bits of the hash.
          //
-          return locals.batch_hashes[i] >> (31 - log_num_prtns_) >> 1;
+          return locals.batch_hashes[i] >> (SwissTable::bits_hash_ - log_num_prtns_);


Might need to use -1 -1 to avoid shifting 32 bits.

### Rationale for this change [RecordBatch::Validate](https://arrow.apache.org/docs/cpp/api/table.html#_CPPv4NK5arrow11RecordBatch8ValidateEv) available in the C++ API. But, GLib doesn't support that method yet. ### What changes are included in this PR? This PR adds a validation method in the record-batch class. Before this change, the `Validate()` method was used in the `garrow_record_batch_new` implicitly. This PR removes it and adds it as a separate method. Users need to call `garrow_record_batch_validate()` explicitly by themselves. This is a backward incompatible change. ### Are these changes tested? Yes. ### Are there any user-facing changes? Yes. **This PR includes breaking changes to public APIs.** * GitHub Issue: apache#44759 Authored-by: Hiroyuki Sato <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>

…cation (apache#45355) ### Rationale for this change apache#45353 implemented `garrow_record_batch_validate()` method. But it was the incorrect location. We need to move the code location to use it as a C API. ### What changes are included in this PR? Move the `garrow_record_batch_validate()` location between `G_BEGIN_DECLS` and `G_END_DECLS`. ### Are these changes tested? Yes. ### Are there any user-facing changes? Yes. * GitHub Issue: apache#45354 Authored-by: Hiroyuki Sato <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>

…java/pom.xml to detect version (apache#45348) ### Rationale for this change java/pom.xml was moved to apache/arrow-java from apache/arrow. ### What changes are included in this PR? Detect version from cpp/CMakeLists.txt. ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * GitHub Issue: apache#45347 Authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Raúl Cumplido <[email protected]>

### Rationale for this change See apache#45120 ### What changes are included in this PR? Disable pointless test ### Are these changes tested? N/A ### Are there any user-facing changes? No * GitHub Issue: apache#45357 Lead-authored-by: David Li <[email protected]> Co-authored-by: Raúl Cumplido <[email protected]> Signed-off-by: Raúl Cumplido <[email protected]>

…cs (apache#45359) ### Rationale for this change Add a MemoryPool method to print allocator-specific statistics to stderr, to help diagnose perceived memory consumption issues. Also add missing Python bindings for `MemoryPool::total_bytes_allocated` and `MemoryPool::num_allocations`. ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * GitHub Issue: apache#45358 Authored-by: Antoine Pitrou <[email protected]> Signed-off-by: Antoine Pitrou <[email protected]>

…fset calculation for fixed length and null masks (apache#45336) ### Rationale for this change apache#45334 ### What changes are included in this PR? 1. An all-mighty test case that can effectively reveal all the bugs mentioned in the issue; 2. Other than directly fixing the bugs (actually simply casting to 64-bit somewhere in the multiplication will do), I did some refinement to the buffer accessors of the row table, in order to eliminate more potential similar issues (which I believe do exist): 1. `null_masks()` -> `null_masks(row_id)` which does overflow-safe indexing inside; 2. `is_null(row_id, col_pos)` which does overflow-safe indexing and directly gets the bit of the column; 3. `data(1)` -> `fixed_length_rows(row_id)` which first asserts the row table being fixed-length, then does overflow-safe indexing inside; 4. `data(2)` -> `var_length_rows()` which only asserts the row table being var-length. It is supposed to be paired by the `offsets()` (which is already 64-bit by apache#43389 ); 5. The `data(0/1/2)` members are made private. 3. The AVX2 specializations are fixed individually by using 64-bit multiplication and indexing. ### Are these changes tested? Yes. ### Are there any user-facing changes? None. * GitHub Issue: apache#45334 Authored-by: Rossi Sun <[email protected]> Signed-off-by: Rossi Sun <[email protected]>

…d and updated flags used with delvewheel repair (apache#45323) ### Rationale for this change It is already explained in the issue. ### What changes are included in this PR? This PR installs delvewheel by using its latest version instead of using a github branch. The new flag `--with-mangle` introduced in the latest version of delvewheel is used with `delvewheel repair` command. Removed comments that referred to the use of the github branch for delvewheel installation. ### Are these changes tested? No, these changes are not tested because to run Windows containers I will need [Windows 11 Pro or Enterprise](https://docs.docker.com/desktop/setup/install/windows-install/#:~:text=To%20run%20Windows%20containers%2C%20you%20need%20Windows%2010%20or%20Windows%2011%20Professional%20or%20Enterprise%20edition.%20Windows%20Home%20or%20Education%20editions%20only%20allow%20you%20to%20run%20Linux%20containers.). I do not have a machine that satisfies this requirement. * GitHub Issue: apache#45278 Authored-by: anubhav <[email protected]> Signed-off-by: Raúl Cumplido <[email protected]>

### Rationale for this change Our CI config for vcpkg declares superfluous Boost dependencies. ### Are these changes tested? Yes, by existing CI tests. ### Are there any user-facing changes? No. * GitHub Issue: apache#45361 Authored-by: Antoine Pitrou <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>

…he#45363) ### Rationale for this change CRAN uses 11.6 as the minimal macOS version now: https://cran.r-project.org/web/checks/check_flavors.html ### What changes are included in this PR? Update to 11.6 from 10.13. ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * GitHub Issue: apache#45356 Authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>

…roup and multiple row groups (apache#45350) ### Rationale for this change Loading `arrow::ArrayStatistics` logic depends on `parquet::ColumnChunkMetaData`. We can't get `parquet::ColumnChunkMetaData` when requested row groups are empty because no associated row group and column chunk exist. We can't use multiple `parquet::ColumnChunkMetaData`s for now because we don't have statistics merge logic. So we can't load statistics when we use multiple row groups. ### What changes are included in this PR? * Don't load statistics when no row groups are used * Don't load statistics when multiple row groups are used * Add `parquet::ArrowReaderProperties::{set_,}should_load_statistics()` to enforce loading statistics by loading row group one by one ### Are these changes tested? Yes. ### Are there any user-facing changes? Yes. * GitHub Issue: apache#45339 Authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>

…45134) ### Rationale for this change Post apache#44945 the Java implementation lives in it's own repo. Update docs to point there. ### What changes are included in this PR? Updates to a few locations that reference old Java impl location. ### Are these changes tested? Rendered the Sphinx ones locally to check. ### Are there any user-facing changes? No Lead-authored-by: parthchonkar <[email protected]> Co-authored-by: Parth Chonkar <[email protected]> Co-authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>

…t for pandas>=2.3 (apache#45383) ### Rationale for this change The option already exists in pandas 2.2, but for that version our code does not work, so restricting it to pandas >= 2.3 * GitHub Issue: apache#45296 Authored-by: Joris Van den Bossche <[email protected]> Signed-off-by: Raúl Cumplido <[email protected]>

…he#45391) ### Rationale for this change apache#45390 implemented `garrow_array_validate_full()`. But it used `validate_full` not `validate-full` for error tag. We should use hyphen-separated words for error tag for consistency. ### What changes are included in this PR? `validate_ful` -> `validate-full` ### Are these changes tested? Yes. ### Are there any user-facing changes? Yes. * GitHub Issue: apache#45390 Authored-by: Hiroyuki Sato <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>

…e#45386) ### Rationale for this change [RecordBatch::ValidateFull](https://arrow.apache.org/docs/cpp/api/table.html#_CPPv4NK5arrow11RecordBatch12ValidateFullEv) available in the C++ API. But, GLib doesn't support that method yet. ### What changes are included in this PR? This PR adds a validation method in the record-batch class. ### Are these changes tested? Yes. ### Are there any user-facing changes? Yes. * GitHub Issue: apache#44760 Lead-authored-by: Hiroyuki Sato <[email protected]> Co-authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>

…ntu CI (apache#45395) ### Rationale for this change Ubuntu 20.04 will reach EOL by 2025-04, so we must upgrade the MATLAB workflow's GitHub runner from Ubuntu 20.04 to Ubuntu 22.04 or Ubuntu 24.04. ### What changes are included in this PR? 1. Updated the Ubuntu MATLAB GitHub workflow to use Ubuntu 22.04 as the GitHub runner. 2. Updated the Ubuntu MATLAB crossbow task to use Ubuntu 22.04 as the GitHub runner. ### Are these changes tested? 1. All GitHub checks passed. 2. Manually triggered the MATLAB crossbow task and installed the MATLAB-Arrow Interface Toolbox on Debian-12. ### Are there any user-facing changes? N/A * GitHub Issue: apache#45388 Authored-by: Sarah Gilmore <[email protected]> Signed-off-by: Sarah Gilmore <[email protected]>

…apache#45387) ### Rationale for this change Conan 1 is deprecated. We should use Conan 2. ### What changes are included in this PR? Use "conania/gcc11-ubuntu16.04:2.12.1" because it's the latest version. Based on https://github.com/conan-io/conan-docker-tools/blob/master/images/README.md#official-docker-images, "gcc11-ubuntu16.04" is only supported image. `ci/conan/` is synchronized with the latest https://github.com/conan-io/conan-center-index . ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * GitHub Issue: apache#45381 Authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>

Bumps [del-cli](https://github.com/sindresorhus/del-cli) from 5.1.0 to 6.0.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/sindresorhus/del-cli/releases">del-cli's releases</a>.</em></p> <blockquote> <h2>v6.0.0</h2> <h3>Breaking</h3> <ul> <li>Require Node.js 18 de54031</li> </ul> <h3>Improvements</h3> <ul> <li>Update dependencies de54031</li> </ul> <p><a href="https://github.com/sindresorhus/del-cli/compare/v5.1.0...v6.0.0">https://github.com/sindresorhus/del-cli/compare/v5.1.0...v6.0.0</a></p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/sindresorhus/del-cli/commit/f6e4605b03475c6045d08db001e2e001d04af8ba"><code>f6e4605</code></a> 6.0.0</li> <li><a href="https://github.com/sindresorhus/del-cli/commit/de54031c340dda9230d1a7c855f93813f7ab1259"><code>de54031</code></a> Require Node.js 18 and update dependencies</li> <li><a href="https://github.com/sindresorhus/del-cli/commit/028ebb11bb0401f2901233ab15fd86f52d9e7dd1"><code>028ebb1</code></a> Meta tweaks</li> <li>See full diff in <a href="https://github.com/sindresorhus/del-cli/compare/v5.1.0...v6.0.0">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=del-cli&package-manager=npm_and_yarn&previous-version=5.1.0&new-version=6.0.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@ dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@ dependabot rebase` will rebase this PR - `@ dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@ dependabot merge` will merge this PR after your CI passes on it - `@ dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@ dependabot cancel merge` will cancel a previously requested merge and block automerging - `@ dependabot reopen` will reopen this PR if it is closed - `@ dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@ dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@ dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@ dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@ dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Sutou Kouhei <[email protected]>

### Rationale for this change We need `arrow_testing` for `ARROW_FUZZING`. And `arrow_testing` needs Boost. ### What changes are included in this PR? Use Boost with `ARROW_FUZZING`. ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * GitHub Issue: apache#45396 Authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>

…che#45403) ### Rationale for this change apache#45398 will apply Ruby lint. Before this change, some code needs to be reformatted to avoid format errors. ```bash Ruby Format..............................................................Failed - hook id: rubocop - exit code: 1 - files were modified by this hook Inspecting 79 files ..............................C................................................ Offenses: c_glib/test/test-record-batch-datum.rb:52:101: C: [Corrected] Layout/LineLength: Line is too long. [107/100] assert_equal("RecordBatch(visible: [\n" + " true,\n" + " false\n" + " ]\n" + ")", @ datum.to_s) ^^^^^^^ c_glib/test/test-record-batch-datum.rb:53:1: C: [Corrected] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line. @ datum.to_s) ^^^^^^^^^^^ 79 files inspected, 2 offenses detected, 2 offenses corrected Inspecting 79 files ..................C................................C.....................C..... Offenses: dev/release/01-prepare-test.rb:267:101: C: Layout/LineLength: Line is too long. [101/100] "+<p><a href=\"../#{@ previous_compatible_version}/r/\">#{@ previous_r_version}</a></p>", ^ c_glib/test/test-struct-field-options.rb:45:101: C: Layout/LineLength: Line is too long. [112/100] message = "[struct-field-options][set-field-ref]: Invalid: Dot path '[foo]' contained an unterminated index" ^^^^^^^^^^^^ ruby/red-arrow/test/test-table.rb:1524:21: C: [Corrected] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line. table1.join(table2, ... ^^^^^^^^^^^^^^^^^^^ 79 files inspected, 3 offenses detected, 1 offense corrected Inspecting 79 files ......................C........................................................ Offenses: c_glib/test/test-chunked-array-datum.rb:52:101: C: [Corrected] Layout/LineLength: Line is too long. [108/100] assert_equal("ChunkedArray([\n" + " [\n" + " true,\n" + " false\n" + " ]\n" + "])", @ datum.to_s) ^^^^^^^^ c_glib/test/test-chunked-array-datum.rb:53:1: C: [Corrected] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line. @ datum.to_s) ^^^^^^^^^^^ 79 files inspected, 2 offenses detected, 2 offenses corrected Inspecting 79 files ..............C............................C....C.............................. Offenses: c_glib/test/dataset/test-file-system-dataset.rb:98:30: C: [Corrected] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line. label: [ ... ^^^^^^^^ dev/release/post-12-bump-versions-test.rb:305:101: C: Layout/LineLength: Line is too long. [103/100] "+<p><a href=\"../#{@ previous_compatible_version}/r/\">#{@ previous_r_version}</a></p>", ^^^ c_glib/test/test-array.rb:122:101: C: [Corrected] Layout/LineLength: Line is too long. [103/100] build_int32_array([0, 1069547520, -1071644672, nil]).view(Arrow::FloatDataType.new)) ^^^ 79 files inspected, 3 offenses detected, 2 offenses corrected Inspecting 79 files ............................................................................... 79 files inspected, no offenses detected Inspecting 79 files ........................................................................C...... Offenses: c_glib/test/test-large-list-array.rb:91:30: C: [Corrected] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line. [ ... ^ 79 files inspected, 1 offense detected, 1 offense corrected Inspecting 79 files ............................................................................... 79 files inspected, no offenses detected Inspecting 79 files ...............................C............................................... Offenses: c_glib/test/test-uint-array-builder.rb:35:40: C: [Corrected] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line. Arrow::Buffer.new(values.pack("S*")), ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ c_glib/test/test-uint-array-builder.rb:36:40: C: [Corrected] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line. Arrow::Buffer.new([0b011].pack("C*")), ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ c_glib/test/test-uint-array-builder.rb:37:40: C: [Corrected] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line. -1)) ^^ c_glib/test/test-uint-array-builder.rb:45:40: C: [Corrected] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line. Arrow::Buffer.new(values.pack("L*")), ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ c_glib/test/test-uint-array-builder.rb:46:40: C: [Corrected] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line. Arrow::Buffer.new([0b011].pack("C*")), ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ c_glib/test/test-uint-array-builder.rb:47:40: C: [Corrected] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line. -1)) ^^ 79 files inspected, 6 offenses detected, 6 offenses corrected pre-commit hook(s) made changes. If you are seeing this message in CI, reproduce locally with: `pre-commit run --all-files`. To run `pre-commit` as part of git workflow, use `pre-commit install`. All changes made by hooks: diff --git a/c_glib/test/dataset/test-file-system-dataset.rb b/c_glib/test/dataset/test-file-system-dataset.rb index 96deedf6b..0cd2a61ea 100644 --- a/c_glib/test/dataset/test-file-system-dataset.rb +++ b/c_glib/test/dataset/test-file-system-dataset.rb @@ -95,11 +95,11 @@ class TestDatasetFileSystemDataset < Test::Unit::TestCase build_int32_array([2]), build_int32_array([3]), ], - label: [ - build_string_array(["a", "a"]), - build_string_array(["b"]), - build_string_array(["c"]), - ]) + label: [ + build_string_array(["a", "a"]), + build_string_array(["b"]), + build_string_array(["c"]), + ]) return dataset, expected_table end diff --git a/c_glib/test/test-array.rb b/c_glib/test/test-array.rb index aa129a474..681544920 100644 --- a/c_glib/test/test-array.rb +++ b/c_glib/test/test-array.rb @@ -119,7 +119,8 @@ class TestArray < Test::Unit::TestCase sub_test_case("#view") do def test_valid assert_equal(build_float_array([0.0, 1.5, -2.5, nil]), - build_int32_array([0, 1069547520, -1071644672, nil]).view(Arrow::FloatDataType.new)) + build_int32_array([0, 1069547520, -1071644672, +nil]).view(Arrow::FloatDataType.new)) end def test_invalid diff --git a/c_glib/test/test-chunked-array-datum.rb b/c_glib/test/test-chunked-array-datum.rb index b82f3eed8..17a2cbd1a 100644 --- a/c_glib/test/test-chunked-array-datum.rb +++ b/c_glib/test/test-chunked-array-datum.rb @@ -49,7 +49,8 @@ class TestChunkedArrayDatum < Test::Unit::TestCase end def test_to_string - assert_equal("ChunkedArray([\n" + " [\n" + " true,\n" + " false\n" + " ]\n" + "])", @ datum.to_s) + assert_equal("ChunkedArray([\n" + " [\n" + " true,\n" + " false\n" + " ]\n" + "])", + @ datum.to_s) end def test_value diff --git a/c_glib/test/test-large-list-array.rb b/c_glib/test/test-large-list-array.rb index 2f7efab5a..fa9c92ec8 100644 --- a/c_glib/test/test-large-list-array.rb +++ b/c_glib/test/test-large-list-array.rb @@ -88,10 +88,10 @@ class TestLargeListArray < Test::Unit::TestCase def test_value_offsets array = build_large_list_array(Arrow::Int8DataType.new, - [ - [-29, 29], - [-1, 0, 1], - ]) + [ + [-29, 29], + [-1, 0, 1], + ]) assert_equal([0, 2, 5], array.value_offsets) end diff --git a/c_glib/test/test-record-batch-datum.rb b/c_glib/test/test-record-batch-datum.rb index ec572e0f1..e2d9c0258 100644 --- a/c_glib/test/test-record-batch-datum.rb +++ b/c_glib/test/test-record-batch-datum.rb @@ -49,7 +49,8 @@ class TestRecordBatchDatum < Test::Unit::TestCase end def test_to_string - assert_equal("RecordBatch(visible: [\n" + " true,\n" + " false\n" + " ]\n" + ")", @ datum.to_s) + assert_equal("RecordBatch(visible: [\n" + " true,\n" + " false\n" + " ]\n" + ")", + @ datum.to_s) end def test_value diff --git a/c_glib/test/test-uint-array-builder.rb b/c_glib/test/test-uint-array-builder.rb index 89621189b..3aa3a1c48 100644 --- a/c_glib/test/test-uint-array-builder.rb +++ b/c_glib/test/test-uint-array-builder.rb @@ -32,9 +32,9 @@ class TestUIntArrayBuilder < Test::Unit::TestCase values = [0, border_value] assert_equal(build_uint_array([*values, nil]), Arrow::UInt16Array.new(3, - Arrow::Buffer.new(values.pack("S*")), - Arrow::Buffer.new([0b011].pack("C*")), - -1)) + Arrow::Buffer.new(values.pack("S*")), + Arrow::Buffer.new([0b011].pack("C*")), + -1)) end def test_uint32 @@ -42,9 +42,9 @@ class TestUIntArrayBuilder < Test::Unit::TestCase values = [0, border_value] assert_equal(build_uint_array([*values, nil]), Arrow::UInt32Array.new(3, - Arrow::Buffer.new(values.pack("L*")), - Arrow::Buffer.new([0b011].pack("C*")), - -1)) + Arrow::Buffer.new(values.pack("L*")), + Arrow::Buffer.new([0b011].pack("C*")), + -1)) end def test_uint64 diff --git a/ruby/red-arrow/test/test-table.rb b/ruby/red-arrow/test/test-table.rb index a69e92615..2117e60df 100644 --- a/ruby/red-arrow/test/test-table.rb +++ b/ruby/red-arrow/test/test-table.rb @@ -1521,10 +1521,10 @@ visible: false ["key2_right", [100, 20]], ["string", ["1-100", "2-20"]], ]), - table1.join(table2, - ["key1", "key2"], - left_suffix: "_left", - right_suffix: "_right")) + table1.join(table2, + ["key1", "key2"], + left_suffix: "_left", + right_suffix: "_right")) end end end ``` ### What changes are included in this PR? Reformat Ruby codes. ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * GitHub Issue: apache#45402 Lead-authored-by: Hiroyuki Sato <[email protected]> Co-authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>

### Rationale for this change Multiple users are developing Ruby codes. Adding Ruby Lint helps keep the same style. ### What changes are included in this PR? Add Ruby Lint. (Rubocop) ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * GitHub Issue: apache#45398 Lead-authored-by: Hiroyuki Sato <[email protected]> Co-authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>

Bumps [actions/setup-dotnet](https://github.com/actions/setup-dotnet) from 4.2.0 to 4.3.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/actions/setup-dotnet/releases">actions/setup-dotnet's releases</a>.</em></p> <blockquote> <h2>v4.3.0</h2> <h2>What's Changed</h2> <ul> <li>README update - add permissions section by <a href="https://github.com/benwells"><code>@benwells</code></a> in <a href="https://redirect.github.com/actions/setup-dotnet/pull/587">actions/setup-dotnet#587</a></li> <li>Configure Dependabot settings by <a href="https://github.com/HarithaVattikuti"><code>@HarithaVattikuti</code></a> in <a href="https://redirect.github.com/actions/setup-dotnet/pull/585">actions/setup-dotnet#585</a></li> <li>Upgrade <strong>cache</strong> from 3.2.4 to 4.0.0 by <a href="https://github.com/aparnajyothi-y"><code>@aparnajyothi-y</code></a> in <a href="https://redirect.github.com/actions/setup-dotnet/pull/586">actions/setup-dotnet#586</a></li> <li>Upgrade <strong>actions/publish-immutable-action</strong> from 0.0.3 to 0.0.4 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/actions/setup-dotnet/pull/590">actions/setup-dotnet#590</a></li> <li>Upgrade <strong><code>@actions/http-client</code></strong> from 2.2.1 to 2.2.3 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/actions/setup-dotnet/pull/592">actions/setup-dotnet#592</a></li> <li>Upgrade <strong>undici</strong> from 5.28.4 to 5.28.5 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/actions/setup-dotnet/pull/596">actions/setup-dotnet#596</a></li> </ul> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/benwells"><code>@benwells</code></a> made their first contribution in <a href="https://redirect.github.com/actions/setup-dotnet/pull/587">actions/setup-dotnet#587</a></li> <li><a href="https://github.com/aparnajyothi-y"><code>@aparnajyothi-y</code></a> made their first contribution in <a href="https://redirect.github.com/actions/setup-dotnet/pull/586">actions/setup-dotnet#586</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/actions/setup-dotnet/compare/v4...v4.3.0">https://github.com/actions/setup-dotnet/compare/v4...v4.3.0</a></p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/actions/setup-dotnet/commit/3951f0dfe7a07e2313ec93c75700083e2005cbab"><code>3951f0d</code></a> Bump undici from 5.28.4 to 5.28.5 (<a href="https://redirect.github.com/actions/setup-dotnet/issues/596">#596</a>)</li> <li><a href="https://github.com/actions/setup-dotnet/commit/4849e736f1bd76c37a6dd7d4b8f84581fb6d8baf"><code>4849e73</code></a> Bump <code>@actions/http-client</code> from 2.2.1 to 2.2.3 (<a href="https://redirect.github.com/actions/setup-dotnet/issues/592">#592</a>)</li> <li><a href="https://github.com/actions/setup-dotnet/commit/3e76c4dc412e00b3fcb875aaddbf27000f2d428b"><code>3e76c4d</code></a> Bump actions/publish-immutable-action from 0.0.3 to 0.0.4 (<a href="https://redirect.github.com/actions/setup-dotnet/issues/590">#590</a>)</li> <li><a href="https://github.com/actions/setup-dotnet/commit/91b379339b47ad470db060ea16315b66313ae78e"><code>91b3793</code></a> Configure Dependabot settings (<a href="https://redirect.github.com/actions/setup-dotnet/issues/585">#585</a>)</li> <li><a href="https://github.com/actions/setup-dotnet/commit/4b37d22250db48bbc2ccdde8ef5dbf479769f7ac"><code>4b37d22</code></a> upgrade cache from 3.2.4 to 4.0.0 (<a href="https://redirect.github.com/actions/setup-dotnet/issues/586">#586</a>)</li> <li><a href="https://github.com/actions/setup-dotnet/commit/f9d0f6282caace67f83f94183a90502136d73900"><code>f9d0f62</code></a> Update README.md (<a href="https://redirect.github.com/actions/setup-dotnet/issues/587">#587</a>)</li> <li>See full diff in <a href="https://github.com/actions/setup-dotnet/compare/v4.2.0...v4.3.0">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=actions/setup-dotnet&package-manager=github_actions&previous-version=4.2.0&new-version=4.3.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@ dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@ dependabot rebase` will rebase this PR - `@ dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@ dependabot merge` will merge this PR after your CI passes on it - `@ dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@ dependabot cancel merge` will cancel a previously requested merge and block automerging - `@ dependabot reopen` will reopen this PR if it is closed - `@ dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@ dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@ dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@ dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@ dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Sutou Kouhei <[email protected]>

### Rationale for this change apache#37848 upgraded the JIT compiler for LLVM/Gandiva code which presented linking errors with newer version of LLVM. Some Gandiva tests were disabled, and here at Dremio I am running into the same linking problem when trying to build with an updated Arrow library. After reading some threads on the LLVM discord server it appears that updating to LLVM 18.1 will fix the symbol issue. I tested locally and was able to re-enable the disabled java tests which were showing the unexported ORC symbol issue. More discussion in apache/arrow-java#63. ### What changes are included in this PR? Updating vcpkg and pinning LLVM to 18.1 Notably I found encountered some build problems using the newest vcpkg update, which appeared to be related to the updated gRPC libraries. My Arrow jar CI build was timing out in this case with no clear error in the logs. The vcpkg version included here has the LLVM 18 update but not the gRPC update (which isn't needed for this issue). ### Are these changes tested? Covered by existing tests. Will also re-enable the disabled Java tests in a future change. ### Are there any user-facing changes? No. * GitHub Issue: apache#45132 Lead-authored-by: Logan Riggs <[email protected]> Co-authored-by: lriggs <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>

…#45392) ### Rationale for this change `RankQuantileOptions` are currently not exposed on Pyarrow and CI job breaks when `-W error` is used. ### What changes are included in this PR? Expose `RankQuantileOptions` and test options and kernel from pyarrow. It also includes some minor refactor for the unwrap sort keys logic to move it into a common function. ### Are these changes tested? Yes ### Are there any user-facing changes? The options for the new kernel are exposed on pyarrow. * GitHub Issue: apache#45380 Lead-authored-by: Raúl Cumplido <[email protected]> Co-authored-by: Antoine Pitrou <[email protected]> Signed-off-by: Antoine Pitrou <[email protected]>

### Rationale for this change We've accumulated multiple workarounds for various Cython issues over the years. Now that we require at least Cython 3.0, we can remove some of those. ### Are these changes tested? Yes, by existing CI builds and tests. ### Are there any user-facing changes? No. * GitHub Issue: apache#45433 Authored-by: Antoine Pitrou <[email protected]> Signed-off-by: Antoine Pitrou <[email protected]>

…ON/ARROW_BUILD_SHARED=OFF (apache#45424) ### Rationale for this change We can use `libarrow_testing.a` without `boost::filesystem` when `arrow::util::Process` isn't used. ### What changes are included in this PR? `ARROW_TESTING=ON` requires Boost. If `ARROW_BUILD_SHARED=ON` is also used, Boost libraries are also required. ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * GitHub Issue: apache#45423 Authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>

apache#45084) ### Rationale for this change The C++ arrow has a JSON streaming reader which is not exposed on the Python interface. ### What changes are included in this PR? This PR is based on apache#33761. It adds the `open_json` method to open a streaming reader for a JSON file. ### Are these changes tested? Yes ### Are there any user-facing changes? Yes. A new `open_json` method has been added to the Python interface, located at `pyarrow.json.open_json`, and its parameters are the same as the `pyarrow.json.read_json` * GitHub Issue: apache#14932 Lead-authored-by: pxc <[email protected]> Co-authored-by: Akshay Subramanian <[email protected]> Signed-off-by: Antoine Pitrou <[email protected]>

…pache#45456) ### Rationale for this change Due to byte_allocated size returning 0, The TestMemoryPool-only test failed. This issue did not occur when running other tests together because the other tests use the memory pool. ### What changes are included in this PR? Allocate a ResizableBuffer in the TestMemoryPool test. ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * GitHub Issue: apache#45455 Lead-authored-by: Hiroyuki Sato <[email protected]> Co-authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>

…ob (apache#45379) ### Rationale for this change The job is currently timing out. ### What changes are included in this PR? Increase timeout ### Are these changes tested? Via archery ### Are there any user-facing changes? No * GitHub Issue: apache#45378 Authored-by: Raúl Cumplido <[email protected]> Signed-off-by: Raúl Cumplido <[email protected]>

…or (apache#45461) ### Rationale for this change As per the [collaborators guide](https://github.com/apache/arrow/blob/11ce71d286b0c1d1ef862801756e180c32a32d97/docs/source/developers/reviewing.rst#collaborators) we should maintain the list of collaborators updated. ### What changes are included in this PR? I've removed an inactive collaborator for a year. And added a new collaborator so they can trigger archery jobs and triage. ### Are these changes tested? No ### Are there any user-facing changes? No Authored-by: Raúl Cumplido <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>

…es (apache#45460) ### Rationale for this change To check the operation of Homebrew after the new version is released, we need to sync the latest formula. ### What changes are included in this PR? Backport the latest formula changes ### Are these changes tested? Yes. ### Are there any user-facing changes? No. Comparison result. ```diff diff -ur /tmp/arrow/apache-arrow-glib.rb dev/tasks/homebrew-formulae/apache-arrow-glib.rb --- /tmp/arrow/apache-arrow-glib.rb 2025-02-03 09:30:42 +++ dev/tasks/homebrew-formulae/apache-arrow-glib.rb 2025-02-07 18:20:47 @@ -1,23 +1,41 @@ +# BSD 2-Clause License +# +# Copyright (c) 2009-present, Homebrew contributors +# All rights reserved. +# +# Redistribution and use in source and binary forms, with or without +# modification, are permitted provided that the following conditions are met: +# +# * Redistributions of source code must retain the above copyright notice, this +# list of conditions and the following disclaimer. +# +# * Redistributions in binary form must reproduce the above copyright notice, +# this list of conditions and the following disclaimer in the documentation +# and/or other materials provided with the distribution. +# +# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" +# AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE +# IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE +# DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE +# FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL +# DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR +# SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER +# CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, +# OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE +# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. + +# https://github.com/Homebrew/homebrew-core/blob/-/Formula/a/apache-arrow-glib.rb + class ApacheArrowGlib < Formula desc "GLib bindings for Apache Arrow" homepage "https://arrow.apache.org/" - url "https://www.apache.org/dyn/closer.lua?path=arrow/arrow-19.0.0/apache-arrow-19.0.0.tar.gz" - mirror "https://archive.apache.org/dist/arrow/arrow-19.0.0/apache-arrow-19.0.0.tar.gz" - sha256 "f89b93f39954740f7184735ff1e1d3b5be2640396febc872c4955274a011f56b" + url "https://www.apache.org/dyn/closer.lua?path=arrow/arrow-20.0.0-SNAPSHOT/apache-arrow-20.0.0-SNAPSHOT.tar.gz" + sha256 "9948ddb6d4798b51552d0dca3252dd6e3a7d0f9702714fc6f5a1b59397ce1d28" license "Apache-2.0" head "https://github.com/apache/arrow.git", branch: "main" livecheck do formula "apache-arrow" - end - - bottle do - sha256 cellar: :any, arm64_sequoia: "e420ce8d7c772054c9040a326f54be83306741c3b13f1f95c1aa660bcc3419bc" - sha256 cellar: :any, arm64_sonoma: "f7f697c4bb8922d0fd7ebea9fdedcb03798bb3ce641525bd5b5def7e30d9dbe4" - sha256 cellar: :any, arm64_ventura: "90c37373807d0607465aeb66dfa6a8f4e1073a1c609ac3d3968234f2f63b12ef" - sha256 cellar: :any, sonoma: "2f66ab77233cfaebd4a6cb35ee75a33b6533973ee25608c88a6a4e0f074762c7" - sha256 cellar: :any, ventura: "8339abe968a0697213167673c40071a958f1eb636f02da0ce33e4f61d3a8de2a" - sha256 x86_64_linux: "6776b45d6bafd3bdc32f1d6d0be57e7ed60b8bf0171e87c5931ad76a176a2191" end depends_on "gobject-introspection" => :build diff -ur /tmp/arrow/apache-arrow.rb dev/tasks/homebrew-formulae/apache-arrow.rb --- /tmp/arrow/apache-arrow.rb 2025-02-02 11:32:18 +++ dev/tasks/homebrew-formulae/apache-arrow.rb 2025-02-07 18:10:13 @@ -1,21 +1,38 @@ +# BSD 2-Clause License +# +# Copyright (c) 2009-present, Homebrew contributors +# All rights reserved. +# +# Redistribution and use in source and binary forms, with or without +# modification, are permitted provided that the following conditions are met: +# +# * Redistributions of source code must retain the above copyright notice, this +# list of conditions and the following disclaimer. +# +# * Redistributions in binary form must reproduce the above copyright notice, +# this list of conditions and the following disclaimer in the documentation +# and/or other materials provided with the distribution. +# +# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" +# AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE +# IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE +# DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE +# FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL +# DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR +# SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER +# CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, +# OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE +# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. + +# https://github.com/Homebrew/homebrew-core/blob/-/Formula/a/apache-arrow.rb + class ApacheArrow < Formula desc "Columnar in-memory analytics layer designed to accelerate big data" homepage "https://arrow.apache.org/" - url "https://www.apache.org/dyn/closer.lua?path=arrow/arrow-19.0.0/apache-arrow-19.0.0.tar.gz" - mirror "https://archive.apache.org/dist/arrow/arrow-19.0.0/apache-arrow-19.0.0.tar.gz" - sha256 "f89b93f39954740f7184735ff1e1d3b5be2640396febc872c4955274a011f56b" + url "https://www.apache.org/dyn/closer.lua?path=arrow/arrow-20.0.0-SNAPSHOT/apache-arrow-20.0.0-SNAPSHOT.tar.gz" + sha256 "9948ddb6d4798b51552d0dca3252dd6e3a7d0f9702714fc6f5a1b59397ce1d28" license "Apache-2.0" - revision 1 head "https://github.com/apache/arrow.git", branch: "main" - - bottle do - sha256 cellar: :any, arm64_sequoia: "a6c9c00a48857deb74c1d00bbf7858466307853629866e9500fe57dc5889eb58" - sha256 cellar: :any, arm64_sonoma: "d1b3aa26f91c7c452a60dca1b590c54b0026a5ee05a9c148782946c66d878c6e" - sha256 cellar: :any, arm64_ventura: "5d71a8bd28fd50e5bf190c3764e5cf1367d2c6ee45fc0b3850da6f178cb0d5eb" - sha256 cellar: :any, sonoma: "45a9742c35214fd74301c6261a5f137e43b5e4be2c0b1281567e5699d35f46a9" - sha256 cellar: :any, ventura: "bac30f19cf4bb0ed2c444a782152b8458ebcdfd3602e0f7f70457e4b0faf9396" - sha256 cellar: :any_skip_relocation, x86_64_linux: "4699146750ca07631a98168da1b237315363dbaa0dd4fae8f4ad29044e724545" - end depends_on "boost" => :build depends_on "cmake" => :build ``` * GitHub Issue: apache#45416 Authored-by: Hiroyuki Sato <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>

…issue template (apache#45450) ### Rationale for this change A conversation on Zulip reminded me we have this issue template and, after reviewing, I thought the text could be improved a bit. My main goal was to make it more clear that the user@ list is the place users may want to go with usage questions. ### Are these changes tested? Just by pulling the markdown out and ensuring it renders locally. They do. ### Are there any user-facing changes? Updated issue template. Authored-by: Bryce Mecum <[email protected]> Signed-off-by: Bryce Mecum <[email protected]>

… files (apache#45448) ### Rationale for this change Meson introduced its own formatting tool back in release 1.5.0. This helps enforce consistency in the configuration files and reduce unnecessary diffs ### What changes are included in this PR? Added a pre-commit hook for Meson format and ran it against Meson files currently in the repo ### Are these changes tested? N/A ### Are there any user-facing changes? No * GitHub Issue: apache#45447 Authored-by: Will Ayd <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>

…45458) ### Rationale for this change See apache#45451. This adds out of the box compatibility with the [Grpc.Net.ClientFactory](https://learn.microsoft.com/en-us/aspnet/core/grpc/clientfactory?view=aspnetcore-9.0), library, which is fairly standardized for users making gRPC requests in .NET web applications. ### What changes are included in this PR? Added a new constructor to `FlightClient` that accepts a `CallInvoker` instance. `public FlightClient(CallInvoker callInvoker)` ### Are these changes tested? Yes, added a unit test to resolve an instance of the `FlightClient` using the `Grpc.Net.ClientFactory` integration and made a request with it. ### Are there any user-facing changes? Yes, a new overload constructor of `FlightClient` was added. * GitHub Issue: apache#45451 Authored-by: Robert Cao <[email protected]> Signed-off-by: Curt Hagenlocher <[email protected]>

### Rationale for this change [Table::ValidateFull](https://arrow.apache.org/docs/cpp/api/table.html#_CPPv4NK5arrow5Table12ValidateFullEv) available in the C++ API. But, GLib doesn't support that method yet. ### What changes are included in this PR? This PR adds a full validation method to the table class. ### Are these changes tested? Yes. ### Are there any user-facing changes? Yes. * GitHub Issue: apache#44762 Lead-authored-by: Hiroyuki Sato <[email protected]> Co-authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>

…n row table (apache#45473) ### Rationale for this change The failure reported in apache#45393 seems to be caused by a careless parentheses typo introduced in apache#45336: https://github.com/apache/arrow/blob/e32f56b478171fc4b53dc2042c4cf5d37c97e351/cpp/src/arrow/compute/row/encode_internal.cc#L281-L282 And unfortunately our `Grouper` UT doesn't have cases covering this particular code path (the questioning code path is only triggered in `Grouper` with very restrictive conditions: the row table is fixed-length, a 32-bit key is encoded after some other keys). ### What changes are included in this PR? An UT to reproduce the issue and the fix. ### Are these changes tested? UT included. ### Are there any user-facing changes? None. * GitHub Issue: apache#45393 Authored-by: Rossi Sun <[email protected]> Signed-off-by: Rossi Sun <[email protected]>

… enforce overflow avoidance

github-actions bot added awaiting review Component: C++ labels Jan 13, 2025

zanmato1984 commented Jan 13, 2025

View reviewed changes

github-actions bot added awaiting committer review and removed awaiting review labels Jan 13, 2025

hiroyuki-sato and others added 25 commits January 27, 2025 12:02

raulcd and others added 13 commits February 5, 2025 16:03

zanmato1984 force-pushed the more-overflow-safe-swiss-table branch from 53c8064 to b4ba660 Compare February 10, 2025 09:24

zanmato1984 added 5 commits February 10, 2025 17:25

More overflow safe swiss table (#21)

ecf7d6e

Fix conflicts

130a2df

Replace more immediate numbers

3ffd9e0

Remove useless cast

3068889

Change block bits/bytes to int, and use function to get block addr to…

301b767

… enforce overflow avoidance

zanmato1984 force-pushed the more-overflow-safe-swiss-table branch from b4ba660 to 301b767 Compare February 10, 2025 09:26

zanmato1984 closed this Feb 10, 2025

github-actions bot added Component: Python Component: GLib Component: Documentation Component: C# Component: JavaScript Component: Ruby Component: FlightRPC Component: Gandiva Component: Parquet labels Feb 10, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

More overflow safe swiss table (#21) #22

More overflow safe swiss table (#21) #22

zanmato1984 commented Jan 13, 2025

zanmato1984 Jan 13, 2025

More overflow safe swiss table (#21) #22

More overflow safe swiss table (#21) #22

Conversation

zanmato1984 commented Jan 13, 2025

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

zanmato1984 Jan 13, 2025

Choose a reason for hiding this comment