Add speed tracking to Odrive #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tested on the testboard. The speed check is working as expected. But sofar the check if it is tuned off is ot working. |
|
The function was already implementet. I added the documentation to the docs |
Johannes-Thiel
added
the
documentation
JensOgorek
reviewed
Oct 31, 2024
main/modules/odrive_motor.cpp
Outdated
| @@ -170,4 +170,4 @@ double ODriveMotor::get_speed() { | |||
|
|
|||
| void ODriveMotor::speed(const double speed, const double acceleration) { | |||
| this->speed(static_cast<float>(speed)); | |||
| } | |||
There was a problem hiding this comment.
It seems like the empty line slipped here
JensOgorek
approved these changes
Oct 31, 2024
falkoschindler
approved these changes
Nov 3, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A user wants to track the speed of the rotation of the Motor #79. To do this the Encoder estimate register is read. When the
this->properties["speed_check"] = std::make_shared<BooleanVariable>();propertie is set to true, the speed will be checked on every loop.