Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add speed tracking to Odrive #84

Merged
merged 7 commits into from
Nov 3, 2024
Merged

Add speed tracking to Odrive #84

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
9b9603f
add speed check to step function
Johannes-Thiel Oct 31, 2024
23bd64d
add dokumentation
Johannes-Thiel Oct 31, 2024
013d1e0
change call name
Johannes-Thiel Oct 31, 2024
00c87ca
cleanup
Johannes-Thiel Oct 31, 2024
d1def16
clean up docs
Johannes-Thiel Oct 31, 2024
b0fa5e3
code review: returned the empty line
JensOgorek Oct 31, 2024
8f85b36
improve order for consistency
falkoschindler Nov 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/module_reference.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,6 +289,7 @@ The `version` parameter is an optional integer indicating the patch number of th
| `motor.axis_state` | State of the motor axis | `int` |
| `motor.axis_error` | Error code of the axis | `int` |
| `motor.motor_error` | Motor error flat (requires version 0.5.6) | `int` |
| `motor.speed` | Current speed (m/s) | `float` |

| Methods | Description | Arguments |
| ------------------------------ | -------------------------------------- | ---------------- |
Expand Down
2 changes: 1 addition & 1 deletion main/modules/odrive_motor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,4 +170,4 @@ double ODriveMotor::get_speed() {

void ODriveMotor::speed(const double speed, const double acceleration) {
this->speed(static_cast<float>(speed));
}
Copy link
Contributor

@JensOgorek JensOgorek Oct 31, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like the empty line slipped here

}