Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bluetooth: controller: Scan Request Notifications #16

Closed
wants to merge 1 commit into from
Closed

Bluetooth: controller: Scan Request Notifications #16

wants to merge 1 commit into from

Conversation

cvinayak
Copy link
Contributor

@cvinayak cvinayak commented Apr 29, 2017 •
edited by galak
Loading

Implementation of Scan Request Notifications

This change is Reviewable

@cvinayak cvinayak force-pushed the github_bluetooth_scan_req_notify branch from 81f1dd1 to 5d32acb Compare April 29, 2017 14:22
@jhedberg jhedberg requested a review from Vudentz May 1, 2017 14:05
@jhedberg jhedberg assigned carlescufi and unassigned jhedberg May 2, 2017
@jhedberg jhedberg requested review from jhedberg and carlescufi May 2, 2017 05:32
carlescufi
carlescufi previously approved these changes May 2, 2017
View reviewed changes
@cvinayak cvinayak force-pushed the github_bluetooth_scan_req_notify branch from 5d32acb to a1bbfc5 Compare May 2, 2017 11:47
@cvinayak cvinayak changed the base branch from bluetooth to master May 2, 2017 13:34
@cvinayak cvinayak force-pushed the github_bluetooth_scan_req_notify branch from a1bbfc5 to b6fc091 Compare May 3, 2017 13:54
rsalveti pushed a commit to rsalveti/zephyr that referenced this pull request May 3, 2017
@galak
gpio: stm32: Use atomic set/reset in stm32_gpio_set()
632a07d 
The current implementation of stm32_gpio_set() uses the GPIO output data
register to change the state of individual GPIOs. The generated
assembler needs at least 3 instructions: load / modify / store.

This opens a small race window, for example if a thread and an
interrupt both try to change the state of the same GPIO bank.

Use the GPIO bit set/reset register to perform the atomic change without
locking.

This also has the benefit of a more optimised implementation, which can
be useful for GPIO-intensive work. Compare the new version:

08000c98 <stm32_gpio_set>:
 8000c98:       f001 010f       and.w   r1, r1, zephyrproject-rtos#15
 8000c9c:       2301            movs    r3, zephyrproject-rtos#1
 8000c9e:       b902            cbnz    r2, 8000ca2 <stm32_gpio_set+0xa>
 8000ca0:       3110            adds    r1, zephyrproject-rtos#16
 8000ca2:       408b            lsls    r3, r1
 8000ca4:       6183            str     r3, [r0, zephyrproject-rtos#24]
 8000ca6:       2000            movs    r0, #0
 8000ca8:       4770            bx      lr

and the old one:

08000c98 <stm32_gpio_set>:
 8000c98:       2301            movs    r3, zephyrproject-rtos#1
 8000c9a:       f001 010f       and.w   r1, r1, zephyrproject-rtos#15
 8000c9e:       fa03 f101       lsl.w   r1, r3, r1
 8000ca2:       6943            ldr     r3, [r0, zephyrproject-rtos#20]
 8000ca4:       b10a            cbz     r2, 8000caa <stm32_gpio_set+0x12>
 8000ca6:       4319            orrs    r1, r3
 8000ca8:       e001            b.n     8000cae <stm32_gpio_set+0x16>
 8000caa:       ea23 0101       bic.w   r1, r3, r1
 8000cae:       6141            str     r1, [r0, zephyrproject-rtos#20]
 8000cb0:       2000            movs    r0, #0
 8000cb2:       4770            bx      lr

Change-Id: Ie5800d1c345016028d1b9a099f5d74cac35f592a
Signed-off-by: Florian Vaussard <[email protected]>
@cvinayak cvinayak force-pushed the github_bluetooth_scan_req_notify branch 2 times, most recently from 29865c2 to d8f70ad Compare May 4, 2017 18:34
carlescufi
carlescufi previously approved these changes May 5, 2017
View reviewed changes
@cvinayak
Bluetooth: controller: Scan Request Notifications
a8e1d1b 
Implement the framework for LE Scan Request Received Event.
The feature is available under the Controller's advanced
features and will be selected implcitly when Bluetooth v5.0
LE Advertising Extensions feature is implemented.

Jira: ZEP-2073

Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
@cvinayak cvinayak force-pushed the github_bluetooth_scan_req_notify branch from 1663fbf to a8e1d1b Compare May 5, 2017 10:45
@cvinayak cvinayak closed this May 5, 2017
This was referenced Sep 23, 2017
Closed
Closed
nagineni pushed a commit to nagineni/zephyr that referenced this pull request Nov 20, 2017
@poussa
Merge pull request zephyrproject-rtos#16 from grgustaf/gpio-not-pwm
0685c4e 
[GPIO] Use GPIO driver, not PWM driver, to configure GPIOs
@mike-scott mike-scott mentioned this pull request Jun 5, 2018
Closed
@wentongwu wentongwu mentioned this pull request May 11, 2019
Closed
@xiaoliang314 xiaoliang314 mentioned this pull request Jun 17, 2019
Closed
@xiaoliang314 xiaoliang314 mentioned this pull request Jun 26, 2019
Closed
Vudentz added a commit to Vudentz/zephyr that referenced this pull request Jun 18, 2020
@Vudentz
Bluetooth: shell: Add support for printing the write rate
6f1ab75 
This makes the gatt metrics also available for
gatt write-without-rsp-cb so it now prints the rate of each write:

uart:~$ gatt write-without-response-cb 1e ff 10 10
Write zephyrproject-rtos#1: 16 bytes (0 bps)
Write zephyrproject-rtos#2: 32 bytes (3445948416 bps)
Write zephyrproject-rtos#3: 48 bytes (2596929536 bps)
Write zephyrproject-rtos#4: 64 bytes (6400 bps)
Write zephyrproject-rtos#5: 80 bytes (8533 bps)
Write zephyrproject-rtos#6: 96 bytes (10666 bps)
Write zephyrproject-rtos#7: 112 bytes (8533 bps)
Write zephyrproject-rtos#8: 128 bytes (9955 bps)
Write zephyrproject-rtos#9: 144 bytes (11377 bps)
Write zephyrproject-rtos#10: 160 bytes (7680 bps)
Write zephyrproject-rtos#11: 176 bytes (8533 bps)
Write zephyrproject-rtos#12: 192 bytes (9386 bps)
Write Complete (err 0)
Write zephyrproject-rtos#13: 208 bytes (8533 bps)
Write zephyrproject-rtos#14: 224 bytes (9244 bps)
Write zephyrproject-rtos#15: 240 bytes (9955 bps)
Write zephyrproject-rtos#16: 256 bytes (8000 bps)

Signed-off-by: Luiz Augusto von Dentz <[email protected]>
joerchan pushed a commit to joerchan/zephyr that referenced this pull request Jun 18, 2020
@Vudentz @joerchan
Bluetooth: shell: Add support for printing the write rate
99585a6 
This makes the gatt metrics also available for
gatt write-without-rsp-cb so it now prints the rate of each write:

uart:~$ gatt write-without-response-cb 1e ff 10 10
Write zephyrproject-rtos#1: 16 bytes (0 bps)
Write zephyrproject-rtos#2: 32 bytes (3445948416 bps)
Write zephyrproject-rtos#3: 48 bytes (2596929536 bps)
Write zephyrproject-rtos#4: 64 bytes (6400 bps)
Write zephyrproject-rtos#5: 80 bytes (8533 bps)
Write zephyrproject-rtos#6: 96 bytes (10666 bps)
Write zephyrproject-rtos#7: 112 bytes (8533 bps)
Write zephyrproject-rtos#8: 128 bytes (9955 bps)
Write zephyrproject-rtos#9: 144 bytes (11377 bps)
Write zephyrproject-rtos#10: 160 bytes (7680 bps)
Write zephyrproject-rtos#11: 176 bytes (8533 bps)
Write zephyrproject-rtos#12: 192 bytes (9386 bps)
Write Complete (err 0)
Write zephyrproject-rtos#13: 208 bytes (8533 bps)
Write zephyrproject-rtos#14: 224 bytes (9244 bps)
Write zephyrproject-rtos#15: 240 bytes (9955 bps)
Write zephyrproject-rtos#16: 256 bytes (8000 bps)

Signed-off-by: Luiz Augusto von Dentz <[email protected]>
Vudentz added a commit to Vudentz/zephyr that referenced this pull request Jun 18, 2020
@Vudentz
Bluetooth: shell: Add support for printing the write rate
9a46918 
This makes the gatt metrics also available for
gatt write-without-rsp-cb so it now prints the rate of each write:

uart:~$ gatt write-without-response-cb 1e ff 10 10
Write zephyrproject-rtos#1: 16 bytes (0 bps)
Write zephyrproject-rtos#2: 32 bytes (3445948416 bps)
Write zephyrproject-rtos#3: 48 bytes (2596929536 bps)
Write zephyrproject-rtos#4: 64 bytes (6400 bps)
Write zephyrproject-rtos#5: 80 bytes (8533 bps)
Write zephyrproject-rtos#6: 96 bytes (10666 bps)
Write zephyrproject-rtos#7: 112 bytes (8533 bps)
Write zephyrproject-rtos#8: 128 bytes (9955 bps)
Write zephyrproject-rtos#9: 144 bytes (11377 bps)
Write zephyrproject-rtos#10: 160 bytes (7680 bps)
Write zephyrproject-rtos#11: 176 bytes (8533 bps)
Write zephyrproject-rtos#12: 192 bytes (9386 bps)
Write Complete (err 0)
Write zephyrproject-rtos#13: 208 bytes (8533 bps)
Write zephyrproject-rtos#14: 224 bytes (9244 bps)
Write zephyrproject-rtos#15: 240 bytes (9955 bps)
Write zephyrproject-rtos#16: 256 bytes (8000 bps)

Signed-off-by: Luiz Augusto von Dentz <[email protected]>
carlescufi pushed a commit that referenced this pull request Jun 18, 2020
@Vudentz @carlescufi
Bluetooth: shell: Add support for printing the write rate
0742a45 
This makes the gatt metrics also available for
gatt write-without-rsp-cb so it now prints the rate of each write:

uart:~$ gatt write-without-response-cb 1e ff 10 10
Write #1: 16 bytes (0 bps)
Write #2: 32 bytes (3445948416 bps)
Write #3: 48 bytes (2596929536 bps)
Write #4: 64 bytes (6400 bps)
Write #5: 80 bytes (8533 bps)
Write #6: 96 bytes (10666 bps)
Write #7: 112 bytes (8533 bps)
Write #8: 128 bytes (9955 bps)
Write #9: 144 bytes (11377 bps)
Write #10: 160 bytes (7680 bps)
Write #11: 176 bytes (8533 bps)
Write #12: 192 bytes (9386 bps)
Write Complete (err 0)
Write #13: 208 bytes (8533 bps)
Write #14: 224 bytes (9244 bps)
Write #15: 240 bytes (9955 bps)
Write #16: 256 bytes (8000 bps)

Signed-off-by: Luiz Augusto von Dentz <[email protected]>
Vudentz added a commit to Vudentz/zephyr that referenced this pull request Jun 24, 2020
@Vudentz
Bluetooth: shell: Add support for printing the write rate
f3f6213 
This makes the gatt metrics also available for
gatt write-without-rsp-cb so it now prints the rate of each write:

uart:~$ gatt write-without-response-cb 1e ff 10 10
Write zephyrproject-rtos#1: 16 bytes (0 bps)
Write zephyrproject-rtos#2: 32 bytes (3445948416 bps)
Write zephyrproject-rtos#3: 48 bytes (2596929536 bps)
Write zephyrproject-rtos#4: 64 bytes (6400 bps)
Write zephyrproject-rtos#5: 80 bytes (8533 bps)
Write zephyrproject-rtos#6: 96 bytes (10666 bps)
Write zephyrproject-rtos#7: 112 bytes (8533 bps)
Write zephyrproject-rtos#8: 128 bytes (9955 bps)
Write zephyrproject-rtos#9: 144 bytes (11377 bps)
Write zephyrproject-rtos#10: 160 bytes (7680 bps)
Write zephyrproject-rtos#11: 176 bytes (8533 bps)
Write zephyrproject-rtos#12: 192 bytes (9386 bps)
Write Complete (err 0)
Write zephyrproject-rtos#13: 208 bytes (8533 bps)
Write zephyrproject-rtos#14: 224 bytes (9244 bps)
Write zephyrproject-rtos#15: 240 bytes (9955 bps)
Write zephyrproject-rtos#16: 256 bytes (8000 bps)

Signed-off-by: Luiz Augusto von Dentz <[email protected]>
@anchao anchao mentioned this pull request Jul 30, 2020
Merged
nashif pushed a commit that referenced this pull request Nov 16, 2020
@Vudentz @nashif
Bluetooth: shell: Add support for printing the write rate
54f1a4a 
This makes the gatt metrics also available for
gatt write-without-rsp-cb so it now prints the rate of each write:

uart:~$ gatt write-without-response-cb 1e ff 10 10
Write #1: 16 bytes (0 bps)
Write #2: 32 bytes (3445948416 bps)
Write #3: 48 bytes (2596929536 bps)
Write #4: 64 bytes (6400 bps)
Write #5: 80 bytes (8533 bps)
Write #6: 96 bytes (10666 bps)
Write #7: 112 bytes (8533 bps)
Write #8: 128 bytes (9955 bps)
Write #9: 144 bytes (11377 bps)
Write #10: 160 bytes (7680 bps)
Write #11: 176 bytes (8533 bps)
Write #12: 192 bytes (9386 bps)
Write Complete (err 0)
Write #13: 208 bytes (8533 bps)
Write #14: 224 bytes (9244 bps)
Write #15: 240 bytes (9955 bps)
Write #16: 256 bytes (8000 bps)

Signed-off-by: Luiz Augusto von Dentz <[email protected]>
fkan-ec pushed a commit to fkan-ec/zephyr that referenced this pull request Jan 17, 2022
@onkark911
Merge pull request zephyrproject-rtos#16 from ec-platform-sw/hotfix_v…
4ecb143 
…1.1.6

Hotfix v1.1.6
@RafaelLeeImg RafaelLeeImg mentioned this pull request Jan 19, 2022
Closed
@piotrParf piotrParf mentioned this pull request Feb 9, 2022
Closed
@stephanosio stephanosio mentioned this pull request May 4, 2022
Open
@andyross andyross mentioned this pull request Jun 30, 2022
Merged
NickolasLapp pushed a commit to NickolasLapp/zephyr that referenced this pull request Oct 19, 2022
@kevin-whisper
Use radio scratch area when doing soft encryption for tx (zephyrproje…
bfbd776 
…ct-rtos#16)
@sjanc sjanc mentioned this pull request May 16, 2023
Closed
LukaszMrugala pushed a commit to LukaszMrugala/zephyr that referenced this pull request Jul 3, 2024
@cjgraydon
tag_main.sh and pr_commit.sh tweaks (zephyrproject-rtos#16)
c00fbbf 
- Pipe the tag-related repo refresh to /dev/null. It's just scary noise
that makes it look like the tags are being deleted. Nobody needs to see
that.

- Add some comments to the repo refresh in the clone_repo function to
help see what's happening there.

Signed-off-by: Connor Graydon <[email protected]>
cdesjardins pushed a commit to Arch-Embedded/zephyr that referenced this pull request Oct 22, 2024
Merged in BUG/UVSMART-screen-glitches (pull request zephyrproject-rto…
b334a0b 
…s#16)

Make SPI work with DMA enabled, I/O buffers must be non-cached.

Approved-by: Fabian van den IJssel
Approved-by: Bas van Loon
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlescufi carlescufi carlescufi left review comments

@Vudentz Vudentz Awaiting requested review from Vudentz

@jhedberg jhedberg Awaiting requested review from jhedberg

Assignees

@carlescufi carlescufi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cvinayak @carlescufi @jhedberg