Fix to check for missing obs in SaveObsDiag #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danholdaway
added a commit
to danholdaway/swell
that referenced
this pull request
Apr 19, 2024
* develop: Resolve pandas warnings (GEOS-ESM#322) Add atmospheric 3DVar case (GEOS-ESM#302) Update to Skylab7 Modules - Part 1 (SLES12) (GEOS-ESM#319) Towards ensemble hofx support (GEOS-ESM#298) Change Jedi Log plot and turn off Jb evaluation (GEOS-ESM#310) passed benchmark change (GEOS-ESM#303) Use `EXPLICIT_DIFFUSION` as Static Background for `geos_marine` (GEOS-ESM#301) Fix to check for missing obs in SaveObsDiag (GEOS-ESM#299) Cloning GEOS_mksi instead for GSI channel records (GEOS-ESM#297) Update modules and keep static files in shared locations (GEOS-ESM#296) Addressing missing observations (GEOS-ESM#286)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds
check_obsfunction toSaveObsDiagto make sure code downstream isn't trying to execute if obs is missing. Also removed some logic added earlier ineva_observations.pybecause thecheck_obsfunction takes care of it now.Added
sst_ostiaback to geos-ocean hofx swell run and everything seems to be working as expectedCloses #295
(Thanks for finding this bug @Dooruk!)