Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modifying Airs Aqua passed benchmark #303

Merged
merged 1 commit into from
Mar 11, 2024
Merged

Modifying Airs Aqua passed benchmark #303

merged 1 commit into from
Mar 11, 2024

Conversation

asewnath
Copy link
Collaborator

@asewnath asewnath commented Mar 8, 2024

Description

Passed benchmark change to fix tier testing

@asewnath asewnath requested a review from Dooruk March 8, 2024 23:22
Copy link
Contributor

@rtodling rtodling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks quite reasonable to me.

@Dooruk
Copy link
Collaborator

Dooruk commented Mar 11, 2024

Thanks @asewnath. Just FYI, there is an issue with eva_log and 3dvar output so tier1 test will still fail for 3dvar. I identified the issue (instead of gradient reduction the residual norm is displayed) but I will fix it on another PR.

@Dooruk Dooruk merged commit c701e96 into develop Mar 11, 2024
10 of 11 checks passed
@Dooruk Dooruk deleted the bugfix/ufo_testing branch March 11, 2024 01:37
danholdaway added a commit to danholdaway/swell that referenced this pull request Apr 19, 2024
* develop:
  Resolve pandas warnings (GEOS-ESM#322)
  Add atmospheric 3DVar case (GEOS-ESM#302)
  Update to Skylab7 Modules - Part 1 (SLES12) (GEOS-ESM#319)
  Towards ensemble hofx support (GEOS-ESM#298)
  Change Jedi Log plot and turn off Jb evaluation (GEOS-ESM#310)
  passed benchmark change (GEOS-ESM#303)
  Use `EXPLICIT_DIFFUSION` as Static Background for `geos_marine` (GEOS-ESM#301)
  Fix to check for missing obs in SaveObsDiag (GEOS-ESM#299)
  Cloning GEOS_mksi instead for GSI channel records (GEOS-ESM#297)
  Update modules and keep static files in shared locations (GEOS-ESM#296)
  Addressing missing observations (GEOS-ESM#286)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants