Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve pandas warnings #322

Merged
merged 3 commits into from
Apr 17, 2024
Merged

Resolve pandas warnings #322

merged 3 commits into from
Apr 17, 2024

Conversation

asewnath
Copy link
Collaborator

Description

Fixes to observing system record processing to resolve pandas warnings found in logs.

Resolves #320

@asewnath asewnath requested a review from Dooruk April 17, 2024 17:32
Dooruk
Dooruk approved these changes Apr 17, 2024
View reviewed changes
Copy link
Collaborator

@Dooruk Dooruk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @asewnath for making these changes, warnings are gone.

And sorry, had to hijack your PR to fix a bug in develop 🥲

@Dooruk Dooruk merged commit cebcb49 into develop Apr 17, 2024
8 checks passed
@Dooruk Dooruk deleted the feature/pandas_warning branch April 17, 2024 18:23
@asewnath
Copy link
Collaborator Author

Thanks @asewnath for making these changes, warnings are gone.

And sorry, had to hijack your PR to fix a bug in develop 🥲

LOL

danholdaway added a commit to danholdaway/swell that referenced this pull request Apr 19, 2024
@danholdaway
Merge branch 'develop' into feature/refactor_prep_config
a566007 
* develop:
  Resolve pandas warnings (GEOS-ESM#322)
  Add atmospheric 3DVar case (GEOS-ESM#302)
  Update to Skylab7 Modules - Part 1 (SLES12) (GEOS-ESM#319)
  Towards ensemble hofx support (GEOS-ESM#298)
  Change Jedi Log plot and turn off Jb evaluation (GEOS-ESM#310)
  passed benchmark change (GEOS-ESM#303)
  Use `EXPLICIT_DIFFUSION` as Static Background for `geos_marine` (GEOS-ESM#301)
  Fix to check for missing obs in SaveObsDiag (GEOS-ESM#299)
  Cloning GEOS_mksi instead for GSI channel records (GEOS-ESM#297)
  Update modules and keep static files in shared locations (GEOS-ESM#296)
  Addressing missing observations (GEOS-ESM#286)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dooruk Dooruk Dooruk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Observing system records processing warning
2 participants
@asewnath @Dooruk