Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

7715 signed urls for external tools #8850

Merged
merged 675 commits into from
Jul 21, 2022
Merged

7715 signed urls for external tools #8850

merged 675 commits into from
Jul 21, 2022

Conversation

qqmyers
Copy link
Member

@qqmyers qqmyers commented Jul 20, 2022

Some cleanup and using the util methods to read JsonObject/Arrays. Also added some fine logging for debug,

The two things I saw that I think are bugs are

  • using JsonString.toString() instead of JsonString.getString() - if I recall the former puts quotes around all of the strings, whereas getString gets the raw value (if I've got that mixed up, the logging statements should make it clear).
  • an if(redirect=true) that needed to use == - not sure if it was something that was getting triggered in your tests or not.

I also merged with the latest develop branch. If you don't want that, you can cherry pick 1b31e6c by itself.

pkiraly and others added 30 commits April 29, 2022 12:25
@pkiraly
IQSS#8667 fix null pointer exception
5642fb7
@sekmiller
IQSS#8669 add bind to doc ready
88bbad8
@sekmiller
IQSS#8456 fix updates on delete GB, template
7cb4cbd
@qqmyers
add ToDos re more efficient code
cbe1327
@kcondon
Merge pull request IQSS#8601 from GlobalDataverseCommunityConsortium/…
7477e7a 
…IQSS/8595-CVV_solr_updates

IQSS/8595 - update existing schema and code to make all cvv files multival in solr
@kcondon
Merge pull request IQSS#8651 from poikilotherm/8650-rtd-preview
e752171 
8650 ReadTheDocs based HTML guides preview
@kcondon
Merge pull request IQSS#8666 from konradperlowski/3189_admin_role_des…
c47cf82 
…cription

Change description of admin role IQSS#3189
@sekmiller
Merge branch 'develop' into 8456-upgrade-primefaces
175fa7b
@kcondon
Merge pull request IQSS#8652 from IQSS/8456-upgrade-primefaces
6b1b0cb 
8456 upgrade primefaces
@poikilotherm
Merge branch 'develop' into 8642-guides-permalinks
3e6eaa2
@pdurbin
s/for this storages/for this storage's/
dac9702
@pdurbin
add Style Guide to list of guides
7779c0a
@kcondon
Merge pull request IQSS#8662 from IQSS/ds54-csp
666ccb0 
Prevent non-widgets from being embedded in iframes
@sekmiller
Merge branch 'develop' into 8669-tooltips-broken-on-add-data
c63971e
@kcondon
Merge pull request IQSS#8649 from IQSS/style-folder
549cc9b 
add Style Guide to list of guides
@kcondon
Merge pull request IQSS#8648 from IQSS/typo-storages
10dc16f 
s/for this storages/for this storage's/
@kcondon
Merge pull request IQSS#8620 from j-n-c/8619-install-prerequisites-do…
50f093b 
…c-fixes

IQSS#8619 installation prerequisites documentation fixes
@pdurbin
Merge branch 'develop' into 8617-Header-branding-customization IQSS#8617
989baad 


Conflicts:
doc/sphinx-guides/source/installation/config.rst
(new dvPageBlocks image at bottom)
@sekmiller
IQSS#8669 remove defer from req'd scripts
3a93930
@sekmiller
Merge branch 'develop' into 8669-tooltips-broken-on-add-data
a98219c
@kcondon
Merge pull request IQSS#8670 from IQSS/8669-tooltips-broken-on-add-data
5d1eb8a 
IQSS#8669 add bind to doc ready
@pdurbin
wordsmithing, added source draw.io file IQSS#8617
6170830 
Hopefully this wording is considered an improvement!

I also looked into the installation name and how it interacts
with :InstallationName and :SystemEmail.
@ErykKul
Merge branch 'IQSS:develop' into 7492_muting_notifications
9c2d8ec
@ErykKul
always muted notifications are no longer shown in notification muttin…
efb9951 
…g settings
@ErykKul
bumped flyway script filename according to the current release
6b4bd0f
@ErykKul
bumped flyway script filename according to the current release
fde4989
@ErykKul
Merge branch 'IQSS:develop' into 8623_solr_index_vocab
9d96b3d
@kcondon
Merge pull request IQSS#8638 from j-n-c/8617-Header-branding-customiz…
700e82c 
…ation

IQSS#8617 Branding customization docs refactoring
@sekmiller
IQSS#8663 add content type header to api instructions for create DS
2d26a43
@sekmiller
IQSS#8663 add release note
c21895b
kcondon and others added 28 commits June 13, 2022 15:49
@kcondon
Merge pull request IQSS#8797 from IQSS/8794_v5.11
4686066 
8794 v5.11
@FlorianRhiem
Add SampleDB to the list of integrations
fcfcbdb
@kcondon
Merge pull request IQSS#8799 from OdumInstitute/8790_correct_default_…
4eb7683 
…license_example

setting default license doesn't require edit-license.json
@kcondon
Merge pull request IQSS#8804 from FlorianRhiem/develop
37e1c5f 
Documentation: Add SampleDB to the list of integrations
@haarli
Merge branch 'IQSS:develop' into IQSS/8757_file_restriction_with_publ…
dcc4128 
…icInstall
@haarli
Merge branch 'IQSS:develop' into IQSS/8726_better_http_range_support
ed31173
@kcondon
Merge pull request IQSS#8727 from MPDL/IQSS/8726_better_http_range_su…
991a39d 
…pport

Iqss/8726 better HTTP range request support
@kcondon
Merge pull request IQSS#8758 from MPDL/IQSS/8757_file_restriction_wit…
b88f0df 
…h_publicInstall

Iqss/8757 file restriction with public install
@qqmyers
Merge remote-tracking branch 'IQSS/develop' into GDCC/8604-improve_ar…
9744ff1 
…chiver_error_handling
@qqmyers
Merge remote-tracking branch 'IQSS/develop' into GDCC/8768-OAI-ORE_fi…
e0d3fbc 
…le_content_updates
@dependabot
Bump jbcrypt from 0.3m to 0.4
8704dfb 
Bumps [jbcrypt](https://github.com/djmdjm/jBCrypt) from 0.3m to 0.4.
- [Release notes](https://github.com/djmdjm/jBCrypt/releases)
- [Commits](https://github.com/djmdjm/jBCrypt/commits)

---
updated-dependencies:
- dependency-name: org.mindrot:jbcrypt
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@sekmiller
IQSS#8735 fix edit fields
69bb7b3
@sekmiller
Merge branch 'develop' into 8127-citation-field-improvements
80c34de
@pdurbin
Merge branch 'develop' into 7808-support-protocol-http IQSS#7808
fc19d40
@kcondon
Merge pull request IQSS#8665 from Esteban-Mtz/7808-support-protocol-http
c4e4910 
Fix support protocol http import OAI_DC
@kcondon
Merge pull request IQSS#8708 from IQSS/8127-citation-field-improvements
dd7ca31 
8127 citation field improvements
@qqmyers
Merge remote-tracking branch 'IQSS/develop' into GDCC/8604-improve_ar…
3d01b13 
…chiver_error_handling
@kcondon
Merge pull request IQSS#8833 from IQSS/dependabot/maven/org.mindrot-j…
09506fe 
…bcrypt-0.4

Bump jbcrypt from 0.3m to 0.4
@qqmyers
Merge remote-tracking branch 'IQSS/develop' into GDCC/8768-OAI-ORE_fi…
3d8e76f 
…le_content_updates
@qqmyers
Do ToDo per review
b3292fa
@kcondon
Merge pull request IQSS#8837 from IQSS/8735-new-mdbs-not-shown-in-pri…
c638e10 
…or-templates-on-edit

IQSS#8735 fix edit fields
@kcondon
Merge pull request IQSS#8761 from adaybujeda/8759-add-computational-w…
ba0c2ac 
…orflow-file-types

File Recognition - Added computational workflow file types
@abujeda
BagIt Support - Improved ignored files for BagIt handler
0f4e6f1
@kcondon
Merge pull request IQSS#8770 from GlobalDataverseCommunityConsortium/…
328ea80 
…GDCC/8768-OAI-ORE_file_content_updates

HDC 3A: Update OAI-ORE contents to add collections, PID URL, brandname
@kcondon
Merge pull request IQSS#8755 from adaybujeda/8754-bagit-improve-ignor…
86f69bd 
…ed-files

BagIt Support - Improved ignored files for BagIt handler
@kcondon
Merge pull request IQSS#8612 from GlobalDataverseCommunityConsortium/…
567e506 
…GDCC/8604-improve_archiver_error_handling

GDCC/8604 Improve archiver error handling
@qqmyers
tweak json read/write, getString, cleanup, logging
1b31e6c
@qqmyers
Merge remote-tracking branch 'IQSS/develop' into 7715-signed-urls-for…
2c90139 
…-external-tools
@rtreacy rtreacy merged commit 66355b0 into IQSS:7715-signed-urls-for-external-tools Jul 21, 2022
@pdurbin pdurbin added this to the 5.12 milestone Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.12
Development

Successfully merging this pull request may close these issues.