Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update launch.json handling to support "listen" and "connect" #10437

Closed
int19h opened this issue Mar 4, 2020 · 0 comments
Closed

Update launch.json handling to support "listen" and "connect" #10437

int19h opened this issue Mar 4, 2020 · 0 comments
Assignees
@int19h
Labels
feature-request Request for new features or functionality

Comments

@int19h
Copy link

int19h commented Mar 4, 2020

As described here:
#10379 (comment)

This affects the debug adapter factory. Currently, it looks at "pid" to determine whether an "attach" configuration should spawn the adapter, or connect to it using the specified "host" and "port". The first change needed here is to also spawn the debug adapter if it sees "listen". Secondly, when connecting using a socket, it needs to look for "host" and "port" inside "connect" first, and only then fall back to top-level properties.
@int19h int19h added feature-request Request for new features or functionality triage-needed Needs assignment to the proper sub-team needs PR and removed triage-needed Needs assignment to the proper sub-team labels Mar 4, 2020
@int19h int19h self-assigned this Mar 5, 2020
int19h added a commit to int19h/vscode-python that referenced this issue Mar 11, 2020
@int19h
Fix microsoft#10437: Update launch.json handling to support "listen" …
7654817 
…and "connect"
int19h added a commit to int19h/vscode-python that referenced this issue Mar 11, 2020
@int19h
Fix microsoft#10437: Update launch.json handling to support "listen" …
6427789 
…and "connect"
int19h added a commit to int19h/vscode-python that referenced this issue Mar 11, 2020
@int19h
Fix microsoft#10437: Update launch.json handling to support "listen" …
8426155 
…and "connect"
int19h added a commit to int19h/vscode-python that referenced this issue Mar 11, 2020
@int19h
Fix microsoft#10437: Update launch.json handling to support "listen" …
557e3a0 
…and "connect"
@int19h int19h closed this as completed in 0aa6088 Mar 12, 2020
@ghost ghost removed the needs PR label Mar 12, 2020
DonJayamanne added a commit that referenced this issue Mar 13, 2020
@DonJayamanne
Merge branch 'master' into ds/custom_editor
d3c4ad9 
* master:
  Fix flakey file system tests (#10541)
  Tweaks for gather (#10532)
  Fix #10437: Update launch.json handling to support "listen" and "connect" (#10517)
  Add conda support to nightly flake test (#10523)
  Rename datascience to datascience_modules (#10525)
  Clean up the extension activation code. (#10455)
  Allow escape and ctrl+U to clear the interactive window (#10513)
  Fix builtins so they don't interfere with our execution (#10511)
  Jupyter autocompletion will only show up on empty lines, (#10420)
  notify on missing kernel and interpreter with kernel (#10508)
karthiknadig pushed a commit to karthiknadig/vscode-python that referenced this issue Mar 18, 2020
@karthiknadig
Fix microsoft#10437: Update launch.json handling to support "listen" …
bcb8999 
…and "connect" (microsoft#10517)
karthiknadig added a commit that referenced this issue Mar 19, 2020
@karthiknadig
Fix #10437: Update launch.json handling to support "listen" and "conn…
9005608 
…ect" (#10517) (#10654)

Co-authored-by: Pavel Minaev <[email protected]>
@lock lock bot locked as resolved and limited conversation to collaborators Mar 21, 2020
karthiknadig added a commit that referenced this issue Mar 26, 2020
@karthiknadig @rchiodo
Merge release 2020.3 to master (#10797)
0ba42da 
* Davidkutu/port intellisense fix (#10531)

* Jupyter autocompletion will only show up on empty lines,
instead of appearing in functions.

* filter out magic commands instead of
ignoring all the jupyter intellisense.

* moved the new code to a function and created tests

* removed pressCtrlSpace function

* added comments

* update changelog and delete news file

* Rename datascience to datascience_modules (#10525) (#10528)

* Rename datascience to datascience_modules (#10525)

* Rename datascience to datascience_modules

* Change name to something even harder to get wrong

* Fix unit test failure for release

* Ensure local host only if connection not available (#10600) (#10644)

* Ensure local host only if connection not available

* Add news item

* Fix #10437: Update launch.json handling to support "listen" and "connect" (#10517) (#10654)

Co-authored-by: Pavel Minaev <[email protected]>

* Update version and change log (#10662)

* Update version and change log

* Fix flakey file system tests (#10541)

Co-authored-by: Rich Chiodo <[email protected]>

Co-authored-by: David Kutugata <[email protected]>
Co-authored-by: Rich Chiodo <[email protected]>
Co-authored-by: Pavel Minaev <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@int19h int19h

Labels
feature-request Request for new features or functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@int19h