-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate INA226 with PX4 #12673
Integrate INA226 with PX4 #12673
Conversation
@ItsTimmy After some advice here from you. We don't have any standalone docs on any power monitors/power modules - though we do have some as part of vehicle build logs and mentioning how to power a vehicle in the flight controller assembly quickstarts. So:
I'm guessing this might cover information like what controllers it can work with, whether it provides both voltage and current, or just voltage. What else it provides. Ratings for systems it can be used with etc etc (advice hoped for!)
|
|
65db731
to
bc0c416
Compare
bc0c416
to
5872c98
Compare
9ebed7e
to
894180c
Compare
Just a reminder ^^^ #12673 (comment) |
b7d4df0
to
344b19a
Compare
@hamishwillee Who should I talk to about documenting the capabilities of different hardware? |
Open question for anyone who has an idea: How should this module be started? Right now it must be started manually, with the command |
4620b9f
to
8dca43e
Compare
9f849c2
to
7188d47
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think some of the commented out code needs to be removed and then this is good to go in.
7188d47
to
25c6415
Compare
@julianoes I have removed the commented code. @dinomani has tested it in flight |
25c6415
to
e3a30fc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still think the overall battery/power architecture needs proper aggregation and configuration, but this is a good step forward for v5x.
* Publish I2C battery data as battery_status
Describe problem solved by the proposed pull request
Support for the INA226 I2C power monitor was added in #11755. This PR changes that driver to publish as a
battery_status
uORB topic instead of a separatepower_monitor
topic.Additional functionality added here:
-f
command line flag, as documented in the driver docs)rc.board_sensors
to start up driver automatically at bootTest data / coverage
These tests were conducted on both a Pixhawk 4 (using an adapter board) and on a prototype fmu-v5x board. Results were verified using
listener battery_status
and by checking the battery status in QGC.BAT(i)_N_CELLS
Also, @dinomani has tested this code in flight, and it has worked as expected.