Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preview .jfif images #477

Closed
ilfarpro opened this issue Mar 11, 2019 · 3 comments
Closed

Preview .jfif images #477

ilfarpro opened this issue Mar 11, 2019 · 3 comments

Comments

@ilfarpro
Copy link

Now .jfif images preview looks like this. Please add support of this type of images
{293C4E13-D7B6-47F5-985D-29A94D82B17D} png

@prakharb5
Copy link

Even now, QuickLook doesn't support JFIF formats. Please add this functionality.

@rabelux
Copy link
Member

rabelux commented Sep 22, 2020

Just did a quick research, seems like jfif is a sub-form of jpeg and should be able to be interpreted exactly the same as jpeg

@xupefei
Copy link
Member

xupefei commented Sep 24, 2020

I'll solve these formats request this weekend. The fix is actually very simple: add one string here: https://github.com/QL-Win/QuickLook/blob/master/QuickLook.Plugin/QuickLook.Plugin.ImageViewer/Plugin.cs#L37.

@rabelux rabelux added the in progress The dev is on it label Sep 24, 2020
@rabelux rabelux added fixed and removed in progress The dev is on it labels Sep 27, 2020
Jethro-Alter added a commit to Jethro-Alter/QuickLook that referenced this issue Dec 21, 2020
* Update Translations.config

* Update Translations.config

* Update Translations.config

* Create Privacy.md

* Rename Privacy.md to PRIVACY.md

* Update PRIVACY.md

* Update PRIVACY.md

* Fix QL-Win#579: search box changed in Windows 10 1909

* Fix QL-Win#579: also deal with non-English UIs

* don't bring existing window to the front

* Revert "Fix QL-Win#644: still use focusable window on Windows 7 and 8"

This reverts commit 452574e.

Revert "Fix QL-Win#644 step 1: correctly bring window back to top when clicked"

This reverts commit af608dc.

* Fix QL-Win#401: use the native image provider to render static GIFs

* Update Translations.config

Hungarian language added.

* Fix QL-Win#669: convert image to sRGB only when the original ColorSpace is RGB, sRGB, or scRGB

* Upgrade Magick.NET packages

* Fix QL-Win#669 again: stupid syntax mistake :(

* Bulk update NuGet packages

* Update Translations.config

Typo correction on line 61 and 69. Fixing slight translation mistakes and some words also replaced with more commonly used words.

* Support File Path longer than 260 (tweak needed: https://www.tenforums.com/tutorials/51704-enable-disable-win32-long-paths-windows-10-a.html)

* Add EXR to ImageViewer

* Add MXF to VideoViewer

* Decrease update checking frequency to monthly

* Fix QL-Win#715: add 1s timeout before any previewing request

* Fix QL-Win#711: adjust UI before loading any PDF page

* Fix QL-Win#729: add a config flag to hide the tray icon

* Fix QL-Win#731: use app folder for saving data in the portable mode

* Fix QL-Win#733: detect Markdown encoding

* Fix QL-Win#734: add AVIF format

* Update .appveyor.yml

* added german translation for newly added string

* fix a typo

* Fix QL-Win#744: Components are not correctly disposed upon exit

* Fix QL-Win#477: Add JFIF files

* Update bug_report.md

* typo

* Fix QL-Win#420, QL-Win#452, QL-Win#757: windows positioning for monitors with different DPIs

* Update Common to fix plugin resize

* Fix QL-Win#759: fix thumbnail orientation for some camera models

* Fix QL-Win#760, support CR3

* removed dup of ".asf" and added ".mka" for testing

Co-authored-by: Piteriuz <[email protected]>
Co-authored-by: Pengfei Xu <[email protected]>
Co-authored-by: Bobcruise <[email protected]>
Co-authored-by: davinhanif <[email protected]>
Co-authored-by: Alexander Raab <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants