Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The position of the launch window is always on the lower side in the high resolution. #757

Closed
Airloss opened this issue Oct 8, 2020 · 9 comments

Comments

@Airloss
Copy link

Airloss commented Oct 8, 2020

Describe the bug
In the high resolution screen (4K) with the zoom 150%, the launch window's position is always lower

To Reproduce
Steps to reproduce the behavior:

  1. Select a file
  2. Press the Spacebar
  3. See the view window is on a lower position.

Expected behavior
Hope the view window an appear on the center position or remeber the last position I adjust.

Desktop (please complete the following information):

  • OS Version: Windows 10 19042.546
  • QuickLook Version: 3.6.10 from Windows Store

Screenshots and Exception Log
Screenshot:
image

@xupefei
Copy link
Member

xupefei commented Oct 8, 2020

Do you use multiple monitors?

@Airloss
Copy link
Author

Airloss commented Oct 8, 2020

Do you use multiple monitors?

Yes

@xupefei
Copy link
Member

xupefei commented Oct 8, 2020

There's a known issue about window positioning when multiple monitors are used: #420 #452, I might able to look at it this weekend.

A possible workaround is to switch primary/secondary monitors.

@Airloss
Copy link
Author

Airloss commented Oct 8, 2020

There's a known issue about window positioning when multiple monitors are used: #420 #452, I might able to look at it this weekend.

A possible workaround is to switch primary/secondary monitors.

OK, Thank you😃

@xupefei
Copy link
Member

xupefei commented Oct 11, 2020

Could you try https://ci.appveyor.com/project/xupefei/quicklook/builds/35688242/artifacts and confirm the fix?

@Airloss
Copy link
Author

Airloss commented Oct 12, 2020

Could you try https://ci.appveyor.com/project/xupefei/quicklook/builds/35688242/artifacts and confirm the fix?

I try and it's wired that when I view a pdf, the windows top-bar is hidden as the follow picture, when I switch to another pdf the position has changed, but the code file is normal display.
In the old version I used the pdf view is also normal.
image
image
image
image

@TheSheepfolder
Copy link

Could you try https://ci.appveyor.com/project/xupefei/quicklook/builds/35688242/artifacts and confirm the fix?

Yep, the "fixed" build shows the same behaviour as Airloss just replied about on my setup as well.
Primary display 2736x1824, 200% scaling
Secondary display 1600x1200, 100% scaling

On the larger primary display, the QuickLook window cuts off at the top of the screen when it's displaying something large like a PDF or image preview, but it always works flawlessly on the smaller secondary display.
I also tested switching the primary/secondary displays around (and signed out+in again just in case), and even when I have the smaller display set to primary, it works great like before, but on the larger display (secondary) it still cuts off the top of the screen.

@xupefei
Copy link
Member

xupefei commented Oct 12, 2020

@Airloss
Copy link
Author

Airloss commented Oct 12, 2020

How about this one then: https://ci.appveyor.com/project/xupefei/quicklook/builds/35688332/artifacts

I have tested several types of files and they all display normally in my multiple monitors.
:-)

@xupefei xupefei closed this as completed Oct 12, 2020
Jethro-Alter added a commit to Jethro-Alter/QuickLook that referenced this issue Dec 21, 2020
* Update Translations.config

* Update Translations.config

* Update Translations.config

* Create Privacy.md

* Rename Privacy.md to PRIVACY.md

* Update PRIVACY.md

* Update PRIVACY.md

* Fix QL-Win#579: search box changed in Windows 10 1909

* Fix QL-Win#579: also deal with non-English UIs

* don't bring existing window to the front

* Revert "Fix QL-Win#644: still use focusable window on Windows 7 and 8"

This reverts commit 452574e.

Revert "Fix QL-Win#644 step 1: correctly bring window back to top when clicked"

This reverts commit af608dc.

* Fix QL-Win#401: use the native image provider to render static GIFs

* Update Translations.config

Hungarian language added.

* Fix QL-Win#669: convert image to sRGB only when the original ColorSpace is RGB, sRGB, or scRGB

* Upgrade Magick.NET packages

* Fix QL-Win#669 again: stupid syntax mistake :(

* Bulk update NuGet packages

* Update Translations.config

Typo correction on line 61 and 69. Fixing slight translation mistakes and some words also replaced with more commonly used words.

* Support File Path longer than 260 (tweak needed: https://www.tenforums.com/tutorials/51704-enable-disable-win32-long-paths-windows-10-a.html)

* Add EXR to ImageViewer

* Add MXF to VideoViewer

* Decrease update checking frequency to monthly

* Fix QL-Win#715: add 1s timeout before any previewing request

* Fix QL-Win#711: adjust UI before loading any PDF page

* Fix QL-Win#729: add a config flag to hide the tray icon

* Fix QL-Win#731: use app folder for saving data in the portable mode

* Fix QL-Win#733: detect Markdown encoding

* Fix QL-Win#734: add AVIF format

* Update .appveyor.yml

* added german translation for newly added string

* fix a typo

* Fix QL-Win#744: Components are not correctly disposed upon exit

* Fix QL-Win#477: Add JFIF files

* Update bug_report.md

* typo

* Fix QL-Win#420, QL-Win#452, QL-Win#757: windows positioning for monitors with different DPIs

* Update Common to fix plugin resize

* Fix QL-Win#759: fix thumbnail orientation for some camera models

* Fix QL-Win#760, support CR3

* removed dup of ".asf" and added ".mka" for testing

Co-authored-by: Piteriuz <[email protected]>
Co-authored-by: Pengfei Xu <[email protected]>
Co-authored-by: Bobcruise <[email protected]>
Co-authored-by: davinhanif <[email protected]>
Co-authored-by: Alexander Raab <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants