Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HEIC images display with wrong colours #669

Closed
skmskmskmskm opened this issue Jun 4, 2020 · 8 comments
Closed

HEIC images display with wrong colours #669

skmskmskmskm opened this issue Jun 4, 2020 · 8 comments
Labels
bug

Comments

@skmskmskmskm
Copy link

Describe the bug
When previewing HEIC images produced by iOS, the images have the wrong, almost inverted colours.

To Reproduce
Preview the attached HEIC image file in Quicklook

IMG_2322.zip

Expected behavior
Expect to show with correct colours per the jpeg screenshot below.

Desktop (please complete the following information):

  • Windows 10 1909
  • QuickLook Version: 3.6.9 (UWP)

Screenshots and Exception Log

HEIC screenshot
heic

JPEG screenshot
jpg
@cameronetchart
Copy link

Having this issue as well; have the HEIF/HEVC extension from the microsoft store installed. Images look correct in the default Photos app, but not Quicklook.

@ybyOxidant
Copy link

I have the same problem as above~ Apps install at Windows 10 2004, QuickLook Version: 3.6.9 (UWP), with HEIF extension.

@xupefei xupefei added the bug label Jul 4, 2020
@xupefei xupefei closed this as completed in fe44021 Jul 5, 2020
@xupefei
Copy link
Member

xupefei commented Jul 5, 2020 •
edited
Loading

Fixed!
Try it here: https://ci.appveyor.com/project/xupefei/quicklook/builds/33913242/artifacts

xupefei added a commit that referenced this issue Jul 5, 2020
@xupefei
Fix #669 again: stupid syntax mistake :(
44f66cd
@ybyOxidant
Copy link

Fixed!
Try it here: https://ci.appveyor.com/project/xupefei/quicklook/builds/33913242/artifacts

thank you~ looking forward to the next version

@cameronetchart
Copy link

cameronetchart commented Jul 5, 2020 •
edited
Loading

Fixed!
Try it here: https://ci.appveyor.com/project/xupefei/quicklook/builds/33913242/artifacts

Thanks @xupefei. That version works for me; heic files from an iPhone look normal. Only downside is that performance isn't great; it takes 3-4 seconds for the preview to load on a <2mb heic photo, versus the regular ~0.5 seconds for a 4mb jpg. I'm getting 20-35% CPU usage (on a 4c4t Intel i5 6500) versus 10% for the jpg. Same lag even if I reopen the same file over and over in quicklook. Though I don't think this is a new lag from the update; the old version has the same.

@xupefei
Copy link
Member

xupefei commented Jul 5, 2020

Thanks @xupefei. That version works for me; heic files from an iPhone look normal. Only downside is that performance isn't great; it takes 3-4 seconds for the preview to load on a <2mb heic photo, versus the regular ~0.5 seconds for a 4mb jpg. I'm getting 20-35% CPU usage (on a 4c4t Intel i5 6500) versus 10% for the jpg. Same lag even if I reopen the same file over and over in quicklook. Though I don't think this is a new lag from the update; the old version has the same.

The loading speed is delayed for three reasons:

  1. Decoding HEIC images is much slower compared to JPG.
  2. The thumbnail component used by QL, exiv2, does not extract thumbnails from HEIC images. Therefore, you saw the loading icon until the full image is loaded. In contrast, when previewing a JPG, a thumbnail is loaded at first and the full image is being loaded in the background.
  3. The image decoder used by QL, Magick.NET, actually has a multi-threaded version (i.e., Magick.NET-Q8-OpenMP-x64), but only for 64bits OSs. QL still need to run on 32bit OSs so it still uses the single-threaded version.

@rabelux rabelux mentioned this issue Jul 15, 2020
Closed
@rabelux rabelux mentioned this issue Aug 3, 2020
Closed
Jethro-Alter added a commit to Jethro-Alter/QuickLook that referenced this issue Dec 21, 2020
@Jethro-Alter @Piteriuz
@xupefei @Bobcruise @davinhanif @rabelux
Merge from latest (#8)
d14fa5b 
* Update Translations.config

* Update Translations.config

* Update Translations.config

* Create Privacy.md

* Rename Privacy.md to PRIVACY.md

* Update PRIVACY.md

* Update PRIVACY.md

* Fix QL-Win#579: search box changed in Windows 10 1909

* Fix QL-Win#579: also deal with non-English UIs

* don't bring existing window to the front

* Revert "Fix QL-Win#644: still use focusable window on Windows 7 and 8"

This reverts commit 452574e.

Revert "Fix QL-Win#644 step 1: correctly bring window back to top when clicked"

This reverts commit af608dc.

* Fix QL-Win#401: use the native image provider to render static GIFs

* Update Translations.config

Hungarian language added.

* Fix QL-Win#669: convert image to sRGB only when the original ColorSpace is RGB, sRGB, or scRGB

* Upgrade Magick.NET packages

* Fix QL-Win#669 again: stupid syntax mistake :(

* Bulk update NuGet packages

* Update Translations.config

Typo correction on line 61 and 69. Fixing slight translation mistakes and some words also replaced with more commonly used words.

* Support File Path longer than 260 (tweak needed: https://www.tenforums.com/tutorials/51704-enable-disable-win32-long-paths-windows-10-a.html)

* Add EXR to ImageViewer

* Add MXF to VideoViewer

* Decrease update checking frequency to monthly

* Fix QL-Win#715: add 1s timeout before any previewing request

* Fix QL-Win#711: adjust UI before loading any PDF page

* Fix QL-Win#729: add a config flag to hide the tray icon

* Fix QL-Win#731: use app folder for saving data in the portable mode

* Fix QL-Win#733: detect Markdown encoding

* Fix QL-Win#734: add AVIF format

* Update .appveyor.yml

* added german translation for newly added string

* fix a typo

* Fix QL-Win#744: Components are not correctly disposed upon exit

* Fix QL-Win#477: Add JFIF files

* Update bug_report.md

* typo

* Fix QL-Win#420, QL-Win#452, QL-Win#757: windows positioning for monitors with different DPIs

* Update Common to fix plugin resize

* Fix QL-Win#759: fix thumbnail orientation for some camera models

* Fix QL-Win#760, support CR3

* removed dup of ".asf" and added ".mka" for testing

Co-authored-by: Piteriuz <[email protected]>
Co-authored-by: Pengfei Xu <[email protected]>
Co-authored-by: Bobcruise <[email protected]>
Co-authored-by: davinhanif <[email protected]>
Co-authored-by: Alexander Raab <[email protected]>
@uvery9
Copy link

uvery9 commented Apr 3, 2021

Thanks @xupefei. That version works for me; heic files from an iPhone look normal. Only downside is that performance isn't great; it takes 3-4 seconds for the preview to load on a <2mb heic photo, versus the regular ~0.5 seconds for a 4mb jpg. I'm getting 20-35% CPU usage (on a 4c4t Intel i5 6500) versus 10% for the jpg. Same lag even if I reopen the same file over and over in quicklook. Though I don't think this is a new lag from the update; the old version has the same.

The loading speed is delayed for three reasons:

  1. Decoding HEIC images is much slower compared to JPG.
  2. The thumbnail component used by QL, exiv2, does not extract thumbnails from HEIC images. Therefore, you saw the loading icon until the full image is loaded. In contrast, when previewing a JPG, a thumbnail is loaded at first and the full image is being loaded in the background.
  3. The image decoder used by QL, Magick.NET, actually has a multi-threaded version (i.e., Magick.NET-Q8-OpenMP-x64), but only for 64bits OSs. QL still need to run on 32bit OSs so it still uses the single-threaded version.

It's time to abandon the 32bit OSs. Or add the 64bit branch.

@xupefei
Copy link
Member

xupefei commented Apr 4, 2021

Or add the 64bit branch

But who is going to maintain it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@xupefei @cameronetchart @ybyOxidant @uvery9 @skmskmskmskm