Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows 10 (Nov. 2019 Update) Explorer Search + Space Bug #579

Closed
lotsacaffeine97 opened this issue Nov 20, 2019 · 9 comments
Closed

Windows 10 (Nov. 2019 Update) Explorer Search + Space Bug #579

lotsacaffeine97 opened this issue Nov 20, 2019 · 9 comments

Comments

@lotsacaffeine97
Copy link

Describe the bug
I just updated to the Windows 10 November Update, which touts an improved search functionality within windows explorer that ties into the Windows Search on the taskbar, as well as the current windows explorer files. In summary, they have been changing how search works. I have now noticed an issue when using search in windows explorer which causes QuickLook to launch a preview of any passively selected file while typing a query into the windows explorer search box that contains a space. I don't recall ever experiencing this issue before, so I imagine it has to do with the November 2019 update to Windows.

To Reproduce
Steps to reproduce the behavior:

  1. Open Windows Explorer
  2. Navigate to any folder you want to search
  3. Passively click a file so that it is selected (but not opened. Also do not hit space.)
  4. Click in the Windows Explorer search box and type a query with a space (i.e. Facts Document)
  5. The document that was selected in step 3 will open in QuickLook preview - Even though system focus should be in the search box, not the file list.

Expected behavior
In step 5 from above, I would expect that QuickLook would be able to ignore the space being entered into the search box query, rather than interpreting it as a request to preview the file.

Desktop (please complete the following information):

  • Windows 10 1909
  • QuickLook Version: 3.6.5

Screenshots and Exception Log
ezgif com-video-to-gif

@SplitGemini
Copy link

Yeah, I want it be fixed too.

@xupefei
Copy link
Member

xupefei commented May 19, 2020

This might be a new bug since Explorer have added a Dark Mode, since I noticed the search textbox now looks different than in old Windows versions.

I will check.

xupefei added a commit that referenced this issue May 19, 2020
@xupefei
Fix #579: search box changed in Windows 10 1909
3f587c7
@xupefei
Copy link
Member

xupefei commented May 19, 2020

Fixed! You can try it here: https://ci.appveyor.com/project/xupefei/quicklook/builds/32983144/artifacts

@SplitGemini
Copy link

Don't work

@SplitGemini
Copy link

1

My windows version is win10 1909 (build 18363.863)

@SplitGemini
Copy link

Must cancel selected first before tap space in search box

@xupefei
Copy link
Member

xupefei commented May 20, 2020

It works for me. Are you sure the latest version is running?
You can right-click on the tray icon and read the version number. It should be "v3.6.8-10-g3f587c7".

@SplitGemini
Copy link

It works for me. Are you sure the latest version is running?
You can right-click on the tray icon and read the version number. It should be "v3.6.8-10-g3f587c7".

Yeah, it's this version, it works when no item is selected, but if select an item, it doesn't work.

xupefei added a commit that referenced this issue May 20, 2020
@xupefei
Fix #579: also deal with non-English UIs
5a02558
@xupefei
Copy link
Member

xupefei commented May 20, 2020

It should be okay now: https://ci.appveyor.com/project/xupefei/quicklook/builds/33000705/artifacts

Jethro-Alter added a commit to Jethro-Alter/QuickLook that referenced this issue Dec 21, 2020
@Jethro-Alter @Piteriuz
@xupefei @Bobcruise @davinhanif @rabelux
Merge from latest (#8)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
d14fa5b 
* Update Translations.config

* Update Translations.config

* Update Translations.config

* Create Privacy.md

* Rename Privacy.md to PRIVACY.md

* Update PRIVACY.md

* Update PRIVACY.md

* Fix QL-Win#579: search box changed in Windows 10 1909

* Fix QL-Win#579: also deal with non-English UIs

* don't bring existing window to the front

* Revert "Fix QL-Win#644: still use focusable window on Windows 7 and 8"

This reverts commit 452574e.

Revert "Fix QL-Win#644 step 1: correctly bring window back to top when clicked"

This reverts commit af608dc.

* Fix QL-Win#401: use the native image provider to render static GIFs

* Update Translations.config

Hungarian language added.

* Fix QL-Win#669: convert image to sRGB only when the original ColorSpace is RGB, sRGB, or scRGB

* Upgrade Magick.NET packages

* Fix QL-Win#669 again: stupid syntax mistake :(

* Bulk update NuGet packages

* Update Translations.config

Typo correction on line 61 and 69. Fixing slight translation mistakes and some words also replaced with more commonly used words.

* Support File Path longer than 260 (tweak needed: https://www.tenforums.com/tutorials/51704-enable-disable-win32-long-paths-windows-10-a.html)

* Add EXR to ImageViewer

* Add MXF to VideoViewer

* Decrease update checking frequency to monthly

* Fix QL-Win#715: add 1s timeout before any previewing request

* Fix QL-Win#711: adjust UI before loading any PDF page

* Fix QL-Win#729: add a config flag to hide the tray icon

* Fix QL-Win#731: use app folder for saving data in the portable mode

* Fix QL-Win#733: detect Markdown encoding

* Fix QL-Win#734: add AVIF format

* Update .appveyor.yml

* added german translation for newly added string

* fix a typo

* Fix QL-Win#744: Components are not correctly disposed upon exit

* Fix QL-Win#477: Add JFIF files

* Update bug_report.md

* typo

* Fix QL-Win#420, QL-Win#452, QL-Win#757: windows positioning for monitors with different DPIs

* Update Common to fix plugin resize

* Fix QL-Win#759: fix thumbnail orientation for some camera models

* Fix QL-Win#760, support CR3

* removed dup of ".asf" and added ".mka" for testing

Co-authored-by: Piteriuz <[email protected]>
Co-authored-by: Pengfei Xu <[email protected]>
Co-authored-by: Bobcruise <[email protected]>
Co-authored-by: davinhanif <[email protected]>
Co-authored-by: Alexander Raab <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@xupefei @SplitGemini @lotsacaffeine97