Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot provide custom keybinding for 's' key in normal mode #1579

Closed
jacobdufault opened this issue Apr 26, 2017 · 1 comment · Fixed by #4735
Closed

Cannot provide custom keybinding for 's' key in normal mode #1579

jacobdufault opened this issue Apr 26, 2017 · 1 comment · Fixed by #4735

Comments

@jacobdufault
Copy link

  • Click thumbs-up 👍 on this issue if you want it!
  • Click confused 😕 on this issue if not having it makes VSCodeVim unusable.

The VSCodeVim team prioritizes issues based on reaction count.


What did you do?

I'd like to overwrite the default behavior for the s key in normal mode (ie, currently it enters insert mode but instead I'd like it have it do a number of semantic operations based on the second entered key).

For example, this configuration does not currently do anything:

"vim.otherModesKeyBindingsNonRecursive": [
    {
      "before": ["s", "r"],
      "after": [],
      "commands": [
        {
          "command": "editor.action.referenceSearch.trigger",
          "args": []
        }
      ]
    }
}

What did you expect to happen?

Reference search runs when pressing sr in normal mode.

What happened instead?

I enter insert mode when pressing sr in normal mode.

Technical details:

  • VSCode Version: 1.11.2
  • VsCodeVim Version: 0.6.18
  • OS: Win10
@rebornix
Copy link
Member

rebornix commented May 1, 2017

Shares the same root cause as #1582 .

berknam pushed a commit to berknam/Vim that referenced this issue Apr 13, 2020
Refactor the Remapper and ModeHandler to allow better remapping experience.
It will allow to remap operator keys, motion keys and multiple keys when the first key could be handled.

Should fix the following issues (maybe more):
VSCodeVim#4674
VSCodeVim#4464
VSCodeVim#3988
VSCodeVim#3768
VSCodeVim#3742
VSCodeVim#2975
VSCodeVim#2955
VSCodeVim#2234
VSCodeVim#2041
VSCodeVim#1870
VSCodeVim#1821
VSCodeVim#1579
VSCodeVim#1398

Needs more testing.
@berknam berknam mentioned this issue Apr 13, 2020
10 tasks
J-Fields pushed a commit that referenced this issue Aug 16, 2020
This is a pretty massive change; see pull request #4735 for full details

Most notably:
- Support for operator-pending mode, including remaps and a half-cursor decoration
- Correct handling of ambiguous remaps with timeout
- Correct handling of recursive special case when the RHS starts with the LHS
- Correct handling of multi-key remaps in insert mode
- Failed movements that occur partway through a remap stop & discard the rest of the remap
- Implement `unmap` and `mapclear` in .vimrc

Refs #463, refs #4908
Fixes #1261, fixes #1398, fixes #1579, fixes #1821, fixes #1835
Fixes #1870, fixes #1883, fixes #2041, fixes #2234, fixes #2466
Fixes #2897, fixes #2955, fixes #2975, fixes #3082, fixes #3086
Fixes #3171, fixes #3373, fixes #3413, fixes #3742, fixes #3768
Fixes #3988, fixes #4057, fixes #4118, fixes #4236, fixes #4353
Fixes #4464, fixes #4530, fixes #4532, fixes #4563, fixes #4674
Fixes #4756, fixes #4883, fixes #4928, fixes #4991, fixes #5016
Fixes #5057, fixes #5067, fixes #5084, fixes #5125
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants