Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keybindings in delete mode not working #3413

Closed
janhesters opened this issue Jan 24, 2019 · 0 comments · Fixed by #4735
Closed

Keybindings in delete mode not working #3413

janhesters opened this issue Jan 24, 2019 · 0 comments · Fixed by #4735

Comments

@janhesters
Copy link

Describe the bug
I'm using the Dvorak keyboard layout. Therefore I rebound my navigation keys. But in the delete mode they are not working (e.g. d3h).

To Reproduce
Steps to reproduce the behavior:

Add these settings:

 "vim.normalModeKeyBindingsNonRecursive": [
    { "before": ["h"], "after": ["<left>"] },
    { "before": ["t"], "after": ["<down>"] },
    { "before": ["s"], "after": ["<right>"] },
    { "before": ["n"], "after": ["<up>"] }
    // { "before": ["b"], "after": ["s"] }
  ],
  "vim.visualModeKeyBindingsNonRecursive": [
    { "before": ["h"], "after": ["<left>"] },
    { "before": ["t"], "after": ["<down>"] },
    { "before": ["s"], "after": ["<right>"] },
    { "before": ["n"], "after": ["<p>"] }
  ],

Now try to do: d3t which should now be 'delete 3 down'. This doesn't work. Instead now the t meaning the new <down> does not work. Instead, d3j (in QWERTY h3j) now works.

How can I also bind <down> in delete mode?

Expected behavior
3 lines down get deleted.

Environment (please complete the following information):

  • Issue Type: Bug
  • Extension Name: vim
  • Extension Version: 1.0.3
  • OS Version: Darwin x64 18.0.0
  • VSCode version: 1.30.2
@berknam berknam mentioned this issue Jul 7, 2020
10 tasks
J-Fields pushed a commit that referenced this issue Aug 16, 2020
This is a pretty massive change; see pull request #4735 for full details

Most notably:
- Support for operator-pending mode, including remaps and a half-cursor decoration
- Correct handling of ambiguous remaps with timeout
- Correct handling of recursive special case when the RHS starts with the LHS
- Correct handling of multi-key remaps in insert mode
- Failed movements that occur partway through a remap stop & discard the rest of the remap
- Implement `unmap` and `mapclear` in .vimrc

Refs #463, refs #4908
Fixes #1261, fixes #1398, fixes #1579, fixes #1821, fixes #1835
Fixes #1870, fixes #1883, fixes #2041, fixes #2234, fixes #2466
Fixes #2897, fixes #2955, fixes #2975, fixes #3082, fixes #3086
Fixes #3171, fixes #3373, fixes #3413, fixes #3742, fixes #3768
Fixes #3988, fixes #4057, fixes #4118, fixes #4236, fixes #4353
Fixes #4464, fixes #4530, fixes #4532, fixes #4563, fixes #4674
Fixes #4756, fixes #4883, fixes #4928, fixes #4991, fixes #5016
Fixes #5057, fixes #5067, fixes #5084, fixes #5125
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant