Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remapping , doesn't work #4756

Closed
NightMachinery opened this issue Apr 20, 2020 · 1 comment · Fixed by #4735
Closed

Remapping , doesn't work #4756

NightMachinery opened this issue Apr 20, 2020 · 1 comment · Fixed by #4735

Comments

@NightMachinery
Copy link

NightMachinery commented Apr 20, 2020 •
edited
Loading

I have tried { "before":[",", "l" ], "commands": ["language-julia.executeJuliaCodeInREPL"]}, , but , still does its default thing. How do I remap it?
@sql-koala
Copy link
Contributor

Hi, right now you cant create two key mappings, where the first key is an operator (c/d/...) or a motion.
In other words, for two key mappings, you need to start with: g_, z_, or <leader>.
And yes, I understand the use case ;-)

See something similar here:
#4563

@berknam berknam mentioned this issue May 13, 2020
Merged
10 tasks
J-Fields pushed a commit that referenced this issue Aug 16, 2020
@berknam
Overhaul remapping logic (#4735)
91ca71f 
This is a pretty massive change; see pull request #4735 for full details

Most notably:
- Support for operator-pending mode, including remaps and a half-cursor decoration
- Correct handling of ambiguous remaps with timeout
- Correct handling of recursive special case when the RHS starts with the LHS
- Correct handling of multi-key remaps in insert mode
- Failed movements that occur partway through a remap stop & discard the rest of the remap
- Implement `unmap` and `mapclear` in .vimrc

Refs #463, refs #4908
Fixes #1261, fixes #1398, fixes #1579, fixes #1821, fixes #1835
Fixes #1870, fixes #1883, fixes #2041, fixes #2234, fixes #2466
Fixes #2897, fixes #2955, fixes #2975, fixes #3082, fixes #3086
Fixes #3171, fixes #3373, fixes #3413, fixes #3742, fixes #3768
Fixes #3988, fixes #4057, fixes #4118, fixes #4236, fixes #4353
Fixes #4464, fixes #4530, fixes #4532, fixes #4563, fixes #4674
Fixes #4756, fixes #4883, fixes #4928, fixes #4991, fixes #5016
Fixes #5057, fixes #5067, fixes #5084, fixes #5125
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor Remapper berknam/Vim
2 participants
@sql-koala @NightMachinery