-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Strange visual selection with keys remapped to ^ and $ #1835
Comments
Huh. You're right. When I first saw this bug report, I thought it was just a limitation of our remapper (for example, How interesting. I personally use this keybinding, so I'll try to figure out what's wrong soon. |
Ok, so this is a bug that was revealed as the result of fixing another bug. is the commit that caused it. |
I too have been impacted by this bug. In my case I had remapped |
I have this same exact issue. Except since
|
These bindings seem to work if you pause for 2-3 seconds after entering visual mode. With {
"before": ["H"],
"after": ["^"]
} v pause for 3 seconds H produces the the correct behavior |
I'm still experiencing this bug, but this workaround from #2842 fixes it for now:
|
Any movement on this? The workaround that @charlietran references breaks text object motions, e.g. viw, so it isn't really viable |
This is a pretty massive change; see pull request #4735 for full details Most notably: - Support for operator-pending mode, including remaps and a half-cursor decoration - Correct handling of ambiguous remaps with timeout - Correct handling of recursive special case when the RHS starts with the LHS - Correct handling of multi-key remaps in insert mode - Failed movements that occur partway through a remap stop & discard the rest of the remap - Implement `unmap` and `mapclear` in .vimrc Refs #463, refs #4908 Fixes #1261, fixes #1398, fixes #1579, fixes #1821, fixes #1835 Fixes #1870, fixes #1883, fixes #2041, fixes #2234, fixes #2466 Fixes #2897, fixes #2955, fixes #2975, fixes #3082, fixes #3086 Fixes #3171, fixes #3373, fixes #3413, fixes #3742, fixes #3768 Fixes #3988, fixes #4057, fixes #4118, fixes #4236, fixes #4353 Fixes #4464, fixes #4530, fixes #4532, fixes #4563, fixes #4674 Fixes #4756, fixes #4883, fixes #4928, fixes #4991, fixes #5016 Fixes #5057, fixes #5067, fixes #5084, fixes #5125
The VSCodeVim team prioritizes issues based on reaction count.
Is this a BUG REPORT or FEATURE REQUEST? (choose one): Bug report
Environment:
What happened: In my config, in
otherModesKeyBindingsNonRecursive
I mappedH
to^
andL
to$
. When I enter viasual mode (pressv
) and pressL
afterwards, it selected to the end of the visible screen. Same forH
which selects to the start of the visible screen.When I press
v
and then^
or$
, the correct action happens: it selects until the start or the end of the line.What did you expect to happen: I expect that when I enter visual mode (press
v
) and pressL
afterwards, it selects to the end of line. Same forH
which I expected to select to the beginning of the line.How to reproduce it:
v
H
(orL
)Important: This worked fine for a few months until it stopped a few weeks ago. I went trough the changelog and the only thing that could be related is the
Fixes visual block mode respect keybindings @Chillee #1709
in the Neovim Nutty release. But I'm not sure. Outside of visual mode (in normal mode for example), the work as expected.It gets even stranger: When I enter visual mode, press a navigation key (e.g.
l
) once to move one space and then pressL
, it selects as expected until the end of the line.The text was updated successfully, but these errors were encountered: