Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefabs: Unused prefab assets need to be stripped even If Game Option for stripping unused assets is switched OFF #8312

Closed
2 tasks done
rwkay opened this issue Nov 5, 2024 · 8 comments
Assignees
Labels
feature request New feature (or a request for one)
Milestone

Comments

@rwkay
Copy link

rwkay commented Nov 5, 2024

Description

(as title)

Also better reporting of what has been stripped out, something like

-------------------------------------------------------
NOTE: 167 Unused Assets found (and will be removed) -

GMAnimCurve :: animation_curve_bounce_a_lot, animation_curve_bounce_twice, animation_curve_one_way_end, 
GMFont :: fntHuge, Font5
GMObject :: oAreaLaser, oJumpSmash, oLaser, oPunch, oTest, oWaveManager
GMShader :: ShaderAlpha, ShaderHitFlash, ShaderRed, ShaderWhiteSpawn
GMSound :: sndHeal, sndMenuChange, sndMenuConfirm, sndNewWave
GMSprite :: sFaceDown, sFaceLeft, sFaceRight, sFaceUp, sKey0, sKey1, sKey2, sKey3, sKey4, sKey5, sKey6, sKey7, sKey8, sKey9, sKeyA, sKeyAlt, 
-------------------------------------------------------

Expected Change

if user has disabled asset stripping we should still strip out filter / effects / particles and other things that they do NOT use

Steps To Reproduce

  1. Start GameMaker
  2. See the issue

How reliably can you recreate this issue using your steps above?

Always

Which version of GameMaker are you reporting this issue for?

2024.1100 (Betas)

Which platform(s) are you seeing the problem on?

Windows

Sample Package Attached?

  • I have attached my bug package

Sample Project Added?

  • I have included a small sample project
@rwkay rwkay added the runner-bug In-game bugs with the "GameMaker Studio 2" runtimes label Nov 5, 2024
@rwkay rwkay self-assigned this Nov 5, 2024
@rwkay rwkay added feature request New feature (or a request for one) and removed runner-bug In-game bugs with the "GameMaker Studio 2" runtimes labels Nov 5, 2024
@rwkay
Copy link
Author

rwkay commented Nov 5, 2024

Feature added in 2024.11 - if remove unused assets has been switched off then the algorithm is still run (so unused prefab assets are are still stripped) but all the main project assets are marked as being used.

We have also added the unused asset reporting so they are better presented - at least for some definition of better.

@rwkay rwkay closed this as completed Nov 5, 2024
@github-project-automation github-project-automation bot moved this from Triage to Done in Team Workload Nov 5, 2024
@rwkay rwkay added this to the 2024.11 milestone Nov 5, 2024
@gurpreetsinghmatharoo gurpreetsinghmatharoo moved this from Done to Ready for QA in Team Workload Nov 6, 2024
@YYDan YYDan changed the title If user has switched OFF Unused asset stripping then prefabs assets should still be stripped (but keep all assets in main project). Prefabs: Unused prefab assets need to be stripped even If Game Option for stripping unused assets is switched OFF Nov 7, 2024
@mgeddesGM mgeddesGM assigned mgeddesGM and unassigned mgeddesGM Nov 7, 2024
@Emc1923 Emc1923 self-assigned this Nov 11, 2024
@Emc1923
Copy link

Emc1923 commented Nov 19, 2024

This doesn't seem to be working as expected as of IDE v2024.1100.0.688 Runtime v2024.1100.0.709.

Output log example when the remove unused asset option is unselected : outputlog_OFF.txt
And when it is selected: outputlog_ON.txt

@Emc1923 Emc1923 reopened this Nov 19, 2024
@github-project-automation github-project-automation bot moved this from Ready for QA to Triage in Team Workload Nov 19, 2024
@rwkay
Copy link
Author

rwkay commented Nov 19, 2024

What do you feel is actually wrong? the output is exactly what I would expect.

you can see nothing has been removed when the remove unused is unselected, and then when it is selected there are many assets removed when it is selected.

@Emc1923
Copy link

Emc1923 commented Nov 20, 2024

If unused Prefab assets are being stripped even when the option is off I would expect the warning and list of assets removed to appear in both cases on the output. The project I used to test only had Prefabs.

@stuckie stuckie moved this from Triage to Todo in Team Workload Nov 20, 2024
@rwkay
Copy link
Author

rwkay commented Nov 20, 2024

Can you please attach the project then - as only the assets in the main project should be getting reported so I need to work out why they are getting reported...

@rwkay rwkay moved this from Todo to In Progress in Team Workload Nov 20, 2024
@rwkay
Copy link
Author

rwkay commented Nov 20, 2024

Fixed in 2024.11

@rwkay rwkay closed this as completed Nov 20, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Team Workload Nov 20, 2024
@Emc1923
Copy link

Emc1923 commented Nov 20, 2024

Verified fixed in IDE v2024.1100.0.691 Runtime v2024.1100.0.711 - unused prefab assets are not reported.

@Emc1923 Emc1923 moved this from Done to Verified in Team Workload Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature (or a request for one)
Projects
Status: Verified
Development

No branches or pull requests

3 participants