Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve merge conflicts (merge HHS:main into adhoc:main) #484

Merged
merged 50 commits into from
Nov 15, 2021

Conversation

thewatermethod
Copy link
Collaborator

@thewatermethod thewatermethod commented Nov 12, 2021

Description of change

Merge HHS:main into adhoc:main to fix some merge conflicts between the fork and parent. Hopefully one of the last times we have to bother with this.

(All these changes were approved and merged into our HHS repo)

How to test

Issue(s)

no jira

Checklists

Every PR

  • Meets issue criteria
  • JIRA ticket status updated
  • Code is meaningfully tested
  • Meets accessibility standards (WCAG 2.1 Levels A, AA)
  • API Documentation updated
  • Boundary diagram updated
  • Logical Data Model updated
  • Architectural Decision Records written for major infrastructure decisions

Production Deploy

  • Staging smoke test completed

After merge/deploy

  • Update JIRA ticket status

dependabot bot and others added 30 commits November 3, 2021 19:34
Bumps [validator](https://github.com/validatorjs/validator.js) from 13.6.0 to 13.7.0.
- [Release notes](https://github.com/validatorjs/validator.js/releases)
- [Changelog](https://github.com/validatorjs/validator.js/blob/master/CHANGELOG.md)
- [Commits](validatorjs/validator.js@13.6.0...13.7.0)

---
updated-dependencies:
- dependency-name: validator
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Josh Salisbury <[email protected]>
welcoming robots in certain situations
@thewatermethod thewatermethod changed the title Merge hhs 11 12 Resolve merge conflicts (merge HHS:main into adhoc:main) Nov 15, 2021
Copy link

@AdamAdHocTeam AdamAdHocTeam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, once test coverage passes.

Copy link
Collaborator

@kryswisnaskas kryswisnaskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@thewatermethod thewatermethod marked this pull request as ready for review November 15, 2021 15:43
@thewatermethod thewatermethod merged commit 97a8eae into main Nov 15, 2021
@thewatermethod thewatermethod deleted the merge-hhs-11-12 branch November 15, 2021 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants