Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go-algorand v2.10.0-beta #2743

Merged
merged 43 commits into from
Aug 15, 2021
Merged

go-algorand v2.10.0-beta #2743

merged 43 commits into from
Aug 15, 2021

Conversation

onetechnical
Copy link
Contributor

@onetechnical onetechnical commented Aug 13, 2021

No description provided.

AlgoStephenAkiki and others added 30 commits July 30, 2021 21:23
Removes signing calls to KMD by creating internal hashmap and signing transactions locally.
…mentations (#2679)

Spotted this dead code, and after discussing with @tsachiherman and @zeldovich, it should be fine to remove.
I made a TEAL quine to test the output of app_params_get AppApprovalProgram for the current program. It's mostly for fun but this does strengthen the tests for app_params_get.
…#2669)

* Move tests from backwardCompat_test.go to fields_test.go
* Check every field on a version before it was introduced
* Enable txna fields checks
* Fix TestGlobal to prevent invalid version specs in tests map
Indexer needs the list of deleted local creatable states. This PR adds this information in ledger's state delta.
The REST API generate command is failing to install oapi-codegen because it needs an older version of kin-openapi than we define in go.sum. I'm attempting to install it with the buildtools script.

Also added REST server generation to the codegen test.
#2689)

This reverts commit 8835bfd.
Revert "replace the KMD usage in pingpong with direct signing"
#2653 created some undesired performance regressions reported on the perf monitoring system. I'm rolling this change back so we can take it offline.
Fix a go lint issue
Make sure there is no overflow on TotalExtraAppPages calculation + test
updateApplication does not enforce individual program length but looks like it should. This PR enforces that.
Fix for updating an application with extra program pages
Make sure there is no overflow on TotalExtraAppPages calculation + test
updateApplication does not enforce individual program length but looks like it should. This PR enforces that.
The changes here replaces the KMD signing with direct signing, which improves the performance.
It also add a unique note to every transaction in order to avoid duplicate transactions.
The problem was in commitSyncer goroutine that triggered commitRound in additional to controlled commitRound calls.
Fixed by closing deferred commits channel and waiting commitSyncer to exit.
Delete `Balances.PutWithCreatable()` and add new functions that notify the COW that a creatable was created or deleted. Coming up next is similar two functions for asset/application local state, needed by indexer.
Add the framework for supporting batch verification.
Passing a foreign app id to the `goal app create` cmd with dryrun tries to use ApplicationId (0) instead of the foreign app id.
…sensus protocol is unknown. (#2708)

Return an error in EncodeSignedTxn() and DecodeSignedTxn() if consensus protocol is unknown
algojohnlee and others added 13 commits August 10, 2021 09:08
…lation opcodes (#2710)

* TypeFuncs added with tests

* Fixed dup test and edited code to use more literals
Add slack notifications for rel/nightly failures.

This will help us easily track Circle CI rel/nightly test failures on our slack channel.
Update the Circle CI branch filters to run "nightly"/longer tests over "rel/" and "hotfix/" branches.
* new opcode

* adding log

* added unit tests

* more tests

* update evalDelta test in app

* update log call limit to 32

* move MaxLogCalls to config

* api updates

* test and gomod updates

* update logs to [appid,msg]

* update logs data structure

* increate wait for txn timeout

* update log allocbound and hanlder error message

* update maxlogcalls val

* remove getLogs()

* remove getLogs
* Add pooling for grouped app calls and add unit tests

* Fix doc errors

* Pool app call budget in ep

* Check if pooledBudget is not nil in budget call

* Fix app call integration test output and minor syntax changes

* Minor change in comment

* Modify some tests to get better coverage

* Refactor tests

* Clean up

* Remove a hardcoded constant

* Add pointer equivalence test
* Convenient and High-fidelity Transaction Processing Tests

This refactors some of the `ledger` code so that it's convenient
to write short tests that operate on a fairly complete ledger,
including rewards payouts.  Previously, tests used genesis(), but
genesis() build the genesis block internally "by hand" rather
than using MakeGenesisBlock, so it missed some details (like
setting up RewardsState). Presumably, this was because
MakeGenesisBlock was in the `data` package, and could not be
imported.  That is the motivation behind moving it, and some
related code, to bookkeeping (where various Genesis related code
already existed).

The txntest packaged is motivated purely by a desire for more
concise tests.  It allows for the construction of
transaction.Transaction objects concisely, and we can add all
sort of conveneince routines here that would not make sense in
the production code (turning these into SignedTxns,
SignedTxnWithADs, TransactionGroups, etc).

* Converted a test, went from 130 lines to 68.  Same test.

* Docs and and another test converted
Replaced SKIP_E2E_SUBS var and E2E_SUBS_ONLY var with E2E_SUBS var that has values of "ONLY" and "SKIP" as well as not set at all. We might need to add another value to this var in the future for another option.
* The test checks rekeying before and after upgrade but nodes running
  as separate processes might upgrade earlier than the test advances
* This fix takes this into account similarly to the app upgrade tests
@onetechnical onetechnical changed the base branch from master to rel/beta August 13, 2021 17:46
@codecov-commenter
Copy link

codecov-commenter commented Aug 13, 2021

Codecov Report

Merging #2743 (0c3ce93) into rel/beta (de84e90) will increase coverage by 0.08%.
The diff coverage is 45.65%.

Impacted file tree graph

@@             Coverage Diff              @@
##           rel/beta    #2743      +/-   ##
============================================
+ Coverage     47.03%   47.11%   +0.08%     
============================================
  Files           350      349       -1     
  Lines         55832    56321     +489     
============================================
+ Hits          26258    26536     +278     
- Misses        26623    26812     +189     
- Partials       2951     2973      +22     
Impacted Files Coverage Δ
config/version.go 9.09% <ø> (ø)
daemon/algod/api/server/v2/handlers.go 0.00% <0.00%> (ø)
daemon/algod/api/server/v2/utils.go 14.50% <0.00%> (-2.32%) ⬇️
data/bookkeeping/genesis.go 0.00% <0.00%> (ø)
data/ledger.go 24.08% <0.00%> (+4.56%) ⬆️
data/transactions/logic/doc.go 82.75% <ø> (ø)
data/transactions/logic/opcodes.go 96.00% <ø> (ø)
ledger/ledgercore/statedelta.go 40.00% <0.00%> (-1.67%) ⬇️
libgoal/libgoal.go 3.06% <0.00%> (-0.03%) ⬇️
node/node.go 3.78% <0.00%> (ø)
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de84e90...0c3ce93. Read the comment docs.

@onetechnical onetechnical marked this pull request as ready for review August 15, 2021 13:11
@algojohnlee algojohnlee merged commit 25804af into rel/beta Aug 15, 2021
@algobarb algobarb deleted the relbeta2.10.0 branch January 5, 2022 16:12
PhearZero pushed a commit to PhearNet/crypto that referenced this pull request Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.