-
Notifications
You must be signed in to change notification settings - Fork 493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go-algorand v2.10.0-beta #2743
Merged
Merged
go-algorand v2.10.0-beta #2743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes signing calls to KMD by creating internal hashmap and signing transactions locally.
…mentations (#2679) Spotted this dead code, and after discussing with @tsachiherman and @zeldovich, it should be fine to remove.
I made a TEAL quine to test the output of app_params_get AppApprovalProgram for the current program. It's mostly for fun but this does strengthen the tests for app_params_get.
…#2669) * Move tests from backwardCompat_test.go to fields_test.go * Check every field on a version before it was introduced * Enable txna fields checks * Fix TestGlobal to prevent invalid version specs in tests map
Indexer needs the list of deleted local creatable states. This PR adds this information in ledger's state delta.
The REST API generate command is failing to install oapi-codegen because it needs an older version of kin-openapi than we define in go.sum. I'm attempting to install it with the buildtools script. Also added REST server generation to the codegen test.
Fix a go lint issue
Run golangci-lint from Github actions using https://github.com/golangci/golangci-lint-action
Make sure there is no overflow on TotalExtraAppPages calculation + test
updateApplication does not enforce individual program length but looks like it should. This PR enforces that.
Fix for updating an application with extra program pages
Make sure there is no overflow on TotalExtraAppPages calculation + test
updateApplication does not enforce individual program length but looks like it should. This PR enforces that.
The changes here replaces the KMD signing with direct signing, which improves the performance. It also add a unique note to every transaction in order to avoid duplicate transactions.
The problem was in commitSyncer goroutine that triggered commitRound in additional to controlled commitRound calls. Fixed by closing deferred commits channel and waiting commitSyncer to exit.
…d into hotfix/v2.9.1
Add the framework for supporting batch verification.
Passing a foreign app id to the `goal app create` cmd with dryrun tries to use ApplicationId (0) instead of the foreign app id.
…sensus protocol is unknown. (#2708) Return an error in EncodeSignedTxn() and DecodeSignedTxn() if consensus protocol is unknown
Hotfix/v2.9.1
…lation opcodes (#2710) * TypeFuncs added with tests * Fixed dup test and edited code to use more literals
Add slack notifications for rel/nightly failures. This will help us easily track Circle CI rel/nightly test failures on our slack channel.
Update the Circle CI branch filters to run "nightly"/longer tests over "rel/" and "hotfix/" branches.
* new opcode * adding log * added unit tests * more tests * update evalDelta test in app * update log call limit to 32 * move MaxLogCalls to config * api updates * test and gomod updates * update logs to [appid,msg] * update logs data structure * increate wait for txn timeout * update log allocbound and hanlder error message * update maxlogcalls val * remove getLogs() * remove getLogs
* Add pooling for grouped app calls and add unit tests * Fix doc errors * Pool app call budget in ep * Check if pooledBudget is not nil in budget call * Fix app call integration test output and minor syntax changes * Minor change in comment * Modify some tests to get better coverage * Refactor tests * Clean up * Remove a hardcoded constant * Add pointer equivalence test
* Convenient and High-fidelity Transaction Processing Tests This refactors some of the `ledger` code so that it's convenient to write short tests that operate on a fairly complete ledger, including rewards payouts. Previously, tests used genesis(), but genesis() build the genesis block internally "by hand" rather than using MakeGenesisBlock, so it missed some details (like setting up RewardsState). Presumably, this was because MakeGenesisBlock was in the `data` package, and could not be imported. That is the motivation behind moving it, and some related code, to bookkeeping (where various Genesis related code already existed). The txntest packaged is motivated purely by a desire for more concise tests. It allows for the construction of transaction.Transaction objects concisely, and we can add all sort of conveneince routines here that would not make sense in the production code (turning these into SignedTxns, SignedTxnWithADs, TransactionGroups, etc). * Converted a test, went from 130 lines to 68. Same test. * Docs and and another test converted
Replaced SKIP_E2E_SUBS var and E2E_SUBS_ONLY var with E2E_SUBS var that has values of "ONLY" and "SKIP" as well as not set at all. We might need to add another value to this var in the future for another option.
* The test checks rekeying before and after upgrade but nodes running as separate processes might upgrade earlier than the test advances * This fix takes this into account similarly to the app upgrade tests
Codecov Report
@@ Coverage Diff @@
## rel/beta #2743 +/- ##
============================================
+ Coverage 47.03% 47.11% +0.08%
============================================
Files 350 349 -1
Lines 55832 56321 +489
============================================
+ Hits 26258 26536 +278
- Misses 26623 26812 +189
- Partials 2951 2973 +22
Continue to review full report at Codecov.
|
algobarb
approved these changes
Aug 13, 2021
tsachiherman
approved these changes
Aug 13, 2021
PhearZero
pushed a commit
to PhearNet/crypto
that referenced
this pull request
Jan 17, 2025
go-algorand v2.10.0-beta
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.