Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry pick Allow proc-macro2 dependency to be flexible (#1102) #1105

Closed
wants to merge 69 commits into from

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Dec 29, 2021

Manual Cherry Pick of 3dca969 which originally appeared in #1102

Re #1101

alamb and others added 30 commits October 13, 2021 15:14
…atting with nightly (#845) (#850)

* Clippy fixes

* Test formatting fixes

* Test formatting fixes

* Fixup

Co-authored-by: Daniël Heres <[email protected]>
* Delete temp file from docs

* fix

* Use gitignore instead
fix readme with invalid markdown syntax

Co-authored-by: Jiayu Liu <[email protected]>
* Use kernel utility for parsing timestamps in csvs.

* Remove cruft.

* Cleanup.

* Lint.

* Remove erroneous stringify.

Co-authored-by: Navin <[email protected]>
…ublish) (#856)

* fix parquet_derive with default features (and fix `cargo publish`) (#837)

* Run all tests and do dry runs of cargo publish

* Add test for building parquet derive with default features'

* fix feature flags in parquet crate

* fixup rat

* fix default feature test

* Update parquet_derive/test/dependency/default-features/Cargo.toml

* Remove merge issue
* Implement boolean equality kernels

* Respect offset

* Simplify

Co-authored-by: Daniël Heres <[email protected]>
…865)

* fix(ipc): Support serializing structs containing dictionaries

Dictionary fields nested in structs were not properly marked as
dictionary fields when serializing to fb.

* style: cargo fmt

Co-authored-by: Helgi Kristvin Sigurbjarnarson <[email protected]>
The `value_offset` function only read the least significant byte in the
offset array, causing issues with unions with more than 255 rows of any
given variant. Fix the issue by reading the entire i32 offset and add a
unit test.

Co-authored-by: Helgi Kristvin Sigurbjarnarson <[email protected]>
* Update changelog for 6.1 release

* Update version to 6.1.0
…870) (#915)

* feat(ipc): Support for writing dictionaries nested in structs and unions

Dictionaries are lost when serializing a RecordBatch for IPC, producing
invalid arrow data. This PR changes encoded_batch to recursively find
all dictionary fields within the schema (currently only in structs and
unions) so nested dictionaries are properly serialized.

* address lint and clippy

Co-authored-by: Helgi Kristvin Sigurbjarnarson <[email protected]>
)

* Fix unaligned access in bit-packing

* Fix creation of unaligned reference in murmur_hash2_64a

* Remove now-unnecessary unsafe

Co-authored-by: Andrew Lamb <[email protected]>

Co-authored-by: Ben Kimock <[email protected]>
Co-authored-by: kingeasternsun <[email protected]>
…mittent failures (#934)

* Automatically retry failed MIRI runs to work around intermittent failures (#922)

* Move MIRI checks into a shell script

* add retry loop

* Do not use cache for miri
…ary fields (#923) (#931)

* feat(ipc): read a message containing nested dictionary fields

* Apply suggestions from code review

Co-authored-by: Andrew Lamb <[email protected]>

* address lints

Co-authored-by: Andrew Lamb <[email protected]>

Co-authored-by: Helgi Kristvin Sigurbjarnarson <[email protected]>
…810) (#936)

* Validate arguments to ArrayData::new: null bit buffer and buffers

* REname is_int_type to is_dictionary_key_type()

* Correctly handle self.offset in offsets buffer

* Consolidate checks

* Fix test output
* add check for appending i128 to decimal builder

* remove the ArrowError(DecimalError)

Co-authored-by: Kun Liu <[email protected]>
* reproduce validation error

* Fix validation bug

Co-authored-by: Ben Chambers <[email protected]>

Co-authored-by: Ben Chambers <[email protected]>
alamb and others added 23 commits December 6, 2021 15:39
* Add full data validation for ArrayData::try_new() (#921)

* Add full data validation for ArrayData::try_new()

* Only look at offset+len indexes

Co-authored-by: Jörn Horstmann <[email protected]>

* fix test

* fmt

* test for array indexes

Co-authored-by: Jörn Horstmann <[email protected]>

* Fix: clippy

Co-authored-by: Jörn Horstmann <[email protected]>
* Docstrings for TimestampSecondArray.

* fixup! Docstrings for TimestampSecondArray.

Co-authored-by: Navin <[email protected]>
Fixes #989.

This feature opts into impls for `Rc` and `Arc`, but none of the data
structures that use Serialize/Deserialize actually contain `Rc` or
`Arc`s.

See:

- [Serde docs](https://serde.rs/feature-flags.html#-features-rc)
- [PR adding this](apache/arrow#3016)

Co-authored-by: Carol (Nichols || Goulding) <[email protected]>
* Update version to 6.4.0

* 6.4.0 release notes

* Correct changelog date
Co-authored-by: Andrew Lamb <[email protected]>

Co-authored-by: Raphael Taylor-Davies <[email protected]>
* Need to use type from data so that we do not lose, for example, timezone information

* add test for take preseving timezone

Co-authored-by: Max Burke <[email protected]>
* Allow Schema and RecordBatch to project schemas on specific columns returning a new schema with those columns only

* Addressing PR updates and adding a test for out of range projection

* switch to &[usize]

* fix: clippy and fmt

Co-authored-by: Andrew Lamb <[email protected]>

Co-authored-by: Stephen Carman <[email protected]>
Signed-off-by: Dmitry Patsura <[email protected]>

Co-authored-by: Dmitry Patsura <[email protected]>
* support cast signed numeric to decimal

* add test for i8,i16,i32,i64,f32,f64 casted to decimal

* change format of float64

* add none test; merge integer test together

Co-authored-by: Kun Liu <[email protected]>
* Box RleDecoder index buffer (#1061)

* Format

Co-authored-by: Raphael Taylor-Davies <[email protected]>
* add cast test macro function; refactor other type to decimal type; add decimal to signed numeric type
support decimal to unsigned numeric

* address the comments and fix the clippy

Co-authored-by: Kun Liu <[email protected]>
* Fix like regex escaping

* Fix like regex escaping

* Fix doctest

* Simplify

Co-authored-by: Daniël Heres <[email protected]>
* support cast decimal to decimal

* add test case

* remove meaningless code

Co-authored-by: Kun Liu <[email protected]>
* Update version to 6.5.0

* Update changelog
@github-actions github-actions bot added the arrow-flight Changes to the arrow-flight crate label Dec 29, 2021
@codecov-commenter
Copy link

codecov-commenter commented Dec 29, 2021

Codecov Report

Merging #1105 (3c5b28f) into active_release (70069c6) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           active_release    #1105   +/-   ##
===============================================
  Coverage           82.45%   82.45%           
===============================================
  Files                 168      168           
  Lines               49413    49413           
===============================================
  Hits                40742    40742           
  Misses               8671     8671           
Impacted Files Coverage Δ
arrow/src/array/transform/mod.rs 85.20% <0.00%> (-0.28%) ⬇️
parquet_derive/src/parquet_field.rs 66.43% <0.00%> (+0.22%) ⬆️
arrow/src/datatypes/datatype.rs 66.38% <0.00%> (+0.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70069c6...3c5b28f. Read the comment docs.

@alamb
Copy link
Contributor Author

alamb commented Jan 10, 2022

Plan is we are going to do do #1120 instead of backporting this, so closing this PR

@alamb alamb closed this Jan 10, 2022
@alamb alamb deleted the cherry_pick_3dca9696 branch January 20, 2022 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow-flight Changes to the arrow-flight crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants