-
Notifications
You must be signed in to change notification settings - Fork 677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(traffic_light_ssd_fine_detector): remove download logic from CMake #3145
build(traffic_light_ssd_fine_detector): remove download logic from CMake #3145
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #3145 +/- ##
==========================================
- Coverage 15.75% 13.07% -2.68%
==========================================
Files 1581 1257 -324
Lines 109651 88806 -20845
Branches 34291 26865 -7426
==========================================
- Hits 17273 11614 -5659
+ Misses 73344 64945 -8399
+ Partials 19034 12247 -6787
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
c537a5b
to
0d88e82
Compare
This pull request has been automatically marked as stale because it has not had recent activity. |
0d88e82
to
6ec8556
Compare
@xmfcx @mitsudome-r this PR is now ready for review |
https://github.com/autowarefoundation/autoware.universe/actions/runs/5530434966/jobs/10089832235?pr=3145 |
6ec8556
to
941da9d
Compare
@wep21 removed, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
941da9d
to
291f03b
Compare
Signed-off-by: Esteve Fernandez <[email protected]>
291f03b
to
5099b52
Compare
Description
See #3137
Depends on autowarefoundation/autoware_common#164
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.