Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(traffic_light_ssd_fine_detector): remove download logic from CMake #3145

Conversation

esteve
Copy link
Contributor

@esteve esteve commented Mar 22, 2023

Description

See #3137

Depends on autowarefoundation/autoware_common#164

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Mar 22, 2023
@codecov
Copy link

codecov bot commented Mar 22, 2023

Codecov Report

Patch coverage has no change and project coverage change: -2.68% ⚠️

Comparison is base (0f441c1) 15.75% compared to head (0d88e82) 13.07%.
Report is 7 commits behind head on main.

❗ Current head 0d88e82 differs from pull request most recent head 5099b52. Consider uploading reports for the commit 5099b52 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3145      +/-   ##
==========================================
- Coverage   15.75%   13.07%   -2.68%     
==========================================
  Files        1581     1257     -324     
  Lines      109651    88806   -20845     
  Branches    34291    26865    -7426     
==========================================
- Hits        17273    11614    -5659     
+ Misses      73344    64945    -8399     
+ Partials    19034    12247    -6787     
Flag Coverage Δ *Carryforward flag
differential ∅ <ø> (?)
total 13.07% <ø> (-2.68%) ⬇️ Carriedforward from 1ed2648

*This pull request uses carry forward flags. Click here to find out more.

see 1098 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@esteve esteve changed the title build(traffic_light_ssd_fine_detector): add DOWNLOAD_ARTIFACTS logic build(traffic_light_ssd_fine_detector): remove download logic from CMake Mar 24, 2023
@esteve esteve force-pushed the add-download-artifacts-traffic-light-ssd-fine-detector branch from c537a5b to 0d88e82 Compare March 28, 2023 11:38
@stale
Copy link

stale bot commented May 27, 2023

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the status:stale Inactive or outdated issues. (auto-assigned) label May 27, 2023
@stale stale bot removed the status:stale Inactive or outdated issues. (auto-assigned) label Jun 20, 2023
@esteve esteve marked this pull request as ready for review July 12, 2023 10:22
@esteve esteve force-pushed the add-download-artifacts-traffic-light-ssd-fine-detector branch from 0d88e82 to 6ec8556 Compare July 12, 2023 10:22
@esteve esteve requested a review from wep21 as a code owner July 12, 2023 10:22
@esteve
Copy link
Contributor Author

esteve commented Jul 12, 2023

@xmfcx @mitsudome-r this PR is now ready for review

@wep21
Copy link
Contributor

wep21 commented Jul 12, 2023

https://github.com/autowarefoundation/autoware.universe/actions/runs/5530434966/jobs/10089832235?pr=3145
@esteve Please remove data from install if you remove download logic.

@esteve esteve force-pushed the add-download-artifacts-traffic-light-ssd-fine-detector branch from 6ec8556 to 941da9d Compare July 12, 2023 15:15
@esteve
Copy link
Contributor Author

esteve commented Jul 12, 2023

@wep21 removed, thanks!

Copy link
Contributor

@wep21 wep21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@esteve esteve force-pushed the add-download-artifacts-traffic-light-ssd-fine-detector branch from 941da9d to 291f03b Compare September 6, 2023 09:45
@esteve esteve marked this pull request as draft September 8, 2023 14:59
@esteve esteve added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Sep 20, 2023
@esteve esteve marked this pull request as ready for review September 20, 2023 10:07
@esteve esteve force-pushed the add-download-artifacts-traffic-light-ssd-fine-detector branch from 291f03b to 5099b52 Compare September 20, 2023 10:28
@esteve esteve enabled auto-merge (squash) September 20, 2023 10:28
@esteve esteve merged commit 2476395 into autowarefoundation:main Sep 20, 2023
@esteve esteve deleted the add-download-artifacts-traffic-light-ssd-fine-detector branch September 20, 2023 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

2 participants