Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BHBC-2162: Release Dev To Test #925

Merged
merged 6 commits into from
Jan 30, 2023
Merged

BHBC-2162: Release Dev To Test #925

merged 6 commits into from
Jan 30, 2023

Conversation

NickPhura
Copy link
Collaborator

Overview

Links to Jira tickets

  • {List all applicable Jira tickets}

Description of relevant changes

  • {List all relevant changes, in particular anything that will help the reviewers test/verify this PR}

PR Checklist

A list of items that are good to consider when making any changes.

Note: this list is not exhaustive, and not all items are always applicable.

Code

  • New files/classes/functions have appropriately descriptive names and comment blocks to describe their use/behaviour
  • I have avoided duplicating code when possible, moving re-usable pieces into functions
  • I have avoided hard-coding values where possible and moved any re-usable constants to a constants file
  • My code is as flat as possible (avoids deeply nested if/else blocks, promise chains, etc)
  • My code changes account for null/undefined values and handle errors appropriately
  • My code uses types/interfaces to help describe values/parameters/etc, help ensure type safety, and improve readability

Style

  • My code follows the established style conventions
  • My code uses native material-ui components/icons/conventions when possible

Documentation

  • I have commented my code sufficiently, such that an unfamiliar developer could understand my code
  • I have added/updated README's and related documentation, as needed

Tests

  • I have added/updated unit tests for any code I've added/updated
  • I have added/updated the Postman requests/tests to account for any API endpoints I've added/updated

Linting/Formatting

  • I have run the linter and fixed any issues, as needed
    See the lint commands in package.json
  • I have run the formatter and fixed any issues, as needed
    See the format commands in package.json

SonarCloud

  • I have addressed all SonarCloud Bugs, Vulnerabilities, Security Hotspots, and Code Smells

curtisupshall and others added 5 commits January 26, 2023 11:24
… type for mismatched focal species (#913)

* BHBC-2145: Occurrence messaging refactoring; Submission message type for mismatched focal species.

* Refactored the way that submission messages are rendered by the SurveyOccurrences component

* Clean-up around SurveyOccurrences component logic + API queries

* Fixed a bug that persists a "Failed to get file from S3" submission message

* Amended messaging related to template species not matching the focal species of a survey
…S Agreements Selected (#923)

* tech debt changes working

* remove column from survey table

* fix tests
* Wrap `true` value in annotation in quotes
* Fix sims svc client number
* Update entitlement names
* Update postgres dockerfile
@codecov
Copy link

codecov bot commented Jan 28, 2023

Codecov Report

Merging #925 (b7dd6a4) into test (03b793f) will increase coverage by 0.08%.
The diff coverage is 67.63%.

@@            Coverage Diff             @@
##             test     #925      +/-   ##
==========================================
+ Coverage   65.64%   65.73%   +0.08%     
==========================================
  Files         353      351       -2     
  Lines       11304    11319      +15     
  Branches     1966     1963       -3     
==========================================
+ Hits         7421     7440      +19     
+ Misses       3488     3475      -13     
- Partials      395      404       +9     
Impacted Files Coverage Δ
api/src/models/survey-view.ts 100.00% <ø> (ø)
api/src/paths/project/{projectId}/survey/create.ts 93.54% <ø> (ø)
...hs/project/{projectId}/survey/{surveyId}/update.ts 93.75% <ø> (ø)
...roject/{projectId}/survey/{surveyId}/update/get.ts 86.11% <ø> (ø)
...aths/project/{projectId}/survey/{surveyId}/view.ts 95.83% <ø> (ø)
api/src/paths/project/{projectId}/surveys.ts 96.29% <ø> (ø)
api/src/queries/queries.ts 100.00% <ø> (ø)
api/src/repositories/occurrence-repository.ts 82.00% <ø> (ø)
api/src/repositories/project-repository.ts 83.92% <ø> (ø)
api/src/services/eml-service.ts 12.21% <ø> (+0.16%) ⬆️
... and 18 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

* Clamav Updates/Fixes
* Update readme
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.2% 0.2% Duplication

Copy link
Contributor

@curtisupshall curtisupshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NickPhura NickPhura merged commit 72514e7 into test Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants