Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] fixes orientation issue after turning news on #13453

Merged
merged 1 commit into from
May 25, 2022

Conversation

alexsafe
Copy link
Contributor

@alexsafe alexsafe commented May 25, 2022

Resolves brave/brave-browser#23060

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Best visible on tablet, but occurs on phones too.

  1. Turn news on and stay in the same tab
  2. Scroll a bit in portrait mode then rotate to landscape
  3. Scroll some more on landscape too then rotate back to portrait
  4. Before, at this point all the cards would have been "squished" together, now it should look normal

Might be useful to do a sanity check for possible regressions like :

  • rotations with optin card on
  • rotations after hitting the 'x' to close the optin card
  • going to tab tray and back, going between tabs
  • disabling news and rotating
    I tested for these scenarios but...

@alexsafe alexsafe added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels May 25, 2022
@alexsafe alexsafe added this to the 1.41.x - Nightly milestone May 25, 2022
@alexsafe alexsafe self-assigned this May 25, 2022
@kjozwiak
Copy link
Member

@alexsafe I closed brave/brave-browser#21868 as that issue already has a PR/code associated with it and was shipped via 1.38.x. We don't re-open closed issues that have already been fixed/have code associated with it. Especially issues that have technically been shipped. This is a new regression/new issue so we should create a new issue.

Once you create the new issues with as much info as possible, please update the original comment via #13453 (comment) to mention the new issue 👍

Copy link
Contributor

@AlexeyBarabash AlexeyBarabash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Follow up to #21868] Changing tablet orientation will re-render cards in news feed incorrectly
3 participants