Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] fixes orientation issue after turning news on (uplift to 1.40.x) #13568

Closed
wants to merge 1 commit into from
Closed

[Android] fixes orientation issue after turning news on (uplift to 1.40.x) #13568

wants to merge 1 commit into from

Conversation

brave-builds
Copy link
Collaborator

Uplift of #13453
Resolves brave/brave-browser#23060

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team June 2, 2022 00:07
@brave-builds brave-builds self-assigned this Jun 2, 2022
@brave-builds brave-builds added this to the 1.40.x - Beta milestone Jun 2, 2022
@kjozwiak
Copy link
Member

kjozwiak commented Jun 3, 2022

Blocked due to brave/brave-browser#23227 which I believe #13453 is causing the crashes.

@kjozwiak kjozwiak mentioned this pull request Jun 9, 2022
Closed
7 tasks
@kjozwiak
Copy link
Member

We're going to let the above ride the trains. Will be released via 1.41.x.

@kjozwiak kjozwiak closed this Jun 22, 2022
@kjozwiak kjozwiak deleted the pr13453_news-orientation-after-optin_1.40.x branch June 22, 2022 02:52
@kjozwiak kjozwiak removed this from the 1.40.x - Release milestone Jun 22, 2022
@kjozwiak kjozwiak removed the request for review from a team June 22, 2022 02:52
@github-actions github-actions bot added this to the 1.40.x - Release #2 milestone Jun 22, 2022
@kjozwiak kjozwiak removed this from the 1.40.x - Release #2 milestone Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brave-builds @kjozwiak @brave-browser-releases