Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] fixes orientation issue after turning news on (uplift to 1.39.x) #13570

Closed
wants to merge 1 commit into from

Conversation

alexsafe
Copy link
Contributor

@alexsafe alexsafe commented Jun 2, 2022

Uplift of #13453
Resolves brave/brave-browser#23060

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@alexsafe alexsafe added this to the 1.39.x - Release #3 milestone Jun 2, 2022
@alexsafe alexsafe requested a review from a team June 2, 2022 00:35
@alexsafe alexsafe force-pushed the pr13453_news-orientation-after-optin_1.39.x branch from 8a1277e to 9190bb7 Compare June 2, 2022 19:16
@kjozwiak
Copy link
Member

kjozwiak commented Jun 3, 2022

Blocked due to brave/brave-browser#23227 which I believe #13453 is causing the crashes.

@kjozwiak
Copy link
Member

kjozwiak commented Jun 9, 2022

Closing as we'll get the above into 1.40.x via #13568. Finally managed to get a crash stack via brave/brave-browser#23227 (comment) so we'll know if brave/brave-browser#23227 caused the issues/crashes.

@kjozwiak kjozwiak closed this Jun 9, 2022
@kjozwiak kjozwiak deleted the pr13453_news-orientation-after-optin_1.39.x branch June 9, 2022 03:31
@kjozwiak kjozwiak removed the request for review from a team June 9, 2022 03:31
@kjozwiak kjozwiak removed this from the 1.39.x - Release #3 milestone Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants