[Wallet] Protect Backup Key and Safeguards with PIN #1556
Merged
+399
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a user tries to open Backup Key or Safeguards screens she should be asked to confirm PIN before proceeding.
i1skn
force-pushed
the
protect-backup-with-pin
branch
from
02585e1 to
cffd515
Compare
Codecov Report
@@ Coverage Diff @@
## master #1556 +/- ##
==========================================
+ Coverage 73.61% 73.64% +0.03%
==========================================
Files 277 277
Lines 7443 7480 +37
Branches 956 667 -289
==========================================
+ Hits 5479 5509 +30
- Misses 1852 1858 +6
- Partials 112 113 +1
Continue to review full report at Codecov.
|
jmrossy
reviewed
Nov 1, 2019
jmrossy
reviewed
Nov 1, 2019
aaronmgdr
added a commit
that referenced
this pull request
Dec 5, 2019
* master: (73 commits) Fix Ethstats Image reference (#1577) EU Cookies Behavior Change (#1447) [verifier] Upgrade to RN 61 (#1572) [Wallet] Update link styles and Implement VerificationEducationScreen (#1565) [wallet] Added native phone picker (#1310) [Wallet] Set up new verification screen skeletons (#1563) Bump e2e test migrate numbers where needed (#1567) [Wallet] Create new carousel component (#1555) [Wallet] Protect Backup Key and Safeguards with PIN (#1556) Increase ganache gas limit (#1569) Re-work locked gold requirements for validators and groups (#1474) Fix e2e on CI (#1537) Allow a specified address to disable/enable the Exchange (#1467) Avoid re-encrypting key files with yarn keys:encrypt command (#1560) Support protocol hotfixing (#613) Point e2e tests back (#1562) Refactor to Accounts.sol (#1392) Add selectIssuers Transaction (#1327) [Wallet] Get React Native Hot Reloading Working (#1551) Unify to prefix messages for signing (#1473) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When a user tries to open Backup Key or Safeguards screens
she should be asked to confirm PIN before proceeding.
See the video - https://drive.google.com/open?id=1--tRRChcnbivpPvIftAdF0_6M89xIq5z
Tested
Ran on Android device
Other changes
This PR introduces
APP/NAVIGATE_PIN_PROTECTEDaction, which can be used to navigate to a screen, which should be protected by PIN.Related issues
Backwards compatibility
Yes