Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Wallet] Set up new verification screen skeletons #1563

Merged
merged 17 commits into from
Nov 4, 2019

Conversation

jmrossy
Copy link
Contributor

@jmrossy jmrossy commented Nov 1, 2019

Description

Note: this PR builds on #1555 which must merge first

Set up new verification screens

Tested

Deferring to when new features are done

Related issues

Backwards compatibility

yes

@jmrossy jmrossy requested a review from cmcewen as a code owner November 1, 2019 10:17
@jmrossy jmrossy changed the title [Wallet] Set up new verification screens [Wallet] Set up new verification screen skeletons Nov 1, 2019
@codecov
Copy link

codecov bot commented Nov 4, 2019

Codecov Report

Merging #1563 into master will increase coverage by 0.32%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1563      +/-   ##
=========================================
+ Coverage   73.68%     74%   +0.32%     
=========================================
  Files         276     283       +7     
  Lines        7428    7521      +93     
  Branches      662     955     +293     
=========================================
+ Hits         5473    5566      +93     
  Misses       1843    1843              
  Partials      112     112
Flag Coverage Δ
#mobile 74% <100%> (+0.32%) ⬆️
Impacted Files Coverage Δ
packages/mobile/src/navigator/Screens.tsx 100% <100%> (ø) ⬆️
.../mobile/src/verify/VerificationLearnMoreScreen.tsx 100% <100%> (ø)
...es/mobile/src/verify/VerificationSuccessScreen.tsx 100% <100%> (ø)
.../mobile/src/verify/VerificationEducationScreen.tsx 100% <100%> (ø)
...es/mobile/src/verify/VerificationLoadingScreen.tsx 100% <100%> (ø)
packages/mobile/src/components/DevSkipButton.tsx 76% <100%> (ø) ⬆️
...ages/mobile/src/verify/VerificationInputScreen.tsx 100% <100%> (ø)
...bile/src/verify/VerificationInterstitialScreen.tsx 100% <100%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 934ef50...21ddf18. Read the comment docs.

Copy link
Contributor

@jeanregisser jeanregisser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jmrossy jmrossy merged commit ef1a797 into master Nov 4, 2019
@jmrossy jmrossy deleted the rossy/wa-new-verification-screens branch November 4, 2019 18:16
aaronmgdr added a commit that referenced this pull request Dec 5, 2019
* master: (73 commits)
  Fix Ethstats Image reference (#1577)
  EU Cookies Behavior Change (#1447)
  [verifier] Upgrade to RN 61 (#1572)
  [Wallet] Update link styles and Implement VerificationEducationScreen (#1565)
  [wallet] Added native phone picker (#1310)
  [Wallet] Set up new verification screen skeletons (#1563)
  Bump e2e test migrate numbers where needed (#1567)
  [Wallet] Create new carousel component (#1555)
  [Wallet] Protect Backup Key and Safeguards with PIN (#1556)
  Increase ganache gas limit (#1569)
  Re-work locked gold requirements for validators and groups (#1474)
  Fix e2e on CI (#1537)
  Allow a specified address to disable/enable the Exchange  (#1467)
  Avoid re-encrypting key files with yarn keys:encrypt command (#1560)
  Support protocol hotfixing (#613)
  Point e2e tests back (#1562)
  Refactor to Accounts.sol (#1392)
  Add selectIssuers Transaction (#1327)
  [Wallet] Get React Native Hot Reloading Working (#1551)
  Unify to prefix messages for signing (#1473)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants