Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

Reflect task status in the task custom resource status #190

Closed
danail-branekov opened this issue Apr 14, 2021 · 0 comments
Closed

Reflect task status in the task custom resource status #190

danail-branekov opened this issue Apr 14, 2021 · 0 comments
Labels
M Estimated completixy: medium
Milestone
CRDs

Comments

@danail-branekov
Copy link
Member

Currently it is not possible to see that task status via inspecting the task custom resource. In a CC-less world, CR API users would be interested to know what is going on with their tasks.

Acceptance:

Happy path

  • Create a task
  • See that the task status says that the task is running
  • Wait for the task to complete
  • See that the task status is completed

Starting task

  • Create a task with a non-existent image
  • See that task status is starting (or anything different from running)

Failing task

  • Create a task with a command that fails
  • See the task status eventually goes failed
  • See the error message in the task status
@danail-branekov danail-branekov added this to the crds milestone Apr 14, 2021
@gcapizzi gcapizzi added the M Estimated completixy: medium label Apr 19, 2021
danail-branekov added a commit to cloudfoundry/eirini that referenced this issue May 10, 2021
@danail-branekov
trying to get execution-status working...
a849d05 
[cloudfoundry/eirini-release#190]

Co-authored-by: Danail Branekov <[email protected]>
danail-branekov added a commit that referenced this issue May 10, 2021
@danail-branekov
Add status to task CRD
af0321e 
[#190]

Co-authored-by: Danail Branekov <[email protected]>
@gcapizzi gcapizzi assigned gcapizzi and unassigned danail-branekov May 11, 2021
gcapizzi added a commit to cloudfoundry/eirini that referenced this issue May 11, 2021
@gcapizzi
WIP
febc468 
Co-authored-by: Giuseppe Capizzi <[email protected]>
Issue: cloudfoundry/eirini-release#190
kieron-dev pushed a commit that referenced this issue May 11, 2021
@gcapizzi
WIP
882378e 
Co-authored-by: Kieron Browne <[email protected]>
Issue: #190
@kieron-dev kieron-dev assigned mnitchev and unassigned kieron-dev May 12, 2021
mnitchev pushed a commit to cloudfoundry/eirini that referenced this issue May 12, 2021
@eirinici
wip
f01ae16 
Co-authored-by: Anonymous Eirininaut <[email protected]>
Issue: cloudfoundry/eirini-release#182
Issue: cloudfoundry/eirini-release#184
Issue: cloudfoundry/eirini-release#185
Issue: cloudfoundry/eirini-release#187
Issue: cloudfoundry/eirini-release#186
Issue: cloudfoundry/eirini-release#183
Issue: cloudfoundry/eirini-release#192
Issue: cloudfoundry/eirini-release#193
Issue: cloudfoundry/eirini-release#194
Issue: cloudfoundry/eirini-release#191
Issue: cloudfoundry/eirini-release#196
Issue: cloudfoundry/eirini-release#199
Issue: cloudfoundry/eirini-release#200
Issue: cloudfoundry/eirini-release#201
Issue: cloudfoundry/eirini-release#202
Issue: cloudfoundry/eirini-release#204
Issue: cloudfoundry/eirini-release#205
Issue: cloudfoundry/eirini-release#195
Issue: cloudfoundry/eirini-release#198
Issue: cloudfoundry/eirini-release#211
Issue: cloudfoundry/eirini-release#212
Issue: cloudfoundry/eirini-release#207
Issue: cloudfoundry/eirini-release#190
Issue: cloudfoundry/eirini-release#209
gcapizzi added a commit that referenced this issue May 12, 2021
@mnitchev @gcapizzi
wip
6f50d17 
Co-authored-by: Giuseppe Capizzi <[email protected]>
Issue: #190
@gcapizzi gcapizzi assigned georgethebeatle and unassigned gcapizzi May 17, 2021
georgethebeatle added a commit to cloudfoundry/eirini that referenced this issue May 17, 2021
@georgethebeatle
wip finish status getter
1af341d 
Co-authored-by: Mario Nitchev <[email protected]>

Issue: cloudfoundry/eirini-release#190
georgethebeatle pushed a commit to cloudfoundry/eirini that referenced this issue May 17, 2021
@georgethebeatle
Reflect task status in the Task CR
dbe79d8 
Co-authored-by: Giuseppe Capizzi <[email protected]>
Co-authored-by: Mario Nitchev <[email protected]>
Co-authored-by: Georgi Sabev <[email protected]>

Issue: cloudfoundry/eirini-release#190
georgethebeatle pushed a commit that referenced this issue May 17, 2021
@gcapizzi @georgethebeatle
Add status to task crd. Add patch task permissions to controller
b9bf79d 
Co-authored-by: Kieron Browne <[email protected]>
Co-authored-by: Giuseppe Capizzi <[email protected]>
Co-authored-by: Mario Nitchev <[email protected]>
Co-authored-by: Georgi Sabev <[email protected]>

Issue: #190
kieron-dev pushed a commit that referenced this issue May 17, 2021
@eirinici
Update image versions
2e98c86 
eirini commit SHA: dbe79d827118d0c8ff655ebfad83518ebd468448
eirini commit message:
Reflect task status in the Task CR

Co-authored-by: Giuseppe Capizzi <[email protected]>
Co-authored-by: Mario Nitchev <[email protected]>
Co-authored-by: Georgi Sabev <[email protected]>

Issue: #190
@gcapizzi gcapizzi assigned gcapizzi and unassigned georgethebeatle May 19, 2021
gcapizzi added a commit to cloudfoundry/eirini that referenced this issue May 19, 2021
@danail-branekov @georgethebeatle @gcapizzi
Introduce LRP CR client
6de83cd 
We want to align the LRP reconciler implementation with the task
one.

Co-authored-by: Georgi Sabev <[email protected]>
Co-authored-by: Danail Branekov <[email protected]>
Co-authored-by: Giuseppe Capizzi <[email protected]>
Issue: cloudfoundry/eirini-release#190
gcapizzi added a commit that referenced this issue May 19, 2021
@danail-branekov @gcapizzi
Update rbac permisions for lrp controller
97335be 
It now uses `patch` to update the lrp status instead of `update`

Co-authored-by: Giuseppe Capizzi <[email protected]>
Issue: #190
gcapizzi added a commit to cloudfoundry/eirini that referenced this issue May 19, 2021
@danail-branekov @georgethebeatle @gcapizzi
Introduce LRP CR client
bb99fc0 
We want to align the LRP reconciler implementation with the task
one.

Co-authored-by: Georgi Sabev <[email protected]>
Co-authored-by: Danail Branekov <[email protected]>
Co-authored-by: Giuseppe Capizzi <[email protected]>
Issue: cloudfoundry/eirini-release#190
gcapizzi added a commit that referenced this issue May 19, 2021
@danail-branekov @gcapizzi
Make LRP GUID mandatory
0e90b6c 
That would enable us to link LRP CR with the underlying statefulset via
GUID rather than name

Co-authored-by: Giuseppe Capizzi <[email protected]>
Issue: #190
danail-branekov added a commit to cloudfoundry/eirini that referenced this issue May 19, 2021
@danail-branekov @gcapizzi
Introduce GetStatus to the LRP client
cca6ec7 
Thus the LRP reconciler can obtain the status of an LRP without looking
up the statefulset explicitly. Thus the custom resource reconciler does
not have to know that the LRP is backed by a statefulset.

Co-authored-by: Giuseppe Capizzi <[email protected]>
Issue: cloudfoundry/eirini-release#190
kieron-dev pushed a commit that referenced this issue May 19, 2021
@eirinici @gcapizzi
Update image versions
9aa1a73 
eirini commit SHA: cca6ec713d321f5a3c521c981a03d2fdd11422d5
eirini commit message:
Introduce `GetStatus` to the LRP client

Thus the LRP reconciler can obtain the status of an LRP without looking
up the statefulset explicitly. Thus the custom resource reconciler does
not have to know that the LRP is backed by a statefulset.

Co-authored-by: Giuseppe Capizzi <[email protected]>
Issue: #190
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
M Estimated completixy: medium
Projects
None yet
Milestone
CRDs
Development

No branches or pull requests
5 participants
@gcapizzi @danail-branekov @georgethebeatle @mnitchev @kieron-dev