Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

Delete a Task Job after its grace period #195

Closed
danail-branekov opened this issue Apr 14, 2021 · 1 comment
Closed

Delete a Task Job after its grace period #195

danail-branekov opened this issue Apr 14, 2021 · 1 comment
Assignees
Labels
M Estimated completixy: medium
Milestone

Comments

@danail-branekov
Copy link
Member

Acceptance

  • Make sure that the task reporter is not running (because it is not needed for a CR setup - it talks to the CC which is not available in an Eirini-only setup and has a side effect of deleting jobs)
  • Create a task via a custom resource
  • Wait for the task to complete (either complete successfully, or fail)
  • Make sure the K8S job stays around for at least the grace period
  • Wait for the job deletion grace period
  • See that the job is eventually gone
  • Make sure that the K8S job is not recreated (by e.g. the tasks controller)
@kieron-dev
Copy link
Contributor

As part of #198, we have introduced a check in the task-reporter which stops the reconciliation when it discovers a job is owned by a Task CR. Soon to be pushed. That helps this story a little bit, as it won't matter if the task-reporter is running or not.

mnitchev added a commit to cloudfoundry/eirini that referenced this issue May 19, 2021
@georgethebeatle georgethebeatle self-assigned this May 20, 2021
mnitchev added a commit that referenced this issue May 20, 2021
mnitchev added a commit to cloudfoundry/eirini that referenced this issue May 20, 2021
Co-authored-by: Mario Nitchev <[email protected]>
Issue: cloudfoundry/eirini-release#195
mnitchev added a commit to cloudfoundry/eirini that referenced this issue May 20, 2021
mnitchev added a commit to cloudfoundry/eirini that referenced this issue May 20, 2021
Co-authored-by: Georgi Sabev <[email protected]>
Co-authored-by: Mario Nitchev <[email protected]>
Issue: cloudfoundry/eirini-release#195
mnitchev added a commit that referenced this issue May 20, 2021
gcapizzi added a commit that referenced this issue May 25, 2021
`tasks.ttl_seconds` already existed as we used it in the task reporter
`ConfigMap`, but we were not templating as `task_ttl_seconds` in the
`eirini-controller` `ConfigMap`.

Issue: #195
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
M Estimated completixy: medium
Projects
None yet
Development

No branches or pull requests

5 participants