This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
Remove the completionCallback property from the Task CR
#198
Comments
danail-branekov
changed the title
completionCallback from the Task CRcompletionCallback property from the Task CR
mnitchev
pushed a commit
to cloudfoundry/eirini
that referenced
this issue
May 12, 2021
Co-authored-by: Anonymous Eirininaut <[email protected]> Issue: cloudfoundry/eirini-release#182 Issue: cloudfoundry/eirini-release#184 Issue: cloudfoundry/eirini-release#185 Issue: cloudfoundry/eirini-release#187 Issue: cloudfoundry/eirini-release#186 Issue: cloudfoundry/eirini-release#183 Issue: cloudfoundry/eirini-release#192 Issue: cloudfoundry/eirini-release#193 Issue: cloudfoundry/eirini-release#194 Issue: cloudfoundry/eirini-release#191 Issue: cloudfoundry/eirini-release#196 Issue: cloudfoundry/eirini-release#199 Issue: cloudfoundry/eirini-release#200 Issue: cloudfoundry/eirini-release#201 Issue: cloudfoundry/eirini-release#202 Issue: cloudfoundry/eirini-release#204 Issue: cloudfoundry/eirini-release#205 Issue: cloudfoundry/eirini-release#195 Issue: cloudfoundry/eirini-release#198 Issue: cloudfoundry/eirini-release#211 Issue: cloudfoundry/eirini-release#212 Issue: cloudfoundry/eirini-release#207 Issue: cloudfoundry/eirini-release#190 Issue: cloudfoundry/eirini-release#209
kieron-dev
pushed a commit
to cloudfoundry/eirini
that referenced
this issue
May 19, 2021
In the CRD world the CC would have to watch the Task Status rather than be notified when a Task completes. The task reporter now ignores any jobs that are owned by a Task CR. Issue: cloudfoundry/eirini-release#198 Co-authored-by: Georgi Sabev <[email protected]>
kieron-dev
pushed a commit
that referenced
this issue
May 19, 2021
Issue: #198 Co-authored-by: Kieron Browne <[email protected]>
kieron-dev
pushed a commit
that referenced
this issue
May 19, 2021
eirini commit SHA: 994f8eaa5dcab1d00ea77ac3683350a019bc56ae eirini commit message: Remove completionCallback from Task CR Status In the CRD world the CC would have to watch the Task Status rather than be notified when a Task completes. The task reporter now ignores any jobs that are owned by a Task CR. Issue: #198 Co-authored-by: Georgi Sabev <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The callback URL is only used by CC. In a CRD world, one should monitor the custom resource, rather than expect being called back.
Implementation note
As we do this, we should also make sure
task-reporterdoesn't try to report on tasks created through theTaskCRD.The text was updated successfully, but these errors were encountered: