Merge master into features/interpolated-string-constants #49666

333fred · 2020-11-30T18:45:19Z

No description provided.

…s-deps Merge master to master-vs-deps

…109.8 (dotnet#49240) [master] Update dependencies from dotnet/roslyn

…Access

…s-deps Merge master to master-vs-deps

* Enable pull model diagnostic for XAML. * address code review comments * Update some comments

…otnet#49246)

…te-eventhookup Remove duplicated implementations of C# event hookup

…s-deps Merge master to master-vs-deps

Fix mapping in razor x-file codespaces

…s-deps Merge master to master-vs-deps

…Interface Do not convert an unconstrained generic to a nullable struct.

…s-deps Merge master to master-vs-deps

Fixes dotnet#48587

This change refactors and moves the BlockStructure service and providers to the shared Workspace utilities layer. The core APIs are now based off SyntaxTree instead of Document to allow the service to be used from an analyzer context, which is required for dotnet#49197.

This was broken by 7fa2c96, where I asserted that GetDiagnosticItems was only called when we already knew we would have items. This was broken since right before we called the method the collection would get created, which changed the answer it would return. A small refactoring ensures we create the list and fill it in at once. This also makes it clear we aren't passing a non-trivial LINQ query across method boundaries anyways in a way that might result in multiple enumerations. Fixes dotnet#49524

…sts.DDRIT_RPS_ManagedLangs_Typing runs

…zer-list Fix the ability to expand the list of analyzers in a reference

Update Versions.props and PublishData.json for 16.9p2 snap

/warnaserror-:DiagnosticId should not nullify editorconfig diagnostic…

…edlangtyping Fix sporadic OptProf failure

…ding" (dotnet#49588)

…are known to have no effect on the outcome of the function. (dotnet#49610) This avoids unnecessary work and fixes dotnet#49286.

…all langs instead of using inheritance

…itional_expr Preserve parens required by C# when simplifying interpolation

* upstream/master: (265 commits) Use extra generic type parameters and apply C#-specific knowledge to all langs instead of using inheritance Cover all changed code paths Stop removing parens that are required by C# Fix unnecessary spans Failing test for preserving parens around conditional expression AddSynthesizedRecordMembersIfNecessary - avoid touching members that are known to have no effect on the outcome of the function. (dotnet#49610) Resolve follow-up comments in PR "Create default arguments during binding" (dotnet#49588) Remove restore and checkout from test jobs (dotnet#49452) 3.8.* -> 3.9.* Update PublishData.json Update Versions.props Remove Microsoft.CodeAnalysis.VisualBasic.dll from the VSPE.OptProfTests.DDRIT_RPS_ManagedLangs_Typing runs Fix the ability to expand the list of analyzers in a reference Fix comment Address feedback to ensure `/warnaserror-:ID` prevents config options from bumping a warning to an error. parallel restore on mac/linux (dotnet#49523) VSMac: Make QuickFix preview resizable and add title (dotnet#49394) Add CallerMemberNameAttributeWithImplicitObjectCreation test (dotnet#49556) Update dependencies from https://github.com/dotnet/arcade build 20201120.10 (dotnet#49541) Clarify comment ...

ghost · 2020-11-30T18:45:44Z

Hello @333fred!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 12 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.

ghost

Auto-approval

Youssef1313 and others added 30 commits November 9, 2020 21:20

Add test for with expression in F1 help service (dotnet#49236)

931a86a

Merge pull request dotnet#49238 from dotnet/merges/master-to-master-v…

5894b99

…s-deps Merge master to master-vs-deps

Update dependencies from https://github.com/dotnet/roslyn build 20201…

d4cef9e

…109.8 (dotnet#49240) [master] Update dependencies from dotnet/roslyn

Do not convert an unconstrained generic to a nullable struct.

f001726

Add tests

2282d1a

Merge remote-tracking branch 'upstream/master' into vsProjectExternal…

4ea49b9

…Access

Respond to CR

732eafd

Add DocumentServiceProvider for LSP contained documents

63a0d7d

Re-add members to be removed to avoid API break

7c9ceac

Remove comment

0977eaf

Merge pull request dotnet#49241 from dotnet/merges/master-to-master-v…

fd2026d

…s-deps Merge master to master-vs-deps

Enable LSP pull model diagnostic for XAML. (dotnet#49145)

2a08a60

* Enable pull model diagnostic for XAML. * address code review comments * Update some comments

Remove workaround in PEMethodSymbol.ExplicitInterfaceImplementations (d…

65460c4

…otnet#49246)

Merge pull request dotnet#49092 from jasonmalinowski/clean-up-duplica…

3d60b75

…te-eventhookup Remove duplicated implementations of C# event hookup

Fix analysis of parameter default values (dotnet#49009)

0f21966

Merge pull request dotnet#49251 from dotnet/merges/master-to-master-v…

f09e611

…s-deps Merge master to master-vs-deps

Merge pull request dotnet#49220 from dibarbet/rename_codespaces

167a47d

Fix mapping in razor x-file codespaces

Merge pull request dotnet#49254 from dotnet/merges/master-to-master-v…

990c7cc

…s-deps Merge master to master-vs-deps

Experiment with getting live diagnostics

3c5a74d

Merge pull request dotnet#49242 from CyrusNajmabadi/unconstrainedImpl…

ec71e62

…Interface Do not convert an unconstrained generic to a nullable struct.

Fix namespace FAR LSP bug

2f18ddc

Merge pull request dotnet#49257 from dotnet/merges/master-to-master-v…

fdf8391

…s-deps Merge master to master-vs-deps

Merge remote-tracking branch 'upstream/master' into liveDiag

c112ab5

Fix property parsing when it contains parantheses (dotnet#48598)

f609480

Fixes dotnet#48587

Use release packages for S.R.MD and S.C.I

8514a3b

Update package version to fix downgrade warning

9064d95

Fix tests

cb49d0a

Re-enable and add tests

460250a

Enable analyzers in Mac build (dotnet#49255)

07d1713

jasonmalinowski and others added 19 commits November 23, 2020 14:10

Remove Microsoft.CodeAnalysis.VisualBasic.dll from the VSPE.OptProfTe…

3f4764e

…sts.DDRIT_RPS_ManagedLangs_Typing runs

Merge pull request dotnet#49574 from jasonmalinowski/fix-broken-analy…

4262935

…zer-list Fix the ability to expand the list of analyzers in a reference

Update Versions.props

7aa2bd0

Update PublishData.json

744fcb9

3.8.* -> 3.9.*

593a01d

Merge pull request dotnet#49586 from dotnet/allisonchou-patch-1

409611f

Update Versions.props and PublishData.json for 16.9p2 snap

Remove restore and checkout from test jobs (dotnet#49452)

e192dc2

Merge pull request dotnet#49449 from mavasani/FixWarnAsErrorMinus

c536d5b

/warnaserror-:DiagnosticId should not nullify editorconfig diagnostic…

Merge pull request dotnet#49577 from ryzngard/issues/optprof_vb_manag…

88aca6f

…edlangtyping Fix sporadic OptProf failure

Resolve follow-up comments in PR "Create default arguments during bin…

1f97e38

…ding" (dotnet#49588)

AddSynthesizedRecordMembersIfNecessary - avoid touching members that …

f8107de

…are known to have no effect on the outcome of the function. (dotnet#49610) This avoids unnecessary work and fixes dotnet#49286.

Failing test for preserving parens around conditional expression

6fd97d4

Fix unnecessary spans

7bd2597

Stop removing parens that are required by C#

2cf1a51

Cover all changed code paths

5949b49

Use extra generic type parameters and apply C#-specific knowledge to …

4365779

…all langs instead of using inheritance

Merge pull request dotnet#49655 from jnm2/simplify_interpolation_cond…

1a5d65c

…itional_expr Preserve parens required by C# when simplifying interpolation

333fred requested review from a team as code owners November 30, 2020 18:45

Dotnet-GitSync-Bot added the Area-Infrastructure label Nov 30, 2020

333fred added the auto-merge label Nov 30, 2020

ghost approved these changes Nov 30, 2020

View reviewed changes

ghost merged commit 9177f96 into dotnet:features/interpolated-string-constants Nov 30, 2020

333fred deleted the merge-master branch November 30, 2020 21:46

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Merge master into features/interpolated-string-constants #49666

Merge master into features/interpolated-string-constants #49666

333fred commented Nov 30, 2020

ghost commented Nov 30, 2020

ghost left a comment

Merge master into features/interpolated-string-constants #49666

Merge master into features/interpolated-string-constants #49666

Conversation

333fred commented Nov 30, 2020

ghost commented Nov 30, 2020

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

ghost left a comment

Choose a reason for hiding this comment

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.