Fix cmake version #183
Merged
Fix cmake version #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 17, 2022 10:15
|
Hmm, facing an issue with this on 20.04-based containers: #181 (comment) |
|
Oh boy, good catch. You know I'm wondering now if it wasn't just simpler to checkout the fix in ament_cmake.... P.S: I'm testing that right now |
tonynajjar
force-pushed
the
fix-cmake-master
branch
from
ae85149 to
f686d69
Compare
|
I adjusted the PR. It reverts your patches and clones ament_cmake instead. I tested it only for galactic |
tonynajjar
force-pushed
the
fix-cmake-master
branch
from
8e6c9b6 to
6b6bdcc
Compare
|
OK thanks, I am trying to rebuild Foxy with this on JetPack 4 and JetPack 5 now |
|
OK, seems like we are all good here 👍 |
|
Happy to hear that! Just gotta remember to remove the workaround after foxy, galactic and humble are synced, which is probably not before a month from now, given that galactic was synced recently |
rbonghi
added a commit
to rnanosaur/nanosaur_perception
that referenced
this pull request
Sep 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch didn't work for us but we have a particular setup, it might work for others. Nevertheless I wanted to propose the fix that worked for us, that might actually be cleaner than the original patch in two ways:
1- no need for pip
2- hold cmake to this version to avoid accidental upgrade